[CP-stable]Handle "Service connection disposed" error from VmService disconnecting while requests are outstanding #153769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng while requests are outstanding (flutter#153714) Fixes umbrella issue flutter#153471, including its children: flutter#153472, flutter#153473, and flutter#153474. The VM service can be disposed at any time during requests (e.g. the user closes the app or stops debugging in VSCode)[^1]. dart-lang/sdk@a479f91 and dart-lang/sdk@a7d8707 updated package:vm_service to throw new `RPCError`s when the service disconnects while requests are inflight. Therefore, we need to handle these exceptions in the tool. See umbrella issue for more details. I plan on cherry-picking this change to the stable channel. [^1]: flutter#153471 (comment)
Author
|
@andrewkolos please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
6 tasks
reidbaker
approved these changes
Aug 26, 2024
…02c76204a78b4be0a079886eef
reidbaker
added
the
autosubmit
auto-submit bot
pushed a commit
that referenced
this pull request
Sep 3, 2024
# Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…Service disconnecting while requests are outstanding (flutter/flutter#153769)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
…Service disconnecting while requests are outstanding (flutter/flutter#153769)
6 tasks
Gustl22
pushed a commit
to Gustl22/flutter
that referenced
this pull request
Nov 13, 2024
…er#154430) # Flutter stable 3.24.0 Framework ## Scheduled Cherrypicks [flutter/153949](flutter#153949): Fix a crash when deleting text inside CupertinoPageRoute, with a CJK (chinese, japanese, korean) keyboard on Android. [flutter/153939](flutter#153939): Fixes an issue where Flutter TextField may stop accepting input on iOS. [flutter/152420](flutter#152420): Fixes scrolling jank when a SelectionArea/SelectableRegion is used as a child of a Scrollable like ListView or PageView on Android and iOS. [flutter/154199](flutter#154199): Removes log spam when building a freshly created template app for Android. [flutter/153967](flutter#153967): Fixes macOS host build failure when there are no native asset frameworks to codesign. Impacts users who have enabled experimental native assets feature. [flutter/153769](flutter#153769): When running a Flutter app, display a concise error message when connection to the device is lost. [flutter/154270](flutter#154270): Prevent preemptive gradle crash for android builds that would fail to build anyway but with a confusing error message. [flutter/54735](flutter/engine#54735): When semantics are enabled on Web, the onTap of various widgets (GestureDetector, InkWell) are called twice or the callback from one widget is called when another widget is pressed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#153471
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
[CLI] When running a Flutter app, a noisy crash message is displayed when the connection to the device is lost.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
When running an app (e.g. using
flutter run) and the connection to the device is lost (e.g. user shutdown the device), a noisy crash message is displayed instead of showing something concise and useful such as "Lost connection to device."Workaround:
Is there a workaround for this issue?
Not necessary. Most users will be able to rerun their app without problems.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
N/A. No repro is known.