Handle "Service connection disposed" error from VmService disconnecting while requests are outstanding #153714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
andrewkolos
changed the title
andrewkolos
force-pushed
the
handle-service-connection-disposed
branch
from
3105fce to
0f787f9
Compare
Contributor
Author
This was
linked to
issues
Aug 19, 2024
DanTup
approved these changes
Aug 20, 2024
Contributor
DanTup
left a comment
DanTup
left a comment
There was a problem hiding this comment.
Looks reasonable to me. I think we should define a new error code and add handling for it too, to move these errors away from string checks in future (there's a discussion about this in one of the linked issues).
andrewkolos
added
the
autosubmit
andrewkolos
added
the
cp: stable
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Aug 20, 2024
…ng while requests are outstanding (flutter#153714) Fixes umbrella issue flutter#153471, including its children: flutter#153472, flutter#153473, and flutter#153474. The VM service can be disposed at any time during requests (e.g. the user closes the app or stops debugging in VSCode)[^1]. dart-lang/sdk@a479f91 and dart-lang/sdk@a7d8707 updated package:vm_service to throw new `RPCError`s when the service disconnects while requests are inflight. Therefore, we need to handle these exceptions in the tool. See umbrella issue for more details. I plan on cherry-picking this change to the stable channel. [^1]: flutter#153471 (comment)
andrewkolos
added
cp: stable
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
…connecting while requests are outstanding (flutter/flutter#153714)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
…connecting while requests are outstanding (flutter/flutter#153714)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
…connecting while requests are outstanding (flutter/flutter#153714)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 20, 2024
flutter/flutter@6a28048...e7da16d 2024-08-20 [email protected] Fixes page.onPopInvoked type mismatches (flutter/flutter#153593) 2024-08-20 [email protected] When the app enters the detached state, clear the record of the last SystemChrome style sent to the host (flutter/flutter#153586) 2024-08-20 [email protected] Handle "Service connection disposed" error from VmService disconnecting while requests are outstanding (flutter/flutter#153714) 2024-08-20 [email protected] Roll Flutter Engine from ec775a3a645e to e10b07598091 (1 revision) (flutter/flutter#153764) 2024-08-20 [email protected] Roll Packages from 7c1a05c to 4d2d2e3 (6 revisions) (flutter/flutter#153763) 2024-08-20 [email protected] Roll Flutter Engine from 0ac9e97cc1c0 to ec775a3a645e (1 revision) (flutter/flutter#153761) 2024-08-20 [email protected] Reland "Load parent package config" (flutter/flutter#153754) 2024-08-20 [email protected] Roll Flutter Engine from 48d7b04674d9 to 0ac9e97cc1c0 (2 revisions) (flutter/flutter#153753) 2024-08-20 [email protected] Revert "Load parent package config" (flutter/flutter#153752) 2024-08-20 [email protected] Roll Flutter Engine from b0284aac7b4d to 48d7b04674d9 (1 revision) (flutter/flutter#153746) 2024-08-20 [email protected] Load parent package config (flutter/flutter#150850) 2024-08-20 [email protected] Roll Flutter Engine from 20b8a5c13742 to b0284aac7b4d (1 revision) (flutter/flutter#153743) 2024-08-20 [email protected] Roll Flutter Engine from 86f269bd5261 to 20b8a5c13742 (2 revisions) (flutter/flutter#153741) 2024-08-20 [email protected] Roll Flutter Engine from 5355c0b60e6e to 86f269bd5261 (4 revisions) (flutter/flutter#153739) 2024-08-20 [email protected] Roll Flutter Engine from 7dd71ff80d23 to 5355c0b60e6e (1 revision) (flutter/flutter#153734) 2024-08-20 [email protected] Roll Flutter Engine from 9d7e3a6b97d0 to 7dd71ff80d23 (4 revisions) (flutter/flutter#153733) 2024-08-19 [email protected] refactor material banner and fix focus issue (flutter/flutter#152646) 2024-08-19 [email protected] Roll Flutter Engine from 30ffbfaf6a06 to 9d7e3a6b97d0 (3 revisions) (flutter/flutter#153724) 2024-08-19 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.2 to 3.26.3 (flutter/flutter#153726) 2024-08-19 [email protected] Roll Flutter Engine from c5d23162bb9b to 30ffbfaf6a06 (1 revision) (flutter/flutter#153721) 2024-08-19 [email protected] Roll Flutter Engine from bf538a0a98b0 to c5d23162bb9b (1 revision) (flutter/flutter#153719) 2024-08-19 [email protected] Remove android stack_size_test (flutter/flutter#153695) 2024-08-19 [email protected] Roll Flutter Engine from e29b5529080d to bf538a0a98b0 (2 revisions) (flutter/flutter#153713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ng while requests are outstanding (flutter#153714) Fixes umbrella issue flutter#153471, including its children: flutter#153472, flutter#153473, and flutter#153474. The VM service can be disposed at any time during requests (e.g. the user closes the app or stops debugging in VSCode)[^1]. dart-lang/sdk@a479f91 and dart-lang/sdk@a7d8707 updated package:vm_service to throw new `RPCError`s when the service disconnects while requests are inflight. Therefore, we need to handle these exceptions in the tool. See umbrella issue for more details. I plan on cherry-picking this change to the stable channel. [^1]: flutter#153471 (comment)
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…connecting while requests are outstanding (flutter/flutter#153714)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…connecting while requests are outstanding (flutter/flutter#153714)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes umbrella issue #153471, including its children: #153472, #153473, and #153474.
The VM service can be disposed at any time during requests (e.g. the user closes the app or stops debugging in VSCode)1. dart-lang/sdk@a479f91 and dart-lang/sdk@a7d8707 updated package:vm_service to throw new
RPCErrors when the service disconnects while requests are inflight. Therefore, we need to handle these exceptions in the tool. See umbrella issue for more details.I plan on cherry-picking this change to the stable channel.
Pre-launch Checklist
///).Footnotes
https://github.com/flutter/flutter/issues/153471#issuecomment-2296294221 ↩