Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" #153627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
fluttergithubbot
approved these changes
Aug 17, 2024
auto-submit
bot
deleted the
revert_28c4dfabd9490f1f7589735a6310c8c2e1d4f305
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 19, 2024
flutter/flutter@a0c0453...6a28048 2024-08-19 [email protected] Update goldctl git revision (flutter/flutter#153710) 2024-08-19 [email protected] Do not cancel the VmService's subscription to the isolate event stream in FlutterVmService.findExtensionIsolate (flutter/flutter#153607) 2024-08-19 [email protected] Roll Packages from 2c37fb0 to 7c1a05c (3 revisions) (flutter/flutter#153698) 2024-08-19 [email protected] Roll Flutter Engine from 52621de86f54 to e29b5529080d (1 revision) (flutter/flutter#153699) 2024-08-19 [email protected] Roll Flutter Engine from 356d51d46736 to 52621de86f54 (1 revision) (flutter/flutter#153693) 2024-08-19 [email protected] Roll Flutter Engine from ef8252cbbd6a to 356d51d46736 (1 revision) (flutter/flutter#153685) 2024-08-19 [email protected] Roll Flutter Engine from cf12bb6465e8 to ef8252cbbd6a (1 revision) (flutter/flutter#153681) 2024-08-19 [email protected] Roll Flutter Engine from c28282d39f4a to cf12bb6465e8 (1 revision) (flutter/flutter#153674) 2024-08-19 [email protected] Roll Flutter Engine from d0d7de5c333d to c28282d39f4a (1 revision) (flutter/flutter#153671) 2024-08-18 [email protected] Manual roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) (flutter/flutter#153659) 2024-08-18 [email protected] [gen_l10n] `isCustomDateFormat` accepts an actual boolean (flutter/flutter#153439) 2024-08-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" (flutter/flutter#153627) 2024-08-17 [email protected] Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (flutter/flutter#153618) 2024-08-17 [email protected] Roll pub packages (flutter/flutter#153581) 2024-08-17 [email protected] Roll Flutter Engine from cc732b4c698e to c94651c33b0e (1 revision) (flutter/flutter#153609) 2024-08-16 [email protected] Roll Flutter Engine from acb71d8307fa to cc732b4c698e (1 revision) (flutter/flutter#153605) 2024-08-16 [email protected] fix some unintended HTML tags in docs (flutter/flutter#153507) 2024-08-16 [email protected] Roll Flutter Engine from b66893e1fb7e to acb71d8307fa (1 revision) (flutter/flutter#153600) 2024-08-16 [email protected] Roll Flutter Engine from d5bf3afc601f to b66893e1fb7e (2 revisions) (flutter/flutter#153582) 2024-08-16 [email protected] Update README.md (flutter/flutter#153470) 2024-08-16 [email protected] adds team-accessibility to triage workflow (flutter/flutter#153575) 2024-08-16 [email protected] add `HttpException` to the list of handled exceptions within `ResidentWebRunner::run` (flutter/flutter#153527) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…isions) (flutter#153618)" (flutter#153627) Reverts: flutter#153618 Initiated by: zanderso Reason for reverting: The tree is red. Original PR Author: engine-flutter-autoroll Reviewed By: {fluttergithubbot} This change reverts the following previous change: flutter/engine@c94651c...c9fb479 2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596) 2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595) 2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586) 2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592) 2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…a (5 revisions) (#153618)" (flutter/flutter#153627)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #153618
Initiated by: zanderso
Reason for reverting: The tree is red.
Original PR Author: engine-flutter-autoroll
Reviewed By: {fluttergithubbot}
This change reverts the following previous change:
flutter/engine@c94651c...c9fb479
2024-08-17 [email protected] Roll Fuchsia Linux SDK from Z5hq3ZkPNCpZWRQnl... to a3zdjZKduabZSBN0B... (flutter/engine#54596)
2024-08-17 [email protected] Roll Skia from 219bd1032761 to 570b18e1afda (1 revision) (flutter/engine#54595)
2024-08-17 [email protected] macOS: Extract framework creation to sky_utils (flutter/engine#54586)
2024-08-16 [email protected] Roll Skia from fc8769175d35 to 219bd1032761 (4 revisions) (flutter/engine#54592)
2024-08-16 [email protected] [docs] Add missing steps to Testing Presubmit Engine PRs (flutter/engine#54593)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from Z5hq3ZkPNCpZ to a3zdjZKduabZ
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md