Skip to content

Conversation

@andrewkolos
Copy link
Contributor

Context: #153472.

When the Flutter VM service is disposed while there are still outstanding requests, each request is completed with an RPCError that has no stack trace. This was fixed in package:vm_service v14.2.5 (these errors will now have stack traces). This PR bumps the framework repo's dependency on this package from 14.2.4 to 14.2.5. This may be handy in case we miss handling these errors from specific call sites in whatever fix(es) we put out for #153472.

Pre-launch Checklist

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Aug 16, 2024
@andrewkolos andrewkolos marked this pull request as ready for review August 16, 2024 21:39
@andrewkolos andrewkolos changed the title [CP] Bump dependency on package:vm_service from 14.2.4 to 14.2.5 [CP-stable] Bump dependency on package:vm_service from 14.2.4 to 14.2.5 Aug 16, 2024
@christopherfujino
Copy link
Contributor

are there any other changes in this bump other than the fix?

@andrewkolos
Copy link
Contributor Author

are there any other changes in this bump other than the fix?

Assuming the changelog is accurate, no. This version was created specifically to help address #153472.

Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christopherfujino christopherfujino added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 19, 2024
@auto-submit auto-submit bot merged commit a1f08ba into flutter:flutter-3.24-candidate.0 Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants