[CP-stable]add HttpException to the list of handled exceptions within ResidentWebRunner::run
#153579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tWebRunner::run` (flutter#153527) Resolves flutter#153298, a major crasher of the flutter tool. I plan on cherry-picking this change. In `ResidentWebRunner::run`, many connection-related exceptions are caught, logged, and have `ToolExit`s thrown in their place ([code](https://github.com/flutter/flutter/blob/d23be7a07de3bd7f02db367fce52eff79021df24/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart#L370-L385), [PR that introduced this](flutter#50895)). However, `HttpException` is not included in this list. See flutter#153298 (comment) for details if interested.
Author
|
@andrewkolos please fill out the PR description above, afterwards the release team will review this request. |
github-actions
bot
added
the
tool
6 tasks
christopherfujino
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
…ons within `ResidentWebRunner::run` (flutter/flutter#153579)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
…ons within `ResidentWebRunner::run` (flutter/flutter#153579)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is created by automatic cherry pick workflow
Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
Issue Link:
What is the link to the issue this cherry-pick is addressing?
#153298
Changelog Description:
Explain this cherry pick in one line that is accessible to most Flutter developers. See best practices for examples
[CLI tool] When unable to connect to Chrome/Chromium when running a flutter web app, gracefully exit with an error message instead of crashing.
Impact Description:
What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
Impacts users locally running Flutter web apps.
Users are likely getting noisy crashes when
flutter runorflutter debug-adapterare unable to connect to the flutter web app (perhaps due to a firewall or the user closing the browser before the connection can be made).Workaround:
Is there a workaround for this issue?
N/A. No repro is known.
Risk:
What is the risk level of this cherry-pick?
Test Coverage:
Are you confident that your fix is well-tested by automated tests?
Validation Steps:
What are the steps to validate that this fix works?
N/A. No repro is known.