add HttpException to the list of handled exceptions within ResidentWebRunner::run
#153527
+65
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
tool
bkonyi
approved these changes
Aug 16, 2024
andrewkolos
added
the
autosubmit
andrewkolos
added
the
cp: stable
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Aug 16, 2024
…tWebRunner::run` (flutter#153527) Resolves flutter#153298, a major crasher of the flutter tool. I plan on cherry-picking this change. In `ResidentWebRunner::run`, many connection-related exceptions are caught, logged, and have `ToolExit`s thrown in their place ([code](https://github.com/flutter/flutter/blob/d23be7a07de3bd7f02db367fce52eff79021df24/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart#L370-L385), [PR that introduced this](flutter#50895)). However, `HttpException` is not included in this list. See flutter#153298 (comment) for details if interested.
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…tWebRunner::run` (flutter#153527) Resolves flutter#153298, a major crasher of the flutter tool. I plan on cherry-picking this change. In `ResidentWebRunner::run`, many connection-related exceptions are caught, logged, and have `ToolExit`s thrown in their place ([code](https://github.com/flutter/flutter/blob/d23be7a07de3bd7f02db367fce52eff79021df24/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart#L370-L385), [PR that introduced this](flutter#50895)). However, `HttpException` is not included in this list. See flutter#153298 (comment) for details if interested.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 17, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 18, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 19, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 19, 2024
flutter/flutter@a0c0453...6a28048 2024-08-19 [email protected] Update goldctl git revision (flutter/flutter#153710) 2024-08-19 [email protected] Do not cancel the VmService's subscription to the isolate event stream in FlutterVmService.findExtensionIsolate (flutter/flutter#153607) 2024-08-19 [email protected] Roll Packages from 2c37fb0 to 7c1a05c (3 revisions) (flutter/flutter#153698) 2024-08-19 [email protected] Roll Flutter Engine from 52621de86f54 to e29b5529080d (1 revision) (flutter/flutter#153699) 2024-08-19 [email protected] Roll Flutter Engine from 356d51d46736 to 52621de86f54 (1 revision) (flutter/flutter#153693) 2024-08-19 [email protected] Roll Flutter Engine from ef8252cbbd6a to 356d51d46736 (1 revision) (flutter/flutter#153685) 2024-08-19 [email protected] Roll Flutter Engine from cf12bb6465e8 to ef8252cbbd6a (1 revision) (flutter/flutter#153681) 2024-08-19 [email protected] Roll Flutter Engine from c28282d39f4a to cf12bb6465e8 (1 revision) (flutter/flutter#153674) 2024-08-19 [email protected] Roll Flutter Engine from d0d7de5c333d to c28282d39f4a (1 revision) (flutter/flutter#153671) 2024-08-18 [email protected] Manual roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) (flutter/flutter#153659) 2024-08-18 [email protected] [gen_l10n] `isCustomDateFormat` accepts an actual boolean (flutter/flutter#153439) 2024-08-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" (flutter/flutter#153627) 2024-08-17 [email protected] Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (flutter/flutter#153618) 2024-08-17 [email protected] Roll pub packages (flutter/flutter#153581) 2024-08-17 [email protected] Roll Flutter Engine from cc732b4c698e to c94651c33b0e (1 revision) (flutter/flutter#153609) 2024-08-16 [email protected] Roll Flutter Engine from acb71d8307fa to cc732b4c698e (1 revision) (flutter/flutter#153605) 2024-08-16 [email protected] fix some unintended HTML tags in docs (flutter/flutter#153507) 2024-08-16 [email protected] Roll Flutter Engine from b66893e1fb7e to acb71d8307fa (1 revision) (flutter/flutter#153600) 2024-08-16 [email protected] Roll Flutter Engine from d5bf3afc601f to b66893e1fb7e (2 revisions) (flutter/flutter#153582) 2024-08-16 [email protected] Update README.md (flutter/flutter#153470) 2024-08-16 [email protected] adds team-accessibility to triage workflow (flutter/flutter#153575) 2024-08-16 [email protected] add `HttpException` to the list of handled exceptions within `ResidentWebRunner::run` (flutter/flutter#153527) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…tWebRunner::run` (flutter#153527) Resolves flutter#153298, a major crasher of the flutter tool. I plan on cherry-picking this change. In `ResidentWebRunner::run`, many connection-related exceptions are caught, logged, and have `ToolExit`s thrown in their place ([code](https://github.com/flutter/flutter/blob/d23be7a07de3bd7f02db367fce52eff79021df24/packages/flutter_tools/lib/src/isolated/resident_web_runner.dart#L370-L385), [PR that introduced this](flutter#50895)). However, `HttpException` is not included in this list. See flutter#153298 (comment) for details if interested.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…`ResidentWebRunner::run` (flutter/flutter#153527)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #153298, a major crasher of the flutter tool. I plan on cherry-picking this change.
In
ResidentWebRunner::run, many connection-related exceptions are caught, logged, and haveToolExits thrown in their place (code, PR that introduced this). However,HttpExceptionis not included in this list. See #153298 (comment) for details if interested.Pre-launch Checklist
///).