Skip to content

Conversation

@goderbauer
Copy link
Member

I used the unintended_html_in_doc_comment to find these, but sadly the lint is not ready to be enabled yet due to dart-lang/sdk#59516.

@goderbauer goderbauer requested a review from Piinks August 15, 2024 16:54
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: scrolling Viewports, list views, slivers, etc. labels Aug 15, 2024
@github-actions github-actions bot removed the a: text input Entering text in a text field or keyboard related problems label Aug 15, 2024
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 16, 2024
@auto-submit auto-submit bot merged commit d9dbefc into flutter:master Aug 16, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 17, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 19, 2024
flutter/flutter@a0c0453...6a28048

2024-08-19 [email protected] Update goldctl git revision (flutter/flutter#153710)
2024-08-19 [email protected] Do not cancel the VmService's subscription to the isolate event stream in FlutterVmService.findExtensionIsolate (flutter/flutter#153607)
2024-08-19 [email protected] Roll Packages from 2c37fb0 to 7c1a05c (3 revisions) (flutter/flutter#153698)
2024-08-19 [email protected] Roll Flutter Engine from 52621de86f54 to e29b5529080d (1 revision) (flutter/flutter#153699)
2024-08-19 [email protected] Roll Flutter Engine from 356d51d46736 to 52621de86f54 (1 revision) (flutter/flutter#153693)
2024-08-19 [email protected] Roll Flutter Engine from ef8252cbbd6a to 356d51d46736 (1 revision) (flutter/flutter#153685)
2024-08-19 [email protected] Roll Flutter Engine from cf12bb6465e8 to ef8252cbbd6a (1 revision) (flutter/flutter#153681)
2024-08-19 [email protected] Roll Flutter Engine from c28282d39f4a to cf12bb6465e8 (1 revision) (flutter/flutter#153674)
2024-08-19 [email protected] Roll Flutter Engine from d0d7de5c333d to c28282d39f4a (1 revision) (flutter/flutter#153671)
2024-08-18 [email protected] Manual roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) (flutter/flutter#153659)
2024-08-18 [email protected] [gen_l10n] `isCustomDateFormat` accepts an actual boolean (flutter/flutter#153439)
2024-08-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" (flutter/flutter#153627)
2024-08-17 [email protected] Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (flutter/flutter#153618)
2024-08-17 [email protected] Roll pub packages (flutter/flutter#153581)
2024-08-17 [email protected] Roll Flutter Engine from cc732b4c698e to c94651c33b0e (1 revision) (flutter/flutter#153609)
2024-08-16 [email protected] Roll Flutter Engine from acb71d8307fa to cc732b4c698e (1 revision) (flutter/flutter#153605)
2024-08-16 [email protected] fix some unintended HTML tags in docs (flutter/flutter#153507)
2024-08-16 [email protected] Roll Flutter Engine from b66893e1fb7e to acb71d8307fa (1 revision) (flutter/flutter#153600)
2024-08-16 [email protected] Roll Flutter Engine from d5bf3afc601f to b66893e1fb7e (2 revisions) (flutter/flutter#153582)
2024-08-16 [email protected] Update README.md (flutter/flutter#153470)
2024-08-16 [email protected] adds team-accessibility to triage workflow (flutter/flutter#153575)
2024-08-16 [email protected] add `HttpException` to the list of handled exceptions within `ResidentWebRunner::run` (flutter/flutter#153527)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
I used the `unintended_html_in_doc_comment` to find these, but sadly the lint is not ready to be enabled yet due to https://github.com/dart-lang/linter/issues/5065.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants