[Android] Update SystemUiMode and setSystemChromeEnabledSystemUIMode docs to note targeting Android 15+ change
#153466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
8 tasks
camsim99
changed the title
4 tasks
camsim99
changed the title
SystemUiMode and setSystemChromeEnabledSystemUIMode docs to note targeting Android 15+ change
gmackall
reviewed
Sep 23, 2024
| /// Available starting at SDK 16 or Android J. Earlier versions of Android | ||
| /// will not be affected by this setting. | ||
| /// will not be affected by this setting. However, if your app targets | ||
| /// Android 15 or later (Flutter does this by default), then you must |
Member
There was a problem hiding this comment.
I think it might be confusing to (in one doc) refer to the android version as the SDK number, version letter code, and "public" version. Maybe keep the same scheme as before, so "if your app targets SDK 35 (Android ...)", but maybe also a preference for changing that earlier pattern to be "SDK # (Public # )" instead of using letter codes.
Member
There was a problem hiding this comment.
Especially because this documentation refers to the api level as "SDK <number>", while the docs at https://docs.flutter.dev/release/breaking-changes/default-systemuimode-edge-to-edge do the same thing ("Android SDK 15+") to refer to a different class of version number.
Contributor
Author
There was a problem hiding this comment.
This is a great point about making things consistent. I changed all references to the "SDK # (Public # )" format; let me know how it looks to you.
As an aside, I'm going to update the engine PR that mirrors this one to have the same format.
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Sep 25, 2024
…droid 15+ change (#54560) Updates `setSystemChromeEnabledSystemUIMode` documentation to reflect that edge-to-edge mode is used by default if the Flutter app targets Android 15. Part of flutter/flutter#150367 and engine counterpart to flutter/flutter#153466. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
gmackall
approved these changes
Sep 25, 2024
Member
gmackall
left a comment
gmackall
left a comment
There was a problem hiding this comment.
lgtm, thanks for fixing the other uses of letter code
reidbaker
approved these changes
Sep 25, 2024
reidbaker
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
…de ` docs to note targeting Android 15+ change (flutter#153466) Updates `SystemUiMode` and `setSystemChromeEnabledSystemUIMode` documentation to reflect that edge-to-edge mode is used by default if the Flutter app targets Android 15. Part of flutter#150367 and framework counterpart to flutter/engine#54560.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 26, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
LouiseHsu
pushed a commit
to flutter/packages
that referenced
this pull request
Sep 26, 2024
flutter/flutter@538e742...fa402c8 2024-09-26 [email protected] Roll Flutter Engine from 6328a0597b68 to 9e6133e8d906 (1 revision) (flutter/flutter#155762) 2024-09-26 [email protected] Roll Packages from 7da2374 to f38b780 (2 revisions) (flutter/flutter#155760) 2024-09-26 49699333+dependabot[bot]@users.noreply.github.com Bump codecov/codecov-action from 4.4.1 to 4.5.0 (flutter/flutter#150229) 2024-09-26 [email protected] Roll Flutter Engine from 08f935236e45 to 6328a0597b68 (1 revision) (flutter/flutter#155750) 2024-09-26 [email protected] Roll Flutter Engine from 3a520a2a4399 to 08f935236e45 (1 revision) (flutter/flutter#155748) 2024-09-26 [email protected] Reland "[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) (#155430)" (flutter/flutter#155745) 2024-09-26 [email protected] Roll Flutter Engine from 896208ee5828 to 3a520a2a4399 (1 revision) (flutter/flutter#155744) 2024-09-26 [email protected] Roll Flutter Engine from fc6c85292b57 to 896208ee5828 (2 revisions) (flutter/flutter#155743) 2024-09-26 [email protected] Roll Flutter Engine from 3719454a879f to fc6c85292b57 (1 revision) (flutter/flutter#155738) 2024-09-26 [email protected] added ability to configure shadow in banner (flutter/flutter#155296) 2024-09-26 [email protected] Roll Flutter Engine from d4850c1ae648 to 3719454a879f (1 revision) (flutter/flutter#155736) 2024-09-26 [email protected] Roll Flutter Engine from d6d5fdba6ae1 to d4850c1ae648 (18 revisions) (flutter/flutter#155733) 2024-09-25 [email protected] Move the Linux runner into a subdirectory (flutter/flutter#153812) 2024-09-25 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.7 to 4.2.0 (flutter/flutter#155711) 2024-09-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) (#155430)" (flutter/flutter#155713) 2024-09-25 [email protected] [flutter_tools] Cleanup of native asset related code (removes around 50% of the native asset related code) (flutter/flutter#155430) 2024-09-25 [email protected] reduce warnings inside flutter.groovy file #2 (flutter/flutter#155628) 2024-09-25 [email protected] [Android] Update `SystemUiMode` and `setSystemChromeEnabledSystemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466) 2024-09-25 [email protected] mark linux packages autoroller bringup: true (flutter/flutter#155705) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…stemUIMode ` docs to note targeting Android 15+ change (flutter/flutter#153466)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
SystemUiModeandsetSystemChromeEnabledSystemUIModedocumentation to reflect that edge-to-edge mode is used by default if the Flutter app targets Android 15.Part of #150367 and framework counterpart to flutter/engine#54560.
Pre-launch Checklist
///).