Skip to content

Conversation

@kzrnm
Copy link
Contributor

@kzrnm kzrnm commented Aug 14, 2024

Fixes #153420

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 14, 2024
@kzrnm kzrnm force-pushed the isCustomDateFormatBoolean branch from 359c166 to 21af516 Compare August 14, 2024 14:21
@kzrnm kzrnm changed the title isCustomDateFormat accepts an actual boolean [gen_l10n] isCustomDateFormat accepts an actual boolean Aug 14, 2024
@andrewkolos andrewkolos self-requested a review August 15, 2024 18:49
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zanderso
Copy link
Member

Landing manually to kick the tree.

@zanderso zanderso merged commit ea477d5 into flutter:master Aug 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 19, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 19, 2024
flutter/flutter@a0c0453...6a28048

2024-08-19 [email protected] Update goldctl git revision (flutter/flutter#153710)
2024-08-19 [email protected] Do not cancel the VmService's subscription to the isolate event stream in FlutterVmService.findExtensionIsolate (flutter/flutter#153607)
2024-08-19 [email protected] Roll Packages from 2c37fb0 to 7c1a05c (3 revisions) (flutter/flutter#153698)
2024-08-19 [email protected] Roll Flutter Engine from 52621de86f54 to e29b5529080d (1 revision) (flutter/flutter#153699)
2024-08-19 [email protected] Roll Flutter Engine from 356d51d46736 to 52621de86f54 (1 revision) (flutter/flutter#153693)
2024-08-19 [email protected] Roll Flutter Engine from ef8252cbbd6a to 356d51d46736 (1 revision) (flutter/flutter#153685)
2024-08-19 [email protected] Roll Flutter Engine from cf12bb6465e8 to ef8252cbbd6a (1 revision) (flutter/flutter#153681)
2024-08-19 [email protected] Roll Flutter Engine from c28282d39f4a to cf12bb6465e8 (1 revision) (flutter/flutter#153674)
2024-08-19 [email protected] Roll Flutter Engine from d0d7de5c333d to c28282d39f4a (1 revision) (flutter/flutter#153671)
2024-08-18 [email protected] Manual roll Flutter Engine from c94651c33b0e to d0d7de5c333d (9 revisions) (flutter/flutter#153659)
2024-08-18 [email protected] [gen_l10n] `isCustomDateFormat` accepts an actual boolean (flutter/flutter#153439)
2024-08-17 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (#153618)" (flutter/flutter#153627)
2024-08-17 [email protected] Roll Flutter Engine from c94651c33b0e to c9fb47927fea (5 revisions) (flutter/flutter#153618)
2024-08-17 [email protected] Roll pub packages (flutter/flutter#153581)
2024-08-17 [email protected] Roll Flutter Engine from cc732b4c698e to c94651c33b0e (1 revision) (flutter/flutter#153609)
2024-08-16 [email protected] Roll Flutter Engine from acb71d8307fa to cc732b4c698e (1 revision) (flutter/flutter#153605)
2024-08-16 [email protected] fix some unintended HTML tags in docs (flutter/flutter#153507)
2024-08-16 [email protected] Roll Flutter Engine from b66893e1fb7e to acb71d8307fa (1 revision) (flutter/flutter#153600)
2024-08-16 [email protected] Roll Flutter Engine from d5bf3afc601f to b66893e1fb7e (2 revisions) (flutter/flutter#153582)
2024-08-16 [email protected] Update README.md (flutter/flutter#153470)
2024-08-16 [email protected] adds team-accessibility to triage workflow (flutter/flutter#153575)
2024-08-16 [email protected] add `HttpException` to the list of handled exceptions within `ResidentWebRunner::run` (flutter/flutter#153527)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
@kzrnm kzrnm deleted the isCustomDateFormatBoolean branch August 20, 2024 14:40
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
…3439)

Fixes flutter#153420

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [ ] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[gen_l10n] Why doesn't isCustomDateFormat accept an actual boolean?

3 participants