Roll Flutter Engine from 019f9e3f0744 to 69f61b02a376 (9 revisions) #153406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Aug 14, 2024
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/153406, due to - The status or check suite Mac_arm64 run_debug_test_macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
8 tasks
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Aug 14, 2024
Reverts: #54546 Initiated by: zanderso Reason for reverting: Failing roll flutter/flutter#153406 Original PR Author: cbracken Reviewed By: {zanderso} This change reverts the following previous change: This is a refactoring with no semantic changes. This refactors the macOS framework creation code to be more readable, and extracts it to sky_utils.py. While I was pulling this out, also generalised the code to not hardcode FlutterMacOS.framework in case we one day manage to generate the iOS and macOS frameworks with the same name. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Aug 14, 2024
Reverts: #54543 Initiated by: zanderso Reason for reverting: Failing roll flutter/flutter#153406 Original PR Author: cbracken Reviewed By: {zanderso} This change reverts the following previous change: Over time, this script and others in sky/tools have accumulated a lot of additional and sometimes duplicate code. This is a first pass cleanup of create_macos_framework.py to extract common utility code to utils.py and refactor for better readability. The iOS analogue of this patch was #54500. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
Contributor
Author
|
AutoRoller is stopped; closing the active roll. |
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-ced07705-b744-4d29-91b8-f171c1a8afb5-1723599027
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@019f9e3...69f61b0
2024-08-14 [email protected] macOS: refactor create_macos_framework.py (flutter/engine#54546)
2024-08-13 [email protected] [DisplayList] Allow random access to ops through indexing (flutter/engine#54484)
2024-08-13 [email protected] Update dartdoc for gpu.dart (flutter/engine#54529)
2024-08-13 [email protected] macOS: Clean up create_ios_framework.py (flutter/engine#54543)
2024-08-13 [email protected] Roll Dart SDK from 44635f897535 to 733062367c2e (1 revision) (flutter/engine#54541)
2024-08-13 [email protected] Roll Fuchsia Linux SDK from 2LTVy4Gv76DcMpz4V... to MeV5i7xXXFPHF5sBK... (flutter/engine#54542)
2024-08-13 [email protected] [canvaskit] Add animation detection for GIFs (flutter/engine#54483)
2024-08-13 [email protected] Preserve background frame damage (flutter/engine#54540)
2024-08-13 [email protected] [fuchsia] Use BundledTestRunner from test-scripts (flutter/engine#54404)
Also rolling transitive DEPS:
fuchsia/sdk/core/linux-amd64 from 2LTVy4Gv76Dc to MeV5i7xXXFPH
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md