[CP Stable] Emit source maps for wasm in flutter build web --wasm (#151643)
#153310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make * `flutter run` have source maps enabled by default * `flutter build` have source maps disabled by default which mirrors what happens already today with the js compilers. For local development this works quite well - even better than with dart2js (see dart2js issues in [0]). We do have some follow-up items for source maps in dart2wasm compiler, see [1] [0] [flutter/issues/151641](flutter#151641) [1] [dart-lang/sdk/issues/56232](dart-lang/sdk#56232)
github-actions
bot
added
the
tool
mkustermann
changed the title
flutter build web --wasm (#151643)flutter build web --wasm (#151643)
7 tasks
itsjustkevin
approved these changes
Aug 13, 2024
itsjustkevin
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick request: #153308
Original CL:
This will make
flutter runhave source maps enabled by defaultflutter buildhave source maps disabled by defaultwhich mirrors what happens already today with the js compilers.
For local development this works quite well - even better than with dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler, see [1]
[0] flutter/flutter/issues/151641
[1] dart-lang/sdk/issues/56232