Normalize ThemeData.cardTheme
#153254
Merged
Normalize ThemeData.cardTheme
#153254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Contributor
Author
|
Will wait until rest of the component themes(DialogTheme, InputDecorationTheme and TabBarTheme) have fixes ready to merge because I think it might be better to include them together in one breaking change migration. |
bleroux
reviewed
Aug 15, 2024
Contributor
bleroux
left a comment
bleroux
left a comment
There was a problem hiding this comment.
While reading for learning purpose, I spotted some typos.
Contributor
Author
Thanks a lot for the suggestions:) Just updated! |
9 tasks
QuncCccccc
force-pushed
the
update_card_theme_type
branch
from
7cfe70e to
634ba84
Compare
QuncCccccc
commented
Oct 1, 2024
| ButtonThemeData? buttonTheme, | ||
| CardTheme? cardTheme, | ||
| // TODO(QuncCccccc): Change the parameter type to CardThemeData | ||
| Object? cardTheme, |
Contributor
Author
There was a problem hiding this comment.
Similar to #155129, to help smooth rolling into G3, I updated the parameter type in ThemeData() and ThemeData.copyWith() to object? and added a TODO to change the parameter type back to CardThemeData.
bleroux
reviewed
Oct 2, 2024
guidezpl
approved these changes
Oct 2, 2024
Member
guidezpl
left a comment
guidezpl
left a comment
There was a problem hiding this comment.
_ ___ _____ __ __
| | / __|_ _| \/ |
| |_| (_ | | | | |\/| |
|____\___| |_| |_| |_|
5dcd337 to
b5ea6e4
Compare
QuncCccccc
force-pushed
the
update_card_theme_type
branch
from
b5ea6e4 to
3cf69f6
Compare
QuncCccccc
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 6, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Oct 8, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Oct 8, 2024
Manual roll requested by [email protected] flutter/flutter@ec2e12b...0917e9d 2024-10-05 [email protected] Roll Flutter Engine from 2068577e510b to 01de9dcf6bbf (1 revision) (flutter/flutter#156274) 2024-10-05 [email protected] Roll Flutter Engine from 6d6bc39fe8b1 to 2068577e510b (1 revision) (flutter/flutter#156267) 2024-10-05 [email protected] Roll Flutter Engine from 92b5b318190b to 6d6bc39fe8b1 (4 revisions) (flutter/flutter#156266) 2024-10-05 [email protected] Roll Flutter Engine from fd6082ab6693 to 92b5b318190b (1 revision) (flutter/flutter#156261) 2024-10-05 [email protected] Roll Flutter Engine from bc5f9fc80b06 to fd6082ab6693 (4 revisions) (flutter/flutter#156258) 2024-10-04 [email protected] Roll Flutter Engine from eece6c3ec63a to bc5f9fc80b06 (2 revisions) (flutter/flutter#156252) 2024-10-04 [email protected] Roll pub packages (flutter/flutter#156254) 2024-10-04 [email protected] Roll Flutter Engine from 9fa363bdde20 to eece6c3ec63a (1 revision) (flutter/flutter#156250) 2024-10-04 [email protected] Roll Flutter Engine from d38f5e560a98 to 9fa363bdde20 (1 revision) (flutter/flutter#156249) 2024-10-04 [email protected] remove bringup from Windows tool_integration_tests_* (flutter/flutter#156179) 2024-10-04 [email protected] Roll Flutter Engine from 205484009711 to d38f5e560a98 (4 revisions) (flutter/flutter#156239) 2024-10-04 [email protected] Normalize `ThemeData.cardTheme` (flutter/flutter#153254) 2024-10-04 [email protected] Roll Packages from 429650f to 05bf1d4 (5 revisions) (flutter/flutter#156225) 2024-10-04 [email protected] Roll Flutter Engine from e0109f0fd5b2 to 205484009711 (1 revision) (flutter/flutter#156216) 2024-10-04 [email protected] Roll pub packages (flutter/flutter#156215) 2024-10-04 [email protected] Roll Flutter Engine from c2a9fb051bd0 to e0109f0fd5b2 (1 revision) (flutter/flutter#156213) 2024-10-04 [email protected] Roll Flutter Engine from 66d397dff87a to c2a9fb051bd0 (5 revisions) (flutter/flutter#156206) 2024-10-04 [email protected] Roll Flutter Engine from 20369c5d2b93 to 66d397dff87a (5 revisions) (flutter/flutter#156188) 2024-10-03 [email protected] Roll Flutter Engine from de1762dbc5cc to 20369c5d2b93 (7 revisions) (flutter/flutter#156174) 2024-10-03 [email protected] Refactor devfs_web_ddc_modules_test.dart (flutter/flutter#155609) 2024-10-03 [email protected] Allow arrow keys to navigate `MenuAnchor` independently of global shortcut definition (flutter/flutter#155728) 2024-10-03 [email protected] Inherited Theme: zero rebuilds (flutter/flutter#155699) 2024-10-03 [email protected] Roll Flutter Engine from 247bc68c578e to de1762dbc5cc (4 revisions) (flutter/flutter#156160) 2024-10-03 [email protected] Roll pub packages (flutter/flutter#156159) 2024-10-03 [email protected] pattern-matching refactor (flutter/flutter#154753) 2024-10-03 [email protected] Add autocorrect and enableSuggestions to SearchDelegate (flutter/flutter#154932) 2024-10-03 [email protected] Roll Packages from 7c97c88 to 429650f (6 revisions) (flutter/flutter#156155) 2024-10-03 [email protected] Move some tools test ownership to Ben (flutter/flutter#156123) 2024-10-03 [email protected] further shard the Windows tool_integration_tests* targets (flutter/flutter#156121) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
8 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #151914, this PR is to normalize
ThemeData.cardTheme; change theCardTheme cardThemeproperty toCardThemeData cardThemeinThemeData. InThemeData()andThemeData.copyWith(), thecardThemeparameter type is changed toObject?to accept bothCardThemeandCardThemeDataso that we won't cause immediate breaking change and make sure rolling is smooth. Once all component themes are normalized, theseObject?types should be changed toxxxThemeData.There's no way to create a dart fix because we can't add a "@deprecated" label for
CardThemebecauseCardThemeis a new InheritedWidget subclass now.Addresses the "theme normalization" sub project within #91772
Pre-launch Checklist
///).