Add TextHeightBehavior argument for DefaultTextStyle.merge
#153178
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
github-actions
bot
added
a: text input
nate-thegrate
left a comment
nate-thegrate
left a comment
There was a problem hiding this comment.
LGTM w/ a documentation nit.
Thanks for adding the parameter and the test!
|
Thanks for the review @nate-thegrate! Could we get the PR merged if there aren't any other issues? 😊 |
|
We'll be able to merge once the PR has 2 approvals (more info here). I'll try reaching out to some folks on Discord, since that's usually the fastest way to get it done. If that doesn't work, I'll look through the git blame and make a request based on that. |
victorsanni
added
the
autosubmit
Manual roll requested by [email protected] flutter/flutter@99f00a1...bced008 2024-08-16 [email protected] Roll Flutter Engine from 68938abd03b9 to a8fefc81188e (1 revision) (flutter/flutter#153537) 2024-08-16 [email protected] [interactive_media_ads] Adds missing IMA plugin to issue template (flutter/flutter#153510) 2024-08-16 [email protected] Roll Flutter Engine from 65fd6ca194c1 to 68938abd03b9 (1 revision) (flutter/flutter#153533) 2024-08-16 [email protected] Roll Flutter Engine from 8f3f80ec1225 to 65fd6ca194c1 (1 revision) (flutter/flutter#153529) 2024-08-15 [email protected] Manual roll Flutter Engine from 971ddd9fe1bf to 8f3f80ec1225 (5 revisions) (flutter/flutter#153525) 2024-08-15 [email protected] Add `TextHeightBehavior` argument for `DefaultTextStyle.merge` (flutter/flutter#153178) 2024-08-15 [email protected] Update TextTheme with the M3 Typography tokens (flutter/flutter#153131) 2024-08-15 [email protected] Design-Documents.md incorrect link (flutter/flutter#153509) 2024-08-15 [email protected] Roll `avd_cipd_verison` to latest to use the `crashreport` tool. (flutter/flutter#153520) 2024-08-15 [email protected] Improve asserts on Element.mount (flutter/flutter#153477) 2024-08-15 [email protected] Fix anti-aliasing when painting borders with solid colors. (flutter/flutter#153365) 2024-08-15 [email protected] Roll pub packages (flutter/flutter#153479) 2024-08-15 [email protected] Roll Packages from e4f2247 to 86d15a6 (7 revisions) (flutter/flutter#153499) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…er#153178) Addresses an issue where `DefaultTextStyle.merge` is missing the `textHeightBehavior` argument. The argument is present in the `DefaultTextStyle` constructor. Resolves flutter#120176
…er#153178) Addresses an issue where `DefaultTextStyle.merge` is missing the `textHeightBehavior` argument. The argument is present in the `DefaultTextStyle` constructor. Resolves flutter#120176
3 participants
Addresses an issue where
DefaultTextStyle.mergeis missing thetextHeightBehaviorargument. The argument is present in theDefaultTextStyleconstructor.Resolves #120176
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.