Skip to content

Conversation

@dunatron
Copy link

@dunatron dunatron commented Aug 9, 2024

If a child item has onTap events they wouldn't trigger even if the CarouselView has on onTap: null

If I do not supply onTap for the CarouselView widget it should at least not block onTap events for my child widgets...

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

If a child item has onTap events they wouldn't trigger even if the CarouselView has on onTap: null

If I do not supply onTap for the CarouselView widget it should at least not block onTap events for my child widgets...
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group.

@google-cla
Copy link

google-cla bot commented Aug 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Aug 9, 2024
Copy link
Contributor

@Piinks Piinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dunatron welcome! Thanks for contributing.
This will need a test to verify it works as expected, and so that we don't regress it in the future.
Also, is there an open issue this is resolving?

@Piinks Piinks requested a review from QuncCccccc August 14, 2024 18:04
@jannisnikoy
Copy link

Running into the issues this PR would address myself too. Disappointing that this isn't the default behavior for CarouselView

@Piinks Piinks mentioned this pull request Sep 11, 2024
9 tasks
@Piinks
Copy link
Contributor

Piinks commented Sep 11, 2024

We have not heard back for a while, and it looks like #154745 will resolve this issue, so I am going to close it for now. If that PR lands and you would like to revisit this, please open a new PR. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants