Reverts "[tool] Guard process writes to frontend server in ResidentCompiler (#152358)"
#153028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auto-submit
bot
added
the
revert of
github-actions
bot
added
the
tool
fluttergithubbot
approved these changes
Aug 7, 2024
auto-submit
bot
deleted the
revert_d848262fc4d3f4885f02d388b3b8ac4cd95f7972
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 7, 2024
…esidentCompiler` (#152358)" (flutter/flutter#153028)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 7, 2024
…esidentCompiler` (#152358)" (flutter/flutter#153028)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 7, 2024
flutter/flutter@0a7f8af...d595e98 2024-08-07 [email protected] Fix PageController throws when changing page before viewPortDimensions are set (flutter/flutter#153017) 2024-08-07 [email protected] Update design languages triage link to exclude drafts (flutter/flutter#153027) 2024-08-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[tool] Guard process writes to frontend server in `ResidentCompiler` (#152358)" (flutter/flutter#153028) 2024-08-07 [email protected] Roll Flutter Engine from 206e86ee8a40 to 5a0fd5fbecc6 (6 revisions) (flutter/flutter#152985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…ompiler` (flutter#152358)" (flutter#153028) Reverts: flutter#152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to flutter#153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…ompiler` (flutter#152358)" (flutter#153028) Reverts: flutter#152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to flutter#153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ompiler` (flutter#152358)" (flutter#153028) Reverts: flutter#152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to flutter#153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
…esidentCompiler` (#152358)" (flutter/flutter#153028)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
…esidentCompiler` (#152358)" (flutter/flutter#153028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #152358
Initiated by: zanderso
Reason for reverting: Speculative revert to determine whether this PR is related to #153026
Original PR Author: andrewkolos
Reviewed By: {christopherfujino}
This change reverts the following previous change:
Contributes to fixing #137184.
Cleaned up version of earlier PR, #152187.
This PR guards all the writes to
Process::stdinby wrapping them withProcessUtils.writelnToStdinUnsafe. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.Pre-launch Checklist
///).