Fix PageController throws when changing page before viewPortDimensions are set #153017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
framework
bleroux
force-pushed
the
fix_page_controller_throws_when_viewPortDimensions_are_not_set
branch
from
2d300ee to
49a9c32
Compare
Piinks
approved these changes
Aug 7, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
LGTM! Thank you so much for taking a look and sending a PR. This is the right solution, so elegant! ✨ 🎊 ✨
chunhtai
added
the
autosubmit
Piinks
added
c: crash
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 7, 2024
9 tasks
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 7, 2024
flutter/flutter@0a7f8af...d595e98 2024-08-07 [email protected] Fix PageController throws when changing page before viewPortDimensions are set (flutter/flutter#153017) 2024-08-07 [email protected] Update design languages triage link to exclude drafts (flutter/flutter#153027) 2024-08-07 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[tool] Guard process writes to frontend server in `ResidentCompiler` (#152358)" (flutter/flutter#153028) 2024-08-07 [email protected] Roll Flutter Engine from 206e86ee8a40 to 5a0fd5fbecc6 (6 revisions) (flutter/flutter#152985) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…s are set (flutter#153017) ## Description This PR fixes `PageController` throwing when using `jumpToPage` or `animateToPage` to switch page before the viewport dimensions were retrieved. Solution based on flutter#152947 (comment). ## Related Issue Fixes flutter#86222. Fixes flutter#152079 ## Tests Adds 2 tests.
bleroux
deleted the
fix_page_controller_throws_when_viewPortDimensions_are_not_set
branch
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…s are set (flutter#153017) ## Description This PR fixes `PageController` throwing when using `jumpToPage` or `animateToPage` to switch page before the viewport dimensions were retrieved. Solution based on flutter#152947 (comment). ## Related Issue Fixes flutter#86222. Fixes flutter#152079 ## Tests Adds 2 tests.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…s are set (flutter#153017) ## Description This PR fixes `PageController` throwing when using `jumpToPage` or `animateToPage` to switch page before the viewport dimensions were retrieved. Solution based on flutter#152947 (comment). ## Related Issue Fixes flutter#86222. Fixes flutter#152079 ## Tests Adds 2 tests.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes
PageControllerthrowing when usingjumpToPageoranimateToPageto switch page before the viewport dimensions were retrieved.Solution based on #152947 (comment).
Related Issue
Fixes #86222.
Fixes #152837
Tests
Adds 2 tests.