Skip to content

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 7, 2024

Fix the xcodebuild flags mixing up the iOS and watchOS simulators.

Confirmed this passed in CI on Xcode 16 beta 5: #152408

Fixes #152983
See also #152347

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@jmagman jmagman self-assigned this Aug 7, 2024
@github-actions github-actions bot added platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 7, 2024
@jmagman jmagman marked this pull request as ready for review August 7, 2024 18:04
@jmagman jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 8, 2024
@auto-submit auto-submit bot merged commit 6c3677c into flutter:master Aug 8, 2024
@jmagman jmagman deleted the watch-sdk branch August 8, 2024 19:55
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 9, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 9, 2024
Manual roll requested by [email protected]

flutter/flutter@b6cd31e...76107bd

2024-08-08 [email protected] Re-enable dds for flutter drive tests that use DevTools (flutter/flutter#153129)
2024-08-08 [email protected] Roll Flutter Engine from ef820aa74f7a to 05208896830a (5 revisions) (flutter/flutter#153132)
2024-08-08 [email protected] [devicelab] opt all impeller tests to GPU tracing, opt some Android tests into merged thread mode. (flutter/flutter#153121)
2024-08-08 [email protected] Clean up .gitignore files (flutter/flutter#153060)
2024-08-08 [email protected] Roll Flutter Engine from 387f6f3c5fdb to ef820aa74f7a (4 revisions) (flutter/flutter#153124)
2024-08-08 [email protected] Shift Linux_android_emu tests from staging to prod (flutter/flutter#153110)
2024-08-08 [email protected] Move Android tests with macOS host from staging to prod (flutter/flutter#153113)
2024-08-08 [email protected] Remove -sdk for watchOS simulator in tool (flutter/flutter#152992)
2024-08-08 [email protected] Roll Flutter Engine from 3978ddd8d7a7 to 387f6f3c5fdb (3 revisions) (flutter/flutter#153111)
2024-08-08 [email protected] Roll Packages from 5cc0a01 to bb797b9 (5 revisions) (flutter/flutter#153107)
2024-08-08 [email protected] Roll pub packages [manual] (flutter/flutter#153066)
2024-08-08 [email protected] [web] Fix reading of the --local-web-sdk flag and remove the copy of useLocalWebSdk in DebuggingOptions (flutter/flutter#152642)
2024-08-08 [email protected] The `PopupMenuButton` should not steal focus from the TextField when it appears. (flutter/flutter#150568)
2024-08-08 [email protected] Fix `flutter build ipa --export-method` not accepting `enterprise` flag (flutter/flutter#153047)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33 pushed a commit to DBowen33/flutter that referenced this pull request Aug 16, 2024
Fix the xcodebuild flags mixing up the iOS and watchOS simulators.

Confirmed this passed in CI on Xcode 16 beta 5: flutter#152408

Fixes flutter#152983
See also flutter#152347
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
Fix the xcodebuild flags mixing up the iOS and watchOS simulators.

Confirmed this passed in CI on Xcode 16 beta 5: flutter#152408

Fixes flutter#152983
See also flutter#152347
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simulator builds fails on Xcode 16 beta 4 "Xcode build is missing expected TARGET_BUILD_DIR build setting."

2 participants