`CupertinoSlidingSegmentedControl` update #152976

QuncCccccc · 2024-08-07T00:49:21Z

This PR is to improve CupertinoSlidingSegmentedControl fidelity and add a new property setEnabled so that segments can be disabled now.

Fidelity update includes:

small change on default thumb radius (Based on iOS 17 Figma file)
separator height (Based on the comparison with SegmentedControl example in Xcode)
segment min padding (Based on iOS 17 Figma file)
thumb scale alignment (Based on the comparison with SegmentedControl example in Xcode). If the thumb is on the first or last position in SegmentedControl, the alignment should be Alignment.leftCenter and Alignment.rightCenter respectively, assuming the text direction is left to right. For segments in middle, they should have center alignment as previously.
TextStyle update (Based on both the Figma file and the Xcode example)
Clipped thumb shadow if the shadow is outside of the segmented control (Based on the Xcode example)
Fixed the overall size shaking issue during segment switching on macOS and iOS

Alignment update demo

Screen.Recording.2024-08-08.at.1.33.19.PM.mov

Comparison before and after

Before:

After:

Shaking issue

Before:

Screen.Recording.2024-08-08.at.1.47.53.PM.mov

After:

Screen.Recording.2024-08-08.at.1.47.35.PM.mov

The disabledChildren feature can be used to disable segments. The default disabled color comes from the inspection in the Xcode example.

Disabled feature demos

Disabled segment cannot be highlighted:

Screen.Recording.2024-08-09.at.6.03.40.PM.mov

groupValue can still be highlighted programmatically if it is disabled.

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

flutter-dashboard · 2024-08-08T20:54:16Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152976 at sha 3465fb2

LongCatIsLooong · 2024-08-08T21:05:45Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart


  @override
  Widget build(BuildContext context) {
+    Alignment scaleAlignment;


final Alignment scaleAlignment;

There's a fourth state where both isLeft and isRight are true that seems unhandled?

Sorry not sure I understand this correctly, how to be both left and right segment? For the segment that isLeft, it is the leftmost segment in the segmented control, and for isRight, it is the rightmost segment (assuming text direction is ltr).

LongCatIsLooong · 2024-08-08T21:08:08Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

+      bool enabled = true;
+      if (widget.setEnabled != null && widget.setEnabled!.containsKey(entry.key)) {
+        enabled = widget.setEnabled![entry.key]!;
+      }


final bool enabled = widget.setEnabled?.[entry.key] ?? true.

Also you can use a set to store disabled segments.

LongCatIsLooong · 2024-08-08T21:10:34Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

-                .merge(TextStyle(fontWeight: widget.highlighted ? FontWeight.w500 : FontWeight.normal)),
+                .merge(TextStyle(
+                  fontWeight: widget.highlighted ? FontWeight.w600 : FontWeight.w500,
+                  fontSize: 13,


Use constants for hardcoded values and document the provenance?

LongCatIsLooong · 2024-08-08T21:13:26Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

 // The minimum opacity of an unselected segment, when the user presses on the
 // segment and it starts to fadeout.
-//
-// Inspected from iOS 13.2 simulator.


consider documenting the source of this const: #21302

LongCatIsLooong · 2024-08-08T21:14:55Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

 );

+// The height of the separator.
+const double _kSeparatorHeight = 18.0;


nit: If both the height and the width are const, turn them into a Size const?

There are several places that width and height are used separately, maybe just keep them as is?

I didn't realize those are only used directly by the widgets / render objects. They are used to construct other constants it looks like?

I'm a bit confused by _kSeparatorHeight. It looks like it's not used directly but used to compute _kSeparatorInset. So the real meaning of _kSeparatorHeight is "the height of the separator when the segmented control is at the min height"?

Ah you are right. I was thinking providing a const height value might be more straightforward to understand. But it seems only "inset" doesn't change, when segments height have some larger values, the separator height is also getting larger. Updated.

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

LongCatIsLooong · 2024-08-08T21:29:18Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

    final List<RenderBox> children = getChildrenAsList();

+    // Children contains both segment and separator and the order is segment ->
+    // separator -> segment. So to paint separators, indes should start from 1 and


typo: index?

LongCatIsLooong · 2024-08-08T21:31:42Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

      currentThumbRect = unscaledThumbRect;
+
+      double delta = 0;
+      if (isLeadingChild) {


what if it's both leading and trailing?

Ah the same explanation as above:) This should mean leftmost and rightmost ones

Oh I didn't realize assert(children.length >= 2). Nvm.

But in that case they're logically mutually exclusive. Maybe use an enum to model that instead of 2 bools.

Just pushed a commit, does this look okay? 51277b6

LongCatIsLooong · 2024-08-08T21:32:50Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

    }

    final int? highlightedChildIndex = highlightedIndex;
+    final bool isLeadingChild = highlightedChildIndex != null


uber nit: the null check is not needed?

It would be possible that groupValue is null, and we don't have highlighted child index, right?

if highlightedChildIndex == 0 then it can't be null.

That's right! Thanks for catching this! Updated.

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

QuncCccccc

Thanks so much for the review! I fixed all the comments except the setEnabled-related comments. Will push separate commits for these.

QuncCccccc · 2024-08-08T22:19:21Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

 );

+// The height of the separator.
+const double _kSeparatorHeight = 18.0;


There are several places that width and height are used separately, maybe just keep them as is?

QuncCccccc · 2024-08-08T22:24:18Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart


  @override
  Widget build(BuildContext context) {
+    Alignment scaleAlignment;


Sorry not sure I understand this correctly, how to be both left and right segment? For the segment that isLeft, it is the leftmost segment in the segmented control, and for isRight, it is the rightmost segment (assuming text direction is ltr).

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

QuncCccccc · 2024-08-08T22:47:03Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

-              child: widget.child,
-            ),
-          ),
+          widget.child,


I tired to keep it but seems only removing both Offstage and DefaultTextStyle can solve the shaking issue. Keeping DefaultTextStyle still make the overall size shakes a little during thumb switch.

QuncCccccc · 2024-08-08T22:50:32Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

    }

    final int? highlightedChildIndex = highlightedIndex;
+    final bool isLeadingChild = highlightedChildIndex != null


It would be possible that groupValue is null, and we don't have highlighted child index, right?

QuncCccccc · 2024-08-08T22:51:16Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

      currentThumbRect = unscaledThumbRect;
+
+      double delta = 0;
+      if (isLeadingChild) {


Ah the same explanation as above:) This should mean leftmost and rightmost ones

flutter-dashboard · 2024-08-09T00:34:15Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152976 at sha a685b0c

flutter-dashboard · 2024-08-12T00:16:17Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152976 at sha a8169f2

LongCatIsLooong

Adding an enabled state for segments introduces a corner case where a segment is disabled (by rebuild) during a drag gesture, and it looks like it's not handled in the implementation? Could you add tests for that corner case?

Also what's the expected behavior of onValueChanged, if the current selection is disabled?

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

LongCatIsLooong · 2024-08-12T20:30:24Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

+  ///
+  /// Disabled children cannot be highlighted and don't show any animation
+  /// when they are tapped or long pressed. So if this set contains [groupValue],
+  /// there is no segment getting highlighted until it is switched to an enabled


does that mean the original selected segment, if any, is unselected?

Yes, this is my understanding. If we have groupValue non null initially and it is disabled, we should not show the "highlighted" segment. This is what I saw it in Xcode experiment:)

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

LongCatIsLooong · 2024-08-12T20:33:24Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

  final HorizontalDragGestureRecognizer drag = HorizontalDragGestureRecognizer();
  final LongPressGestureRecognizer longPress = LongPressGestureRecognizer();

+  T? get groupValue => widget.disabledChildren.contains(widget.groupValue) ? null : widget.groupValue;


nit: Well this works but usually this will become a problem in the didUpdateWidget in the implementation becasue now you can't compare groupValue from the old widget (if that's need that is).

LongCatIsLooong · 2024-08-12T20:54:23Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

    if (highlighted == newValue) {
      return;
    }
+    // If `disabledChildren` set contains the `groupValue`, then no update


What happens if a drag is started, and highlighted becomes disabled and the gesture lands in highlighed? (Consider adding a test case).

Ah I think I include the demo in the PR description. When we are dragging the thumb to the disabled segment, the thumb will stop and still highlight the previous one. Does this make sense? Will create one test!

Screen.Recording.2024-08-12.at.6.27.11.PM.mov

I meant that the parent widget rebuilds so the currently selected segment becomes disabled. See also: #152976 (review)

Thanks so much for all the review suggestions! Added unit tests for both highlight behavior and onValueChanged behavior. If the highlighted is added to disabledChildren during drag, then when dragging is completed, the highlight will disappear, but onValueChanged will still be called. The onValueChanged behavior is simulated from XCode example.

LongCatIsLooong · 2024-08-12T20:58:28Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

    final T segment = segmentForXPosition(details.localPosition.dx);
    onPressedChangedByGesture(null);
-    if (segment != widget.groupValue) {
+    if (segment != groupValue) {


nit: combine the nested ifs using &&?

Or do you need this enable check? groupValue is null if disabled no?

flutter-dashboard · 2024-08-15T23:48:22Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #152976 at sha b3f6206

LongCatIsLooong

IMO it makes more sense to allow selecting a disabled segment programmatically. It works better with the onValueChanged callback and it gives developers full control over the behavior. You can select a disabled segment in UISegmentedControl programmatically too.

LongCatIsLooong · 2024-08-20T20:39:05Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

-            child: DefaultTextStyle.merge(
-              style: const TextStyle(fontWeight: FontWeight.w500),
-              child: widget.child,
+          DefaultTextStyle.merge(


nit: consider adding a comment for why the indexed stack and the widget replica.

LongCatIsLooong · 2024-08-23T06:08:07Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

+  /// there is no segment getting highlighted until it is switched to an enabled
+  /// segment.
+  ///
+  /// [onValueChanged] will not be called if the segment is disabled. However, if


The [onValueChanged] callback will not be called if the currently selected segment becomes disabled,

LongCatIsLooong · 2024-08-23T06:08:54Z

packages/flutter/lib/src/cupertino/sliding_segmented_control.dart

+  ///
+  /// [onValueChanged] will not be called if the segment is disabled. However, if
+  /// an enabled segment is "highlighted" by dragging gesture and becomes disabled
+  /// before dragging stops, [onValueChanged] will be triggered when release finger.


This sounds a bit confusing. What will be selected?

…2976)

Roll Flutter from 2e221e7 to 303f222 (77 revisions) flutter/flutter@2e221e7...303f222 2024-09-12 [email protected] Manual roll to 48ddaf578fb0c8326d5b4b680b0f49ea72e33216 (flutter/flutter#155070) 2024-09-12 [email protected] Externalize and update onboarding instructions (flutter/flutter#154730) 2024-09-12 [email protected] when setting up the log reader for a device during `flutter run`, discard any `RPCError` thrown due to the device being disconnected (flutter/flutter#155049) 2024-09-12 98614782+auto-submit[bot]@users.noreply.github.com Reverts "iOS: update provisioning profile for 2024-2025 cert (#155052)" (flutter/flutter#155059) 2024-09-12 [email protected] iOS: update provisioning profile for 2024-2025 cert (flutter/flutter#155052) 2024-09-11 [email protected] Factor out `Container` objects (flutter/flutter#153619) 2024-09-11 [email protected] Move (`dev/tools`), complete v0 of `native_driver` (Android) (flutter/flutter#154843) 2024-09-11 [email protected] Roll Flutter Engine from ade8ef293bc6 to ee5adf6d2ee1 (2 revisions) (flutter/flutter#155046) 2024-09-11 [email protected] Fix `flutter run` on Mac x64 hosts if Swift Package Manager is enabled (flutter/flutter#154645) 2024-09-11 [email protected] Roll Packages from bb53e5d to 4c18648 (1 revision) (flutter/flutter#155033) 2024-09-11 [email protected] Roll Flutter Engine from 4eb729b7a5c4 to ade8ef293bc6 (3 revisions) (flutter/flutter#155031) 2024-09-11 [email protected] fix: Dropdown menu trying to access highlight element which doesn't exist when search and filters both are enabled (flutter/flutter#151969) 2024-09-11 [email protected] Marks Linux build_tests_3_5 to be unflaky (flutter/flutter#154993) 2024-09-11 [email protected] Add 'direction' allow to 'SegmentedButton' oriented vertically (flutter/flutter#150903) 2024-09-11 [email protected] Marks Linux build_tests_5_5 to be unflaky (flutter/flutter#154995) 2024-09-11 [email protected] Update the signature of DDS launcher callback. (flutter/flutter#154949) 2024-09-11 [email protected] Migrate Color.toString() test, improves `equalsIgnoringHashCodes` (flutter/flutter#154934) 2024-09-11 [email protected] Update material and cupertino localizations (flutter/flutter#154959) 2024-09-11 [email protected] Marks Linux build_tests_1_5 to be unflaky (flutter/flutter#154991) 2024-09-11 [email protected] Marks Linux build_tests_2_5 to be unflaky (flutter/flutter#154992) 2024-09-11 [email protected] Fix `flutter create` warning regarding Java compatibility (flutter/flutter#152836) 2024-09-11 [email protected] Roll Flutter Engine from 54757dab9462 to 4eb729b7a5c4 (1 revision) (flutter/flutter#155022) 2024-09-11 [email protected] Fix java version used by `build_aar_module_test` (flutter/flutter#154967) 2024-09-11 [email protected] Roll Flutter Engine from 0a14c519ea4f to 54757dab9462 (1 revision) (flutter/flutter#155015) 2024-09-11 [email protected] Roll Flutter Engine from 35a3171b72c5 to 0a14c519ea4f (1 revision) (flutter/flutter#154984) 2024-09-11 [email protected] Roll Flutter Engine from b9c0b96c3316 to 35a3171b72c5 (1 revision) (flutter/flutter#154980) 2024-09-11 [email protected] Roll Flutter Engine from 52eeea075767 to b9c0b96c3316 (1 revision) (flutter/flutter#154976) 2024-09-11 [email protected] Roll Flutter Engine from a26075f9b1e6 to 52eeea075767 (1 revision) (flutter/flutter#154973) 2024-09-11 [email protected] Roll Flutter Engine from 60c15bc0f40e to a26075f9b1e6 (6 revisions) (flutter/flutter#154969) 2024-09-11 [email protected] Migrate `apple-mobile-web-*` to `mobile-web-*`. (flutter/flutter#154964) 2024-09-11 [email protected] Roll Flutter Engine from 8a038a6f7099 to 60c15bc0f40e (15 revisions) (flutter/flutter#154960) 2024-09-10 [email protected] Adds dart fixes for Color opacity functions (flutter/flutter#154953) 2024-09-10 [email protected] Missing benchmarks for `foundation/all_elements_bench.dart` (flutter/flutter#154954) 2024-09-10 [email protected] Update color assertions (flutter/flutter#154752) 2024-09-10 [email protected] handle EAGAIN (macOS) in ErrorHandlingProcessManager (flutter/flutter#154306) 2024-09-10 [email protected] fix unpack freezing app with animation duration zero (flutter/flutter#153890) 2024-09-10 [email protected] Remove last `--disable-dart-dev` in `flutter/flutter`. (flutter/flutter#154948) 2024-09-10 [email protected] Remove scheduler: luci from new `build_aar_module_test` (flutter/flutter#154945) 2024-09-10 [email protected] Roll pub packages (flutter/flutter#154939) 2024-09-10 [email protected] `CupertinoSlidingSegmentedControl` update (flutter/flutter#152976) 2024-09-10 [email protected] Roll pub packages (flutter/flutter#154933) 2024-09-10 [email protected] fix test `chrome.close can recover if getTab throws a StateError` (flutter/flutter#154889) 2024-09-10 [email protected] SearchBar context menu (flutter/flutter#154833) 2024-09-10 [email protected] Fix `flutter build aar` for modules that use a plugin (flutter/flutter#154757) 2024-09-10 [email protected] Roll Packages from b4e0fc1 to bb53e5d (4 revisions) (flutter/flutter#154926) 2024-09-10 [email protected] Clean up `SnackBar` inherit theme data test (flutter/flutter#154921) ...

…2976)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Aug 7, 2024

QuncCccccc force-pushed the segmented_control_update branch from ce2986d to 7af6ff4 Compare August 7, 2024 00:52

QuncCccccc changed the title ~~Segmented control update~~ CupertinoSlidingSegmentedControl update Aug 7, 2024

QuncCccccc force-pushed the segmented_control_update branch from 8efda17 to 3465fb2 Compare August 8, 2024 00:21

QuncCccccc marked this pull request as ready for review August 8, 2024 20:49

QuncCccccc requested review from LongCatIsLooong and MitchellGoodwin August 8, 2024 20:51

flutter-dashboard bot added the will affect goldens Changes to golden files label Aug 8, 2024

LongCatIsLooong reviewed Aug 8, 2024

View reviewed changes

QuncCccccc commented Aug 8, 2024

View reviewed changes

QuncCccccc force-pushed the segmented_control_update branch from 51277b6 to 5a59efc Compare August 10, 2024 01:40

LongCatIsLooong reviewed Aug 12, 2024

View reviewed changes

QuncCccccc requested a review from LongCatIsLooong August 15, 2024 23:19

QuncCccccc mentioned this pull request Aug 20, 2024

Add ability to disable CupertinoSegmentedControl #152813

Merged

9 tasks

QuncCccccc force-pushed the segmented_control_update branch from d257a02 to 5b64f18 Compare August 22, 2024 19:36

LongCatIsLooong reviewed Aug 23, 2024

View reviewed changes

QuncCccccc force-pushed the segmented_control_update branch from 5b64f18 to 4e982a8 Compare August 29, 2024 22:20

QuncCccccc added 8 commits September 4, 2024 15:18

Update SlidingSegmentedControl

22eb727

Update separator height, segment control horizontal padding

8ac76d7

Disabled segment is not highlighted

252e2e5

Add tests for visual defaults and the new setEnabled api

91275f1

Remove unnecessary comment

c2c6c85

Update thumb scale alignment

e1ec9c7

Update test

fa9fa11

Update tests

bfa92ff

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Sep 10, 2024

auto-submit bot merged commit b872a27 into flutter:master Sep 10, 2024

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to fadbf4447172 (55 revisions) flutter/packages#7623

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

87d8165

…2976)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to d565781992f1 (56 revisions) flutter/packages#7624

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

4551e8e

…2976)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 0a9148870ad9 (57 revisions) flutter/packages#7625

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

8fa0125

…2976)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to d8de38f10d56 (59 revisions) flutter/packages#7627

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

f518ffa

…2976)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to bcf1c5a24358 (60 revisions) flutter/packages#7628

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

0c39043

…2976)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 6e46ee8d6d6f (63 revisions) flutter/packages#7629

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

afaef41

…2976)

engine-flutter-autoroll mentioned this pull request Sep 11, 2024

Roll Flutter from 2e221e7308ba to 04e1b174ea6d (66 revisions) flutter/packages#7630

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

b0b91f2

…2976)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 50a190caec0c (74 revisions) flutter/packages#7634

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

a3e76a0

…2976)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to d8f8613a5b94 (75 revisions) flutter/packages#7635

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

aec8652

…2976)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 90aa59f6c32f (76 revisions) flutter/packages#7637

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

c816038

…2976)

engine-flutter-autoroll mentioned this pull request Sep 12, 2024

Roll Flutter from 2e221e7308ba to 303f222e17e3 (77 revisions) flutter/packages#7638

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Sep 12, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

2184d39

…2976)

Piinks mentioned this pull request Sep 14, 2024

Flutter Framework Team: Notable Commits #121415

Closed

huycozy mentioned this pull request Oct 22, 2024

CupertinoSlidingSegmentedControl changes its width on iOS #151709

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

abb289c

…2976)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

b872a27 CupertinoSlidingSegmentedControl update (flutter/flutter#15…

3310f7a

…2976)

QuncCccccc mentioned this pull request Feb 25, 2025

Missing CupertinoSlidingSegmentedControl features #43826

Closed

CupertinoSlidingSegmentedControl update #152976

CupertinoSlidingSegmentedControl update #152976

Uh oh!

Conversation

QuncCccccc commented Aug 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Aug 8, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LongCatIsLooong Aug 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flutter-dashboard bot commented Aug 9, 2024

Uh oh!

flutter-dashboard bot commented Aug 12, 2024

Uh oh!

LongCatIsLooong left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

`CupertinoSlidingSegmentedControl` update #152976

`CupertinoSlidingSegmentedControl` update #152976

QuncCccccc commented Aug 7, 2024 •

edited

Loading

LongCatIsLooong Aug 8, 2024 •

edited

Loading

LongCatIsLooong Aug 12, 2024 •

edited

Loading

LongCatIsLooong Aug 13, 2024 •

edited

Loading

QuncCccccc Aug 15, 2024 •

edited

Loading