Slider shows visual label of value on focus #152960
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
9 tasks
Contributor
|
FYI @TahaTesser in case this affects the slider rewrite (which I need to catch up on reviewing!) |
QuncCccccc
approved these changes
Aug 13, 2024
Comment on lines
4559
to
4563
| theme: ThemeData( | ||
| sliderTheme: const SliderThemeData( | ||
| showValueIndicator: ShowValueIndicator.always, | ||
| ), | ||
| ), |
Contributor
There was a problem hiding this comment.
nit: Seems we can remove this part?
| final FocusNode focusNode = FocusNode(); | ||
| addTearDown(focusNode.dispose); | ||
|
|
||
| Widget buildApp({bool enabled = true}) { |
Contributor
There was a problem hiding this comment.
nit: maybe we can remove the parameter here since we only tested the enable slider:)
Contributor
Author
There was a problem hiding this comment.
Done, thanks for the recs!
DBowen33
force-pushed
the
slider-keyboard-focus-fix
branch
from
7d3e509 to
fbe9704
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 14, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 15, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 15, 2024
flutter/flutter@cc13cd1...99f00a1 2024-08-15 [email protected] Roll Flutter Engine from 76a1c64f4e63 to 971ddd9fe1bf (6 revisions) (flutter/flutter#153487) 2024-08-14 [email protected] Update tokens to 5.0.0 (flutter/flutter#153385) 2024-08-14 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.1 to 3.26.2 (flutter/flutter#153468) 2024-08-14 [email protected] Enable invalid_runtime_check_with_js_interop_types, use_truncating_division (flutter/flutter#153464) 2024-08-14 [email protected] Roll Flutter Engine from 9b8421662ec9 to 76a1c64f4e63 (1 revision) (flutter/flutter#153465) 2024-08-14 [email protected] Roll Flutter Engine from 328c4df8329f to 9b8421662ec9 (1 revision) (flutter/flutter#153463) 2024-08-14 [email protected] Lint sync (flutter/flutter#153453) 2024-08-14 [email protected] manual pub roll w/ gradle updates (flutter/flutter#153403) 2024-08-14 [email protected] Update docs to use new Android version in the engine (flutter/flutter#151601) 2024-08-14 [email protected] move some tool TESTOWNERS entries to andrew (flutter/flutter#153400) 2024-08-14 [email protected] Slider shows visual label of value on focus (flutter/flutter#152960) 2024-08-14 [email protected] Add `Row` and `Column` widgets specific `spacing` tests (flutter/flutter#153353) 2024-08-14 [email protected] Delay `DropdownMenu` filtering until text input (flutter/flutter#152368) 2024-08-14 [email protected] Update cherry pick issue template's PR field (flutter/flutter#153381) 2024-08-14 [email protected] Roll Flutter Engine from 5909666fdedb to 328c4df8329f (1 revision) (flutter/flutter#153436) 2024-08-14 [email protected] [web] Pass `--no-source-maps` instead of `--extra-compiler-option=--no-source-maps` to `dart compile wasm` (flutter/flutter#153417) 2024-08-14 [email protected] Manual roll Flutter Engine from 019f9e3f0744 to 5909666fdedb (12 revisions) (flutter/flutter#153413) 2024-08-14 [email protected] Move `@_debugOnly` documentation in `framework.dart` to be more visible to IDE. (flutter/flutter#153134) 2024-08-13 [email protected] Roll Flutter Engine from 4246f1536c5d to 019f9e3f0744 (2 revisions) (flutter/flutter#153394) 2024-08-13 [email protected] fix(flutter/a11y assessments): h1 missing a11y from each page on the web app (flutter/flutter#152198) 2024-08-13 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.0 to 3.26.1 (flutter/flutter#153395) 2024-08-13 [email protected] Roll Packages from d9a6de8 to e4f2247 (4 revisions) (flutter/flutter#153383) 2024-08-13 [email protected] Roll pub packages (flutter/flutter#153380) 2024-08-13 [email protected] Roll Flutter Engine from 73c3135cc3be to 4246f1536c5d (2 revisions) (flutter/flutter#153377) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
DBowen33
added a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
Fixed issue to where value indicator label is not shown to user when initially focused. Before: [Screen recording 2024-08-05 12.16.24 PM.webm](https://github.com/user-attachments/assets/806e94d7-7c6c-40e5-93af-dbf2fb9e0dd4) After: https://screencast.googleplex.com/cast/NTY5NzIzMTYxNjIxMjk5MnxkY2IyMGNkYi1iZA Fixes flutter#113538
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
Fixed issue to where value indicator label is not shown to user when initially focused. Before: [Screen recording 2024-08-05 12.16.24 PM.webm](https://github.com/user-attachments/assets/806e94d7-7c6c-40e5-93af-dbf2fb9e0dd4) After: https://screencast.googleplex.com/cast/NTY5NzIzMTYxNjIxMjk5MnxkY2IyMGNkYi1iZA Fixes flutter#113538
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue to where value indicator label is not shown to user when initially focused.
Before: Screen recording 2024-08-05 12.16.24 PM.webm
After: https://screencast.googleplex.com/cast/NTY5NzIzMTYxNjIxMjk5MnxkY2IyMGNkYi1iZA
Fixes #113538
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.