Skip to content

Conversation

@kevmoo
Copy link
Contributor

@kevmoo kevmoo commented Aug 5, 2024

package:collection is 50+ days behind at this point which is blocking updates to a number of other packages http_parser, shelf, etc...

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. a: internationalization Supporting other languages or locales. (aka i18n) d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos platform-web Web applications specifically f: integration_test The flutter/packages/integration_test plugin labels Aug 5, 2024
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 5, 2024
@auto-submit
Copy link
Contributor

auto-submit bot commented Aug 5, 2024

auto label is removed for flutter/flutter/152881, due to - The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

@christopherfujino
Copy link
Contributor

Looks like legit build failure:

[        ] Caused by: org.gradle.internal.locking.LockOutOfDateException: Resolved 'androidx.media3:media3-exoplayer-rtsp:1.4.0' which is not part of the dependency lock state

https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8740412652728516577/+/u/run_test.dart_for_build_tests_shard_and_subshard_1_3/stdout

@christopherfujino
Copy link
Contributor

cc @gmackall

@gmackall
Copy link
Member

gmackall commented Aug 5, 2024

This should be fixed by updating the Gradle lockfiles, from the root of your Flutter repo

find . -type d -name 'android' | dart dev/tools/bin/generate_gradle_lockfiles.dart --no-exclusion --no-gradle-generation

If it complains that you need Java 17 you can set your JAVA_HOME to the java in the engine checkout (at engine/src/flutter/third_party/java/openjdk/Contents/Home/)

Or just apply this diff if that works? lockfile_diff.txt

@kevmoo
Copy link
Contributor Author

kevmoo commented Aug 5, 2024

lock file applied. Let's see!

@kevmoo kevmoo added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 6, 2024
@auto-submit auto-submit bot merged commit 3612ba1 into master Aug 6, 2024
@auto-submit auto-submit bot deleted the manual_dep_bump branch August 6, 2024 02:40
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 6, 2024
Manual roll requested by [email protected]

flutter/flutter@3832823...1dd7141

2024-08-06 [email protected] Roll Flutter Engine from 376a853846ce to f5f6e966e7e7 (1 revision) (flutter/flutter#152911)
2024-08-06 [email protected] Pass --no-dds to some integration tests driven by flutter drive (flutter/flutter#152898)
2024-08-06 [email protected] Manual dependency bump (flutter/flutter#152881)
2024-08-06 [email protected] Add tests for ordered_traversal_group.0.dart (flutter/flutter#152849)
2024-08-06 [email protected] Implement `on` clauses (flutter/flutter#152706)
2024-08-06 [email protected] Roll Flutter Engine from bc140a0124b7 to 376a853846ce (2 revisions) (flutter/flutter#152905)
2024-08-06 [email protected] Roll Flutter Engine from e073ad2e3ad4 to bc140a0124b7 (1 revision) (flutter/flutter#152895)
2024-08-05 [email protected] added functionality to where SR will communicate button clicked (flutter/flutter#152185)
2024-08-05 [email protected] more docImports (flutter/flutter#151951)
2024-08-05 [email protected] Bump dartdoc to 8.0.13 (flutter/flutter#152896)
2024-08-05 [email protected] [Reland] Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152890)
2024-08-05 [email protected] Fix CarouselView rebuild (flutter/flutter#152791)
2024-08-05 [email protected] Roll Flutter Engine from 1bfd06cda313 to e073ad2e3ad4 (4 revisions) (flutter/flutter#152889)
2024-08-05 [email protected] Add migration to git ignore SwiftPM build directories (flutter/flutter#152766)
2024-08-05 [email protected] Roll pub packages (flutter/flutter#152127)
2024-08-05 [email protected] Roll Flutter Engine from 0aac60342005 to 1bfd06cda313 (2 revisions) (flutter/flutter#152868)
2024-08-05 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (#152472)" (flutter/flutter#152885)
2024-08-05 [email protected] [Docs] DeviceOrientation Enum Correction (flutter/flutter#152876)
2024-08-05 [email protected] Move Linux_build_test tests from staging to prod (flutter/flutter#152877)
2024-08-05 [email protected] Introduce `double` `Flex.spacing` parameter for `Row`/`Column` spacing (flutter/flutter#152472)
2024-08-05 [email protected] Mark Linux_android_emu tests bringup: true (flutter/flutter#152867)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
`package:collection` is 50+ days behind at this point which is blocking updates to a number of other packages `http_parser`, `shelf`, etc...
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
`package:collection` is 50+ days behind at this point which is blocking updates to a number of other packages `http_parser`, `shelf`, etc...
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: internationalization Supporting other languages or locales. (aka i18n) a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: integration_test The flutter/packages/integration_test plugin framework flutter/packages/flutter repository. See also f: labels. platform-web Web applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants