refactor material banner and fix focus issue #152646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
f: material design
Contributor
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
Some minor remarks still, but I'm not sure why that assertion is being thrown, though.
Contributor
Author
Looks like the assertion error had to do with setting the state, now that I've taken the set state out the assertion is not being thrown anymore. Thank you! |
Contributor
navaronbracke
left a comment
navaronbracke
left a comment
There was a problem hiding this comment.
Just some missing commas and formatting for the MaterialBanner use case file, but otherwise this looks good to me.
Unfortunately I'm unable to give you an approval myself, but I'm going to reach out to get an additional reviewer.
DBowen33
force-pushed
the
material-focus-fix
branch
2 times, most recently
from
fa69b0f to
eec6c06
Compare
chunhtai
reviewed
Aug 14, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
Sorry I realized I have not send the review comment
chunhtai
approved these changes
Aug 16, 2024
Contributor
chunhtai
left a comment
chunhtai
left a comment
There was a problem hiding this comment.
LGTM, looks like you need to rebase to fix the conflict and ci
DBowen33
requested review from
christopherfujino and
matanlurey
as code owners
github-actions
bot
added
a: tests
github-actions
bot
removed
f: routes
DBowen33
force-pushed
the
material-focus-fix
branch
from
73d2f61 to
fcd0c84
Compare
DBowen33
force-pushed
the
material-focus-fix
branch
from
fcd0c84 to
64ae2d7
Compare
DBowen33
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 20, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 20, 2024
flutter/flutter@6a28048...e7da16d 2024-08-20 [email protected] Fixes page.onPopInvoked type mismatches (flutter/flutter#153593) 2024-08-20 [email protected] When the app enters the detached state, clear the record of the last SystemChrome style sent to the host (flutter/flutter#153586) 2024-08-20 [email protected] Handle "Service connection disposed" error from VmService disconnecting while requests are outstanding (flutter/flutter#153714) 2024-08-20 [email protected] Roll Flutter Engine from ec775a3a645e to e10b07598091 (1 revision) (flutter/flutter#153764) 2024-08-20 [email protected] Roll Packages from 7c1a05c to 4d2d2e3 (6 revisions) (flutter/flutter#153763) 2024-08-20 [email protected] Roll Flutter Engine from 0ac9e97cc1c0 to ec775a3a645e (1 revision) (flutter/flutter#153761) 2024-08-20 [email protected] Reland "Load parent package config" (flutter/flutter#153754) 2024-08-20 [email protected] Roll Flutter Engine from 48d7b04674d9 to 0ac9e97cc1c0 (2 revisions) (flutter/flutter#153753) 2024-08-20 [email protected] Revert "Load parent package config" (flutter/flutter#153752) 2024-08-20 [email protected] Roll Flutter Engine from b0284aac7b4d to 48d7b04674d9 (1 revision) (flutter/flutter#153746) 2024-08-20 [email protected] Load parent package config (flutter/flutter#150850) 2024-08-20 [email protected] Roll Flutter Engine from 20b8a5c13742 to b0284aac7b4d (1 revision) (flutter/flutter#153743) 2024-08-20 [email protected] Roll Flutter Engine from 86f269bd5261 to 20b8a5c13742 (2 revisions) (flutter/flutter#153741) 2024-08-20 [email protected] Roll Flutter Engine from 5355c0b60e6e to 86f269bd5261 (4 revisions) (flutter/flutter#153739) 2024-08-20 [email protected] Roll Flutter Engine from 7dd71ff80d23 to 5355c0b60e6e (1 revision) (flutter/flutter#153734) 2024-08-20 [email protected] Roll Flutter Engine from 9d7e3a6b97d0 to 7dd71ff80d23 (4 revisions) (flutter/flutter#153733) 2024-08-19 [email protected] refactor material banner and fix focus issue (flutter/flutter#152646) 2024-08-19 [email protected] Roll Flutter Engine from 30ffbfaf6a06 to 9d7e3a6b97d0 (3 revisions) (flutter/flutter#153724) 2024-08-19 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.2 to 3.26.3 (flutter/flutter#153726) 2024-08-19 [email protected] Roll Flutter Engine from c5d23162bb9b to 30ffbfaf6a06 (1 revision) (flutter/flutter#153721) 2024-08-19 [email protected] Roll Flutter Engine from bf538a0a98b0 to c5d23162bb9b (1 revision) (flutter/flutter#153719) 2024-08-19 [email protected] Remove android stack_size_test (flutter/flutter#153695) 2024-08-19 [email protected] Roll Flutter Engine from e29b5529080d to bf538a0a98b0 (2 revisions) (flutter/flutter#153713) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
- Refactored material banner setup to make it more simple and stateless - Added focusNode to where the dismiss button focuses automatically when banner is shown Before: https://screencast.googleplex.com/cast/NTI4OTMxNjU2MDQwNDQ4MHw2ODdiMmYwOC1hMg After: https://screencast.googleplex.com/cast/NjAzNTY4NDA2NTI4MDAwMHwyNTRjMWUxMi0zMA fixes b/346646604
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before: https://screencast.googleplex.com/cast/NTI4OTMxNjU2MDQwNDQ4MHw2ODdiMmYwOC1hMg
After: https://screencast.googleplex.com/cast/NjAzNTY4NDA2NTI4MDAwMHwyNTRjMWUxMi0zMA
fixes b/346646604
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.