Reverts "Add button semantics in list tile (#151599)" #152425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 37dff27.
auto-submit
bot
added
the
revert of
github-actions
bot
added
framework
fluttergithubbot
approved these changes
Jul 27, 2024
auto-submit
bot
deleted the
revert_37dff27324ce429173482482304c859d7d1a4646
branch
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 27, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 28, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 31, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 1, 2024
Manual roll requested by [email protected] flutter/flutter@4d12197...f817e51 2024-07-27 [email protected] Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) (flutter/flutter#152436) 2024-07-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add button semantics in list tile (#151599)" (flutter/flutter#152425) 2024-07-27 [email protected] Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) (flutter/flutter#152424) 2024-07-27 [email protected] Document that `flutter drive --test-arguments` can opt-in to `dart test` (flutter/flutter#152410) 2024-07-27 [email protected] Roll Flutter Engine from 0c5504e15e15 to 739ae15e8bf2 (4 revisions) (flutter/flutter#152417) 2024-07-27 [email protected] Roll Flutter Engine from e28f8755e25b to 0c5504e15e15 (5 revisions) (flutter/flutter#152414) 2024-07-26 [email protected] Add button semantics in list tile (flutter/flutter#151599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…#152425) Reverts: flutter#151599 Initiated by: chingjun Reason for reverting: broke an internal test. Original PR Author: hangyujin Reviewed By: {chunhtai} This change reverts the following previous change: fixes: flutter#111960
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…#152425) Reverts: flutter#151599 Initiated by: chingjun Reason for reverting: broke an internal test. Original PR Author: hangyujin Reviewed By: {chunhtai} This change reverts the following previous change: fixes: flutter#111960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts: #151599
Initiated by: chingjun
Reason for reverting: broke an internal test.
Original PR Author: hangyujin
Reviewed By: {chunhtai}
This change reverts the following previous change:
fixes: #111960
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.