Document that flutter drive --test-arguments can opt-in to dart test
#152410
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
| final int result = await _processUtils.stream(<String>[ | ||
| _dartSdkPath, | ||
| ...<String>[...arguments, testFile, '-rexpanded'], | ||
| ...arguments, |
There was a problem hiding this comment.
what about -rexpanded?
There was a problem hiding this comment.
what about
-rexpanded?
You'll notice I also removed
-rexpanded; @jonahwilliams believes that was accidentally copied over from else-where, and never did anything (someone I guess could have parsed it invoid main(...), but given #51135 & #145499 that seems unlikely.
There was a problem hiding this comment.
(We could do some gymnastics to retain that argument if we wanted to, but I don't see a reason to?)
There was a problem hiding this comment.
Yeah, since its just a dart script the command line argument goes no where (well it went to args, but what are you gonna do with it?)
There was a problem hiding this comment.
yeah, i see what you mean. i like -rexpanded, but I can add that later in our /dev/bots dir.
There was a problem hiding this comment.
yeah, i see what you mean. i like -rexpanded, but I can add that later in our /dev/bots dir.
I also think, and might be wrong, that --reporter=expanded is the default when dart test runs on CI (https://pub.dev/packages/test#selecting-a-test-reporter), and if not we can definitely make it our default.
There was a problem hiding this comment.
we don't run on github actions (although i guess we could set that variable :) )
Manual roll requested by [email protected] flutter/flutter@4d12197...f817e51 2024-07-27 [email protected] Roll Flutter Engine from 38fddb289f18 to add1b784b80a (3 revisions) (flutter/flutter#152436) 2024-07-27 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add button semantics in list tile (#151599)" (flutter/flutter#152425) 2024-07-27 [email protected] Roll Flutter Engine from 739ae15e8bf2 to 38fddb289f18 (2 revisions) (flutter/flutter#152424) 2024-07-27 [email protected] Document that `flutter drive --test-arguments` can opt-in to `dart test` (flutter/flutter#152410) 2024-07-27 [email protected] Roll Flutter Engine from 0c5504e15e15 to 739ae15e8bf2 (4 revisions) (flutter/flutter#152417) 2024-07-27 [email protected] Roll Flutter Engine from e28f8755e25b to 0c5504e15e15 (5 revisions) (flutter/flutter#152414) 2024-07-26 [email protected] Add button semantics in list tile (flutter/flutter#151599) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…st` (flutter#152410) Closes flutter#51135. Closes flutter#145499. Making this the _default_, or better discoverable, is tracked in flutter#152409. You'll notice I also removed `-rexpanded`; @jonahwilliams believes that was accidentally copied over from else-where, and never did anything (someone I guess could have parsed it in `void main(...)`, but given flutter#51135 & flutter#145499 that seems unlikely.
…st` (flutter#152410) Closes flutter#51135. Closes flutter#145499. Making this the _default_, or better discoverable, is tracked in flutter#152409. You'll notice I also removed `-rexpanded`; @jonahwilliams believes that was accidentally copied over from else-where, and never did anything (someone I guess could have parsed it in `void main(...)`, but given flutter#51135 & flutter#145499 that seems unlikely.
3 participants
Closes #51135.
Closes #145499.
Making this the default, or better discoverable, is tracked in #152409.
You'll notice I also removed
-rexpanded; @jonahwilliams believes that was accidentally copied over from else-where, and never did anything (someone I guess could have parsed it invoid main(...), but given #51135 & #145499 that seems unlikely.