[cupertino/icons.dart] Replace ligature references with codepoints for dartdoc #152387
Conversation
github-actions
bot
added
framework
victorsanni
changed the title
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
The file says "BEGIN GENERATED SF SYMBOLS NAMES", but I don't see any changes to a generator - so how were these changes made? |
I'll link the original issues in the description for more context. But the tldr is: We currently generate this file locally from this repo: https://github.com/xster/framework7-icons. This PR is the first step of many to fix that. |
|
I would hope we would fix the repo and move the script to this repo before making the code change - is there a reason we can't do that? |
Yeah currenly the Also the priority of the ligature table removal has changed. @victorsanni is working on porting the python scripts to dart, based on some initial assessments it will be a non-trivial effort to keep maintaining the ligature table so we'd like to remove things that currently depend on ligatures. |
|
Ok so if I understand this correctly, doing this "right" is a breaking change, so we're front-loading making this experience better for our users while we fix our process bits in the background? test-exempt: Thanks for explaining, the trade-off seems reasonable. |
victorsanni
added
the
autosubmit
victorsanni
changed the title
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
…cters corresponding to codepoints (flutter/flutter#152387)
Manual roll requested by [email protected] flutter/flutter@031dc3d...4d12197 2024-07-26 [email protected] further shard Mac tool_integration_tests from 4 to 5 shards (flutter/flutter#152399) 2024-07-26 [email protected] Change flutter_build_with_compilation_error_test to check stdout or stderr (flutter/flutter#152404) 2024-07-26 [email protected] [cupertino/icons.dart] Replace ligature references with characters corresponding to codepoints (flutter/flutter#152387) 2024-07-26 [email protected] Update minimum macOS version as needed in Swift package (flutter/flutter#152347) 2024-07-26 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.14 to 3.25.15 (flutter/flutter#152401) 2024-07-26 49699333+dependabot[bot]@users.noreply.github.com Bump ossf/scorecard-action from 2.3.3 to 2.4.0 (flutter/flutter#152400) 2024-07-26 [email protected] Update text_painter.dart (flutter/flutter#152398) 2024-07-26 [email protected] Fix some tests that fail with Swift Package Manager enabled (flutter/flutter#152267) 2024-07-26 [email protected] Reland "Launch DDS from Dart SDK and prepare to serve DevTools from DDS (#146593)" (flutter/flutter#152386) 2024-07-26 [email protected] Make `DragGestureRecognizer` abstract methods public (flutter/flutter#151627) 2024-07-26 [email protected] Fix cursor position when Unicode Zs category is entered in TextField (flutter/flutter#152215) 2024-07-26 [email protected] Roll Flutter Engine from 354abf2800a0 to e28f8755e25b (2 revisions) (flutter/flutter#152388) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
…rresponding to codepoints (flutter#152387) Part of flutter#148075
…rresponding to codepoints (flutter#152387) Part of flutter#148075
3 participants
Part of #148075
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.