Try flutter/engine#53571 #152345
Try flutter/engine#53571 #152345
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
This PR does a few things. Mainly it makes the builds in mac_host_engine.json each build fewer targets to increase parallelism for post-submit and release builds. To ensure that increasing parallelism doesn't lead to capacity issues, this change also allows the mac_host_engine.json builds to run on either intel or arm64 macOS hosts. Finally, when building on an arm64 macOS host to target macOS, this PR changes the `gn` script to ensure that the arm64 native clang toolchain will be used. To keep mac_host_engine.json focused on builds that produce artifacts, this PR also moves tests from that file into the ill-named mac_unopt.json. In a subsequent PR, I'll rename all the *_unopt.json files to *_tests.json or something similar. The artifacts produced by these builds are passing framework presubmit checks in flutter/flutter#152345.
|
This pull request executed golden file tests, but it has not been updated in a while (20+ days). Test results from Gold expire after as many days, so this pull request will need to be updated with a fresh commit in order to get results from Gold. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
1 participant
No description provided.