Reverts "Use more CORS headers for `flutter run` server (#152048)" #152248

auto-submit · 2024-07-24T17:43:11Z

Reverts: #152048

Initiated by: cbracken

Reason for reverting: breaks tool tests.

Example:

00:06 +762 ~2 -1: test/general.shard/web/web_asset_server_test.dart: release asset server serves correct mime type and content length for png [E]
  Expected: {'Content-Type': 'image/png', 'content-length': '64'}
    Actual: {
              'Content-Type': 'image/png',
              'Cross-Origin-Resource-Policy': 'cross-origin',
              'Access-Contr
<!-- end_revert_reason -->
<!-- start_original_pr_author -->
Original PR Author: johnpryan
<!-- end_original_pr_author -->

<!-- start_reviewers -->
Reviewed By: {eyebrowsoffire}
<!-- end_reviewers -->

<!-- start_revert_body -->
This change reverts the following previous change:
@eyebrowsoffire 
<!-- end_revert_body -->

This reverts commit 11d81f2.

flutter-dashboard · 2024-07-24T17:43:15Z

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

…048)" (flutter/flutter#152248)

Roll Flutter from 7d5c1c0 to 031dc3d (97 revisions) flutter/flutter@7d5c1c0...031dc3d 2024-07-26 [email protected] Roll Flutter Engine from 342a42547822 to 354abf2800a0 (7 revisions) (flutter/flutter#152385) 2024-07-26 [email protected] Use more CORS headers for flutter run server (flutter/flutter#152249) 2024-07-26 [email protected] Manual roll Flutter Engine from 8714b54a87c0 to 342a42547822 (6 revisions) (flutter/flutter#152379) 2024-07-26 [email protected] feat: Add drag handle size to be configurable based on given size (flutter/flutter#152085) 2024-07-26 [email protected] Add and use an integration test with native(ADB) screenshots (flutter/flutter#152326) 2024-07-26 [email protected] Roll Packages from 19daf6f to 3d358d9 (4 revisions) (flutter/flutter#152372) 2024-07-26 [email protected] Add test for range_slider.0.dart (flutter/flutter#152152) 2024-07-26 [email protected] Introduce `TabBar.indicatorAnimation` to customize tab indicator animation (flutter/flutter#151746) 2024-07-26 [email protected] Roll Flutter Engine from 21629ece8b72 to 8714b54a87c0 (3 revisions) (flutter/flutter#152351) 2024-07-26 [email protected] Cleanup examples/api web load logic to latest (flutter/flutter#152349) 2024-07-26 [email protected] Adds a call to the `PlatformDispatcher` whenever the focus changes (flutter/flutter#151268) 2024-07-26 [email protected] Roll Flutter Engine from d665bf82dc32 to 21629ece8b72 (4 revisions) (flutter/flutter#152344) 2024-07-25 [email protected] `docImport`s for the widgets library (flutter/flutter#152339) 2024-07-25 [email protected] Set dart defines properly while in debug mode. (flutter/flutter#152262) 2024-07-25 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.13 to 3.25.14 (flutter/flutter#152342) 2024-07-25 [email protected] Roll Flutter Engine from 74785a771ae6 to d665bf82dc32 (2 revisions) (flutter/flutter#152340) 2024-07-25 [email protected] Cleanup InputDecoration.collapsed constructor (flutter/flutter#152165) 2024-07-25 [email protected] Add test for expansion_panel_list.expansion_panel_list_radio.0_test.dart (flutter/flutter#151730) 2024-07-25 [email protected] Roll Flutter Engine from f862a620cee4 to 74785a771ae6 (2 revisions) (flutter/flutter#152333) 2024-07-25 [email protected] Roll Packages from 1c319ac to 19daf6f (3 revisions) (flutter/flutter#152327) 2024-07-25 [email protected] Add a more typical / concrete example to IntrinsicHeight / IntrinsicWidth (flutter/flutter#152246) 2024-07-25 [email protected] Roll Flutter Engine from f47b4d8e145a to f862a620cee4 (1 revision) (flutter/flutter#152320) 2024-07-25 [email protected] Roll Flutter Engine from 74737820a8ee to f47b4d8e145a (7 revisions) (flutter/flutter#152314) 2024-07-25 [email protected] Flutter Web App: adds a11y semantic attributes to slider (flutter/flutter#151985) 2024-07-25 [email protected] Manual roll Flutter Engine from eb8fac2b1703 to 74737820a8ee (8 revisions) (flutter/flutter#152305) 2024-07-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from eb8fac2b1703 to a57655cccb55 (6 revisions) (#152293)" (flutter/flutter#152304) 2024-07-25 [email protected] Roll Flutter Engine from eb8fac2b1703 to a57655cccb55 (6 revisions) (flutter/flutter#152293) 2024-07-25 [email protected] Modify stepping integration test to accommodate new DDC async semantics. (flutter/flutter#152204) 2024-07-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Roll Flutter Engine from eb8fac2b1703 to e1259b86ba02 (2 revisions) (#152285)" (flutter/flutter#152289) 2024-07-25 [email protected] Update fake_codec.dart to use Future.value instead of SynchronousFuture (flutter/flutter#152182) 2024-07-25 [email protected] Roll Flutter Engine from eb8fac2b1703 to e1259b86ba02 (2 revisions) (flutter/flutter#152285) 2024-07-25 [email protected] Roll Flutter Engine from 4b952093cb99 to eb8fac2b1703 (3 revisions) (flutter/flutter#152278) 2024-07-24 [email protected] [CupertinoAlertDialog] Rewrite (flutter/flutter#150410) 2024-07-24 [email protected] Revert "Make `CupertinoRadio`'s `mouseCursor` a `WidgetStateProperty`" (flutter/flutter#152254) 2024-07-24 [email protected] Fix: A selectable's selection under the active selection should not be cleared on right-click (flutter/flutter#151851) 2024-07-24 [email protected] Marks Mac channels_integration_test to be flaky (flutter/flutter#151882) 2024-07-24 [email protected] Roll Flutter Engine from c2f489d783d6 to 4b952093cb99 (3 revisions) (flutter/flutter#152264) 2024-07-24 [email protected] added Semantics label to TextField with InputDecoration to let user kâ�¦ (flutter/flutter#151996) 2024-07-24 [email protected] feat: Add alignmentOffset to DropdownMenu (flutter/flutter#151731) 2024-07-24 [email protected] Roll Flutter Engine from 490576daf810 to c2f489d783d6 (6 revisions) (flutter/flutter#152260) 2024-07-24 [email protected] Scaffolding for `NativeDriver` and `AndroidNativeDriver` for taking screenshots using `adb`. (flutter/flutter#152194) 2024-07-24 [email protected] `widgets` docImport (flutter/flutter#152146) 2024-07-24 [email protected] Roll Flutter Engine from 3078f6a90e71 to 490576daf810 (1 revision) (flutter/flutter#152239) 2024-07-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Use more CORS headers for `flutter run` server (#152048)" (flutter/flutter#152248) 2024-07-24 [email protected] Use more CORS headers for `flutter run` server (flutter/flutter#152048) 2024-07-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Enable Swift Package Manager by default on master channel (#152049)" (flutter/flutter#152243) ...

@eyebrowsoffire

…)" (flutter#152248) Reverts: flutter#152048 Initiated by: cbracken Reason for reverting: breaks tool tests. Example: ``` 00:06 +762 ~2 -1: test/general.shard/web/web_asset_server_test.dart: release asset server serves correct mime type and content length for png [E] Expected: {'Content-Type': 'image/png', 'content-length': '64'} Actual: { 'Content-Type': 'image/png', 'Cross-Origin-Resource-Policy': 'cross-origin', 'Access-Contr Original PR Author: johnpryan Reviewed By: {eyebrowsoffire} This change reverts the following previous change: @eyebrowsoffire

@eyebrowsoffire

…)" (flutter#152248) Reverts: flutter#152048 Initiated by: cbracken Reason for reverting: breaks tool tests. Example: ``` 00:06 +762 ~2 -1: test/general.shard/web/web_asset_server_test.dart: release asset server serves correct mime type and content length for png [E] Expected: {'Content-Type': 'image/png', 'content-length': '64'} Actual: { 'Content-Type': 'image/png', 'Cross-Origin-Resource-Policy': 'cross-origin', 'Access-Contr Original PR Author: johnpryan Reviewed By: {eyebrowsoffire} This change reverts the following previous change: @eyebrowsoffire

Revert "Use more CORS headers for flutter run server (#152048)"

542852b

This reverts commit 11d81f2.

auto-submit bot added the revert of Bot Only: Tracking label for bot. Tracks new revert of pull requests. label Jul 24, 2024

auto-submit bot assigned cbracken Jul 24, 2024

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 24, 2024

fluttergithubbot approved these changes Jul 24, 2024

View reviewed changes

auto-submit bot merged commit f64190a into master Jul 24, 2024

auto-submit bot deleted the revert_11d81f2709de6b16fd98ebd9a76a757423d5510f branch July 24, 2024 17:44

engine-flutter-autoroll mentioned this pull request Jul 24, 2024

Roll Flutter from 7d5c1c04fb56 to f64190aacb13 (54 revisions) flutter/packages#7209

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

396cf95

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 24, 2024

Roll Flutter from 7d5c1c04fb56 to db97b1aac047 (55 revisions) flutter/packages#7210

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

0f88148

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 25, 2024

Roll Flutter from 7d5c1c04fb56 to 3c0302c33d10 (73 revisions) flutter/packages#7212

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

ae9ffcd

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 25, 2024

Roll Flutter from 7d5c1c04fb56 to 7d588feacde9 (74 revisions) flutter/packages#7213

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

128f1cf

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 25, 2024

Roll Flutter from 7d5c1c04fb56 to 033d1adb9d62 (76 revisions) flutter/packages#7214

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

2cad4c6

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 25, 2024

Roll Flutter from 7d5c1c04fb56 to 43b653e93f35 (77 revisions) flutter/packages#7217

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

8ec8bd5

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 25, 2024

Roll Flutter from 7d5c1c04fb56 to 9be37535d926 (78 revisions) flutter/packages#7219

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

bbebd25

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 26, 2024

Roll Flutter from 7d5c1c04fb56 to ccd51a7f5880 (91 revisions) flutter/packages#7222

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

8a5fca6

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 26, 2024

Roll Flutter from 7d5c1c04fb56 to 7f8ad8a4cb1b (93 revisions) flutter/packages#7223

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

9c5e756

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 26, 2024

Roll Flutter from 7d5c1c04fb56 to 80cc52d7d1f6 (95 revisions) flutter/packages#7224

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

fb42d1f

…048)" (flutter/flutter#152248)

engine-flutter-autoroll mentioned this pull request Jul 26, 2024

Roll Flutter from 7d5c1c04fb56 to 031dc3d156b9 (97 revisions) flutter/packages#7225

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

9073fac

…048)" (flutter/flutter#152248)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

a887a8a

…048)" (flutter/flutter#152248)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

6f48a54

…048)" (flutter/flutter#152248)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

52b0efb

…048)" (flutter/flutter#152248)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2024

f64190a Reverts "Use more CORS headers for flutter run server (#152…

995ecdc

…048)" (flutter/flutter#152248)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Reverts "Use more CORS headers for `flutter run` server (#152048)" #152248

Reverts "Use more CORS headers for `flutter run` server (#152048)" #152248

Uh oh!

auto-submit bot commented Jul 24, 2024

Uh oh!

flutter-dashboard bot commented Jul 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reverts "Use more CORS headers for flutter run server (#152048)" #152248

Reverts "Use more CORS headers for flutter run server (#152048)" #152248

Uh oh!

Conversation

auto-submit bot commented Jul 24, 2024

Uh oh!

flutter-dashboard bot commented Jul 24, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Reverts "Use more CORS headers for `flutter run` server (#152048)" #152248

Reverts "Use more CORS headers for `flutter run` server (#152048)" #152248