[tool] guard remaining unguarded non-test stdin.writeln calls #152187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
added
the
tool
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
andrewkolos
force-pushed
the
guard-io-sink-writeln-in-flutter-analysis
branch
from
a24d29b to
0c6dc4b
Compare
andrewkolos
changed the title
andrewkolos
force-pushed
the
guard-io-sink-writeln-in-flutter-analysis
branch
from
37d48ef to
0fe852f
Compare
Contributor
Author
|
Closed to be superseded by a PR focusing on compile.dart changes. |
This reverts commit 2221331.
9 tasks
Merged
9 tasks
auto-submit bot
added a commit
that referenced
this pull request
Aug 7, 2024
…ompiler` (#152358)" (#153028) Reverts: #152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to #153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing #137184. Cleaned up version of earlier PR, #152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152358) Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…ompiler` (flutter#152358)" (flutter#153028) Reverts: flutter#152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to flutter#153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
DBowen33
pushed a commit
to DBowen33/flutter
that referenced
this pull request
Aug 16, 2024
…ompiler` (flutter#152358)" (flutter#153028) Reverts: flutter#152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to flutter#153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152358) Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…ompiler` (flutter#152358)" (flutter#153028) Reverts: flutter#152358 Initiated by: zanderso Reason for reverting: Speculative revert to determine whether this PR is related to flutter#153026 Original PR Author: andrewkolos Reviewed By: {christopherfujino} This change reverts the following previous change: Contributes to fixing flutter#137184. Cleaned up version of earlier PR, flutter#152187. This PR guards all the writes to `Process::stdin` by wrapping them with `ProcessUtils.writelnToStdinUnsafe`. This way, if any writes fail, we should at least get a stacktrace in our crash reporting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to fixing #137184
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.