reduce warnings inside flutter.groovy file #152073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
github-actions
bot
added
the
tool
Contributor
|
test-exempt: code refactor with no semantic change |
reidbaker
approved these changes
Aug 2, 2024
Contributor
|
Thank you for your contribution! |
bartekpacia
approved these changes
Aug 2, 2024
gmackall
approved these changes
Aug 5, 2024
gmackall
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 5, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Aug 5, 2024
flutter/flutter@cbfb222...3832823 2024-08-05 [email protected] Roll Packages from cc9ff47 to 82e8d1e (7 revisions) (flutter/flutter#152866) 2024-08-05 [email protected] reduce warnings inside flutter.groovy file (flutter/flutter#152073) 2024-08-05 [email protected] Roll Flutter Engine from 540c22589911 to 0aac60342005 (2 revisions) (flutter/flutter#152859) 2024-08-05 [email protected] Roll Flutter Engine from 16012e2f8ccd to 540c22589911 (4 revisions) (flutter/flutter#152854) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
In the context of [issue flutter#146036](flutter#146036), the flutter.groovy file, considering [issue flutter#147122](flutter#147122), currently has only two of the buildDir instances replaced. The other two instances have issues that require more investigation.
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
In the context of [issue flutter#146036](flutter#146036), the flutter.groovy file, considering [issue flutter#147122](flutter#147122), currently has only two of the buildDir instances replaced. The other two instances have issues that require more investigation.
9 tasks
thejitenpatel
pushed a commit
to thejitenpatel/flutter
that referenced
this pull request
Sep 26, 2024
9 tasks
9 tasks
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the context of issue #146036, the flutter.groovy file, considering issue #147122, currently has only two of the buildDir instances replaced. The other two instances have issues that require more investigation.
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.