Skip to content

Handle a WebSocketException that may be thrown when closing the WebKit inspection protocol connection to Chrome #151997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jul 19, 2024
Merged

Handle a WebSocketException that may be thrown when closing the WebKit inspection protocol connection to Chrome #151997

auto-submit merged 1 commit into from
Jul 19, 2024

Conversation

@jason-simmons
Copy link
Member

@jason-simmons jason-simmons commented Jul 18, 2024

Noticed this happening on macOS when the tool tries to shut down Chrome after all tabs have already been closed.

@jason-simmons
Handle a WebSocketException that may be thrown when closing the WebKi…
593637a 
…t inspection protocol connection to Chrome

Noticed this happening on macOS when the tool tries to shut down Chrome after all tabs have already been closed.
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 18, 2024
christopherfujino
christopherfujino approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2024
@auto-submit auto-submit bot merged commit 49a3152 into flutter:master Jul 19, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
2f800b4 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 19, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
305c22b 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 20, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
4c3d0ba 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
88abab6 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 21, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 21, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
5a58208 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
a689526 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
9ab86bb 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 22, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 22, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
df831a1 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
a686586 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
06879da 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 23, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 23, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
fbfbbdb 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
8a992d3 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
fb23864 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
4163faf 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
1775091 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 24, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
8e5a1f8 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
e5971c0 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
fdb060a 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
eb470a1 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
a4dbdf5 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 25, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
4e985ef 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
4d61176 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
aa5c300 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
59e9dab 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 26, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
996dfa3 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
1709f5b 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 27, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
1ecdd1b 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
0cbd0d0 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 28, 2024
@engine-flutter-autoroll
49a3152 Handle a WebSocketException that may be thrown when closing t…
077b450 
…he WebKit inspection protocol connection to Chrome (flutter/flutter#151997)
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@jason-simmons @TytaniumDev
Handle a WebSocketException that may be thrown when closing the WebKi…
4520881 
…t inspection protocol connection to Chrome (flutter#151997)

Noticed this happening on macOS when the tool tries to shut down Chrome after all tabs have already been closed.
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@jason-simmons @Buchimi
Handle a WebSocketException that may be thrown when closing the WebKi…
c09efa4 
…t inspection protocol connection to Chrome (flutter#151997)

Noticed this happening on macOS when the tool tries to shut down Chrome after all tabs have already been closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jason-simmons @christopherfujino