Skip to content

Conversation

@goderbauer
Copy link
Member

Part of #150800.

@goderbauer goderbauer requested a review from srawlins July 18, 2024 12:45
@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!).

If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix?

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: scrolling Viewports, list views, slivers, etc. labels Jul 18, 2024
@goderbauer goderbauer force-pushed the renderingdocimports branch from 7f4dfbe to 04959f7 Compare July 18, 2024 12:52
@stuartmorgan-g
Copy link
Contributor

test-exempt: Conceptually a comments-only change, just not recognized as such due to the library directives.

@goderbauer goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 19, 2024
@auto-submit auto-submit bot merged commit 94de6fd into flutter:master Jul 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
LouiseHsu pushed a commit to flutter/packages that referenced this pull request Jul 20, 2024
Roll Flutter from 58068d8 to 7d5c1c0 (104 revisions)

flutter/flutter@58068d8...7d5c1c0

2024-07-19 [email protected] Enhances
intuitiveness of RawMagnifier's example (flutter/flutter#150308)
2024-07-19 [email protected]
Roll pub packages (flutter/flutter#151992)
2024-07-19 [email protected] Add test for
scrollbar.1.dart (flutter/flutter#151463)
2024-07-19 [email protected] Roll Flutter Engine from
ea1e53a4e810 to 969fb7abc449 (3 revisions) (flutter/flutter#152018)
2024-07-19 [email protected] docimports for rendering library
(flutter/flutter#151958)
2024-07-19 [email protected] Roll Flutter Engine from
b65c93ea948e to ea1e53a4e810 (2 revisions) (flutter/flutter#152012)
2024-07-19 [email protected] painting: drop deprecated
(exported) hashList and hashValues functions (flutter/flutter#151677)
2024-07-18 [email protected] Roll Flutter Engine from
766f7bed7185 to b65c93ea948e (2 revisions) (flutter/flutter#152004)
2024-07-18 [email protected] Update TESTOWNERS (flutter/flutter#151907)
2024-07-18 [email protected] chore: fix test name & add description of
tests (flutter/flutter#151959)
2024-07-18 [email protected] Roll Flutter Engine from
564ded4c4742 to 766f7bed7185 (2 revisions) (flutter/flutter#151998)
2024-07-18 [email protected] Fix SelectionArea scrolling
conflicts (flutter/flutter#151138)
2024-07-18 [email protected] Fix:
BaseTapAndDragGestureRecognizer should reset drag state after losing
gesture arena (flutter/flutter#151989)
2024-07-18 [email protected]
Roll pub packages (flutter/flutter#151975)
2024-07-18 [email protected] Roll Flutter Engine from
8bcf638eb893 to 564ded4c4742 (2 revisions) (flutter/flutter#151986)
2024-07-18 [email protected] Fix
WidgetStateTextStyle's doc (flutter/flutter#151935)
2024-07-18 [email protected] Roll Flutter Engine from
d58ba74250ce to 8bcf638eb893 (2 revisions) (flutter/flutter#151977)
2024-07-18 [email protected] Adds 3.22.3 changelog
(flutter/flutter#151974)
2024-07-18 [email protected] Roll Packages from
d03b1b4 to c7f0526 (8 revisions) (flutter/flutter#151971)
2024-07-18 [email protected] `WidgetState` mapping
(flutter/flutter#146043)
2024-07-18 [email protected] Fix AppBar doc to keep diagram next to its
description (flutter/flutter#151937)
2024-07-18 [email protected] Small fixes to Image docs: NNBD, and add a
cross-reference (flutter/flutter#151938)
2024-07-18 [email protected] Roll Flutter Engine from
b043fe447bb3 to d58ba74250ce (1 revision) (flutter/flutter#151964)
2024-07-18 [email protected]
Roll pub packages (flutter/flutter#151946)
2024-07-18 [email protected]
Roll pub packages (flutter/flutter#151904)
2024-07-18 [email protected] Roll Flutter Engine from
e3abca2d8105 to b043fe447bb3 (1 revision) (flutter/flutter#151942)
2024-07-18 [email protected] Roll Flutter Engine from
8073523b4623 to e3abca2d8105 (1 revision) (flutter/flutter#151936)
2024-07-18 [email protected] Roll Flutter Engine from
dfe22e3acc19 to 8073523b4623 (1 revision) (flutter/flutter#151934)
2024-07-18 [email protected] Roll Flutter Engine from
184c3f0de6b3 to dfe22e3acc19 (1 revision) (flutter/flutter#151930)
2024-07-18 [email protected] Roll Flutter Engine from
00f0f6b74da7 to 184c3f0de6b3 (1 revision) (flutter/flutter#151928)
2024-07-18 [email protected] Roll Flutter Engine from
d194a2f0e5da to 00f0f6b74da7 (1 revision) (flutter/flutter#151927)
2024-07-18 [email protected] Roll Flutter Engine from
a5a93bb80bd1 to d194a2f0e5da (3 revisions) (flutter/flutter#151925)
2024-07-17 [email protected] Roll Flutter Engine from
e9dc62074c2b to a5a93bb80bd1 (1 revision) (flutter/flutter#151918)
2024-07-17 [email protected] [web] use the new backlog Github project
in triage links (flutter/flutter#151920)
2024-07-17 [email protected] Update Flutter-Web-Triage.md
(flutter/flutter#151607)
2024-07-17 [email protected] Reland fix InputDecorator hint default
text style on M3 (flutter/flutter#150835)
2024-07-17 [email protected] Roll Flutter Engine from
39ee1a549581 to e9dc62074c2b (3 revisions) (flutter/flutter#151915)
2024-07-17 [email protected] Constrain `CupertinoContextMenu`
animation to safe area (flutter/flutter#151860)
2024-07-17 [email protected] Create
`CarouselView` widget - Part 2 (flutter/flutter#149775)
2024-07-17 [email protected] Roll Flutter Engine from
45b722b661f0 to 39ee1a549581 (3 revisions) (flutter/flutter#151905)
2024-07-17 [email protected] docs: Fix typo
in data driven fixes test folder section (flutter/flutter#151836)
2024-07-17 [email protected] Stop running flaky mac
tests in presubmit (flutter/flutter#151870)
2024-07-17 [email protected] Roll Flutter Engine from
7e2579634027 to 45b722b661f0 (1 revision) (flutter/flutter#151895)
2024-07-17 [email protected] fix(Flutter Web
App): fixes html lang typo (flutter/flutter#151866)
2024-07-17 [email protected] Delete `docs/engine`
directory (flutter/flutter#151616)
2024-07-17 [email protected] Make
`CupertinoSlidingSegmentedControl` type parameter non-null
(flutter/flutter#151803)
...
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App f: scrolling Viewports, list views, slivers, etc. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants