Skip to content

Remove conditionality in templates that was for AGP <= 4.2 support #151845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 2 commits into from
Jul 16, 2024
Merged

Remove conditionality in templates that was for AGP <= 4.2 support #151845

auto-submit merged 2 commits into from
Jul 16, 2024

Conversation

@gmackall
Copy link
Member

@gmackall gmackall commented Jul 16, 2024 •
edited
Loading

Not needed after #149204 (as long as nothing has changed since the comment was made 🙂).

Fixes #145105.

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 16, 2024
@gmackall gmackall marked this pull request as ready for review July 16, 2024 18:47
@flutter-dashboard

This comment was marked as resolved.

Sign in to view
@gmackall gmackall requested a review from a team July 16, 2024 20:27
@gmackall gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 16, 2024
@auto-submit auto-submit bot merged commit 8c5fbb4 into flutter:master Jul 16, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
4ef7ba4 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
cb0227e 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
b8ee451 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
231e356 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
f6fea56 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
47bf881 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
d9c1574 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
132f1b9 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
b7dc769 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
4fc2b29 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
44bb095 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
387c993 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
b43076b 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
be722be 
…pport (flutter/flutter#151845)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 18, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
a5fc01f 
…pport (flutter/flutter#151845)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
a77883e 
…pport (flutter/flutter#151845)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
25245e7 
…pport (flutter/flutter#151845)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
c177280 
…pport (flutter/flutter#151845)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
f9c4e78 
…pport (flutter/flutter#151845)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
8c5fbb4 Remove conditionality in templates that was for AGP <= 4.2 su…
9c36e38 
…pport (flutter/flutter#151845)
TytaniumDev pushed a commit to TytaniumDev/flutter that referenced this pull request Aug 7, 2024
@gmackall @TytaniumDev
Remove conditionality in templates that was for AGP <= 4.2 support (f…
de1c0f0 
…lutter#151845)

Not needed after flutter#149204 (as long as nothing has changed since the comment was made �).

Fixes flutter#145105.
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@gmackall @Buchimi
Remove conditionality in templates that was for AGP <= 4.2 support (f…
1c88810 
…lutter#151845)

Not needed after flutter#149204 (as long as nothing has changed since the comment was made �).

Fixes flutter#145105.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reidbaker reidbaker reidbaker approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove conditionality for agp 4.2 in our Gradle templates

2 participants

@gmackall @reidbaker