Skip to content

Conversation

@christopherfujino
Copy link
Contributor

No description provided.

@flutter-dashboard
Copy link

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@christopherfujino
Copy link
Contributor Author

Once flutter/engine#53686 has merged and artifacts are published I will roll that hash here.

It's expected we will require an additional wasm cherrypick because of a Dart SDK cherrypick.

…wasm (flutter#149996)

Dart2Wasm doesn't officially support `dart:ffi` (only a small sketchy
subset needed in flutter web engine). We have seen user reporting issues
where existing packages don't work with dart2wasm due to using
`dart.library.ffi` in `bool.fromEnvironment` or in conditional imports
and it doing the wrong thing. So we're going to make `dart.library.ffi`
`false` in the compiler.

We therefore update the code to detect whether it runs under wasm via a
new `dart.tool.dart2wasm` environment variable.

This is a preparation for the change in dart2wasm which will start
making `const bool.fromEnvironment('dart.library.ffi')` return `false`
instead of `true`.
@github-actions github-actions bot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 12, 2024
@github-actions github-actions bot added the engine flutter/engine related. See also e: labels. label Jul 16, 2024
Copy link
Contributor

@itsjustkevin itsjustkevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Due to moving the release notes from the wiki to docs within the SDK, we should utilize the framework PR to update hotfixes-to-the-stable-channel.

@christopherfujino
Copy link
Contributor Author

LGTM

Due to moving the release notes from the wiki to docs within the SDK, we should utilize the framework PR to update hotfixes-to-the-stable-channel.

You mean this PR? If so, then that SGTM, I would just recommend we wait to push the commit until all the presubmits finish, in case there are failures that I can get started on addressing.

@itsjustkevin itsjustkevin added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 17, 2024
@auto-submit auto-submit bot merged commit b0850be into flutter:flutter-3.22-candidate.0 Jul 17, 2024
@christopherfujino christopherfujino deleted the cherrypicks-flutter-3.22-candidate.0 branch July 17, 2024 19:54
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
ZiadSala7 pushed a commit to ZiadSala7/flutter that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants