-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[flutter_releases] Flutter stable 3.22.3 Framework Cherrypicks #151687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_releases] Flutter stable 3.22.3 Framework Cherrypicks #151687
Conversation
|
This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter. Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed. |
|
Once flutter/engine#53686 has merged and artifacts are published I will roll that hash here. It's expected we will require an additional wasm cherrypick because of a Dart SDK cherrypick. |
…wasm (flutter#149996) Dart2Wasm doesn't officially support `dart:ffi` (only a small sketchy subset needed in flutter web engine). We have seen user reporting issues where existing packages don't work with dart2wasm due to using `dart.library.ffi` in `bool.fromEnvironment` or in conditional imports and it doing the wrong thing. So we're going to make `dart.library.ffi` `false` in the compiler. We therefore update the code to detect whether it runs under wasm via a new `dart.tool.dart2wasm` environment variable. This is a preparation for the change in dart2wasm which will start making `const bool.fromEnvironment('dart.library.ffi')` return `false` instead of `true`.
itsjustkevin
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Due to moving the release notes from the wiki to docs within the SDK, we should utilize the framework PR to update hotfixes-to-the-stable-channel.
You mean this PR? If so, then that SGTM, I would just recommend we wait to push the commit until all the presubmits finish, in case there are failures that I can get started on addressing. |
No description provided.