Skip to content

Emit source maps for wasm in flutter build web --wasm #151643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkustermann merged 1 commit into from
Jul 13, 2024
Merged

Emit source maps for wasm in flutter build web --wasm #151643

mkustermann merged 1 commit into from
Jul 13, 2024

Conversation

@mkustermann
Copy link
Member

@mkustermann mkustermann commented Jul 12, 2024 •
edited
Loading

This will make

  • flutter run have source maps enabled by default
  • flutter build have source maps disabled by default

which mirrors what happens already today with the js compilers.

For local development this works quite well - even better than with dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler, see [1]

[0] flutter/flutter/issues/151641
[1] dart-lang/sdk/issues/56232

@mkustermann
Emit source maps for wasm in flutter build web --wasm
ce9d246 
This will make

* `flutter run` have source maps enabled by default
* `flutter build` have source maps disabled by default

which mirrors what happens already today with the js compilers.

For local development this works quite well. We do have some follow-up
items for source maps in dart2wasm compiler, see [0]

[0] dart-lang/sdk#56232
@github-actions github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 12, 2024
@mkustermann mkustermann mentioned this pull request Jul 12, 2024
Open
10 tasks
yjbanov
yjbanov approved these changes Jul 13, 2024
View reviewed changes
Copy link
Contributor

@yjbanov yjbanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkustermann mkustermann merged commit ee7e5ec into flutter:master Jul 13, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
6ca4cec 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 13, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 13, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
8728862 
…ter/flutter#151643)
kevmoo added a commit that referenced this pull request Jul 13, 2024
@kevmoo
tool/build/web: move source-maps CLI flag to "general" web section
f37bd34 
...now that wasm supports source maps (see #151643)
@kevmoo kevmoo mentioned this pull request Jul 13, 2024
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
c29cc5b 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 14, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 14, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
6e5cac3 
…ter/flutter#151643)
@mkustermann mkustermann mentioned this pull request Jul 15, 2024
Closed
auto-submit bot pushed a commit that referenced this pull request Jul 15, 2024
@kevmoo
tool/build/web: move source-maps CLI flag to "general" web section (#…
ec16c86 
…151722)

...now that wasm supports source maps (see #151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
48f7275 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
77cee7f 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
ff3b457 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
5f96646 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 15, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
ac25aaf 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 15, 2024
Closed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 16, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 16, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
b286038 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
4c743a2 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
7579c94 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
dd07b0c 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
66fc196 
…ter/flutter#151643)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jul 17, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
9fb5abf 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
551d93c 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
81c2f97 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 17, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
c764055 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
8cc6293 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
e99a0fe 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
30655d5 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
bd27d31 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
ca19dbd 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
aeaf234 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 18, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
6382e9a 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
6a81528 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
06e85c9 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
0b9d698 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
3b529cf 
…ter/flutter#151643)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 19, 2024
@engine-flutter-autoroll
ee7e5ec Emit source maps for wasm in flutter build web --wasm (flut…
448916a 
…ter/flutter#151643)
mkustermann added a commit to mkustermann/flutter that referenced this pull request Aug 12, 2024
@mkustermann
Emit source maps for wasm in flutter build web --wasm (flutter#151643)
4373066 
This will make

* `flutter run` have source maps enabled by default
* `flutter build` have source maps disabled by default

which mirrors what happens already today with the js compilers.

For local development this works quite well - even better than with
dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler,
see [1]

[0]
[flutter/issues/151641](flutter#151641)
[1]
[dart-lang/sdk/issues/56232](dart-lang/sdk#56232)
mkustermann added a commit to mkustermann/flutter that referenced this pull request Aug 12, 2024
@mkustermann
Emit source maps for wasm in flutter build web --wasm (flutter#151643)
a2522eb 
This will make

* `flutter run` have source maps enabled by default
* `flutter build` have source maps disabled by default

which mirrors what happens already today with the js compilers.

For local development this works quite well - even better than with
dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler,
see [1]

[0]
[flutter/issues/151641](flutter#151641)
[1]
[dart-lang/sdk/issues/56232](dart-lang/sdk#56232)
auto-submit bot pushed a commit that referenced this pull request Aug 13, 2024
@mkustermann
[CP Stable] Emit source maps for wasm in flutter build web --wasm (#…
ec5d407 
…151643) (#153310)

Cherry-pick request: #153308

Original CL:

This will make

* `flutter run` have source maps enabled by default
* `flutter build` have source maps disabled by default

which mirrors what happens already today with the js compilers.

For local development this works quite well - even better than with dart2js (see dart2js issues in [0]).
We do have some follow-up items for source maps in dart2wasm compiler, see [1]

[0] [/issues/151641](#151641)
[1] [dart-lang/sdk/issues/56232](dart-lang/sdk#56232)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yjbanov yjbanov yjbanov approved these changes

@eyebrowsoffire eyebrowsoffire Awaiting requested review from eyebrowsoffire

Assignees

No one assigned

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkustermann @yjbanov