-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Update CONTRIBUTING.md #151614
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CONTRIBUTING.md #151614
Conversation
Closes #150869. Pending the following: - flutter/.github#47 - #151614 - flutter/engine#53828 - flutter/engine#53829 The wiki backlinks and website have all been updated.
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #150869. Pending the following: - flutter/.github#47 - #151614 - flutter/engine#53828 - flutter/engine#53829 The wiki backlinks and website have all been updated to <https://github.com/flutter/engine/tree/main/docs>.
| presented. | ||
|
|
||
| 1. [Setting up your engine development environment](./docs/engine/contributing/Setting-up-the-Engine-development-environment.md), | ||
| 1. [Setting up your engine development environment]([./docs/engine/contributing/Setting-up-the-Engine-development-environment.md](https://github.com/flutter/engine/blob/main/docs/contributing/Setting-up-the-Engine-development-environment.md)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears to produce a broken link:
https://github.com/flutter/flutter/blob/master/%5B./docs/engine/contributing/Setting-up-the-Engine-development-environment.md%5D(https:/github.com/flutter/engine/blob/main/docs/contributing/Setting-up-the-Engine-development-environment.md)
Closes flutter#150869. Pending the following: - flutter/.github#47 - flutter#151614 - flutter/engine#53828 - flutter/engine#53829 The wiki backlinks and website have all been updated to <https://github.com/flutter/engine/tree/main/docs>.
Closes flutter#150869. Pending the following: - flutter/.github#47 - flutter#151614 - flutter/engine#53828 - flutter/engine#53829 The wiki backlinks and website have all been updated to <https://github.com/flutter/engine/tree/main/docs>.
Part of #150869.