Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range #151568

gmackall · 2024-07-10T22:26:24Z

Sets up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range.

Post submit only, because the suite takes ~30 minutes to run, and I expect it to be somewhat rare that we break only one of these versions (and therefore it doesn't get caught by existing presubmits).

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

...lutter_tools/test/integration.shard/android_java_17_dependency_version_range_build_test.dart

gmackall · 2024-07-30T21:53:31Z

Tested with

../../bin/cache/dart-sdk/bin/dart bin/test_runner.dart test -t android_java17_dependency_smoke_tests

from

//flutter/flutter/dev/devicelab

gmackall · 2024-07-30T22:00:48Z

dev/devicelab/lib/framework/apk_utils.dart

    ? null : 'Dependency file should have $expectedTarget as target. Instead found $contentSnapshot';
 }
+
+class VersionTuple {


This code is largely duplicated from the code that I also wrote in packages/flutter_tools/test/android_common.dart, with some changes to get it to run in the devicelab test harness.

It's sort of unfortunate that it is duplicated, but I wanted to stop fragmenting the flutter_tool test suite even further than I already had, and also didn't feel that it made much sense for this suite to live inside the flutter_tool tests anyways at it largely isn't intended as a test of the tool, but of the dependencies we rely on to build Android apps.

Then it is especially important to document that this class is a duplicate and link to/from each implementation so that if improvements or fixes are made they can be applied to both.

This will be easier if the class is in its own file.

Moved to own file + added a comment in both files to suggest mirroring changes.

reidbaker · 2024-07-31T14:35:56Z

.ci.yaml


+  - name: Linux android_java11_dependency_smoke_tests
+    recipe: devicelab/devicelab_drone
+    presubmit: false


Is this presubmit false because this test is slow?

Yes, that was my intention

reidbaker · 2024-07-31T14:37:18Z

dev/devicelab/bin/tasks/android_java11_dependency_smoke_tests.dart

+import 'package:flutter_devicelab/framework/apk_utils.dart';
+import 'package:flutter_devicelab/framework/framework.dart';
+
+List<VersionTuple> versionTuples = <VersionTuple>[


Consider linking to the documentation for where we define the lowest supported versions and where we know that these versions are java 11 compatible.

Added a link to the file where we define range, and added a link to compatibility matrix explaining the choice of Java 11

reidbaker · 2024-07-31T14:38:14Z

dev/devicelab/bin/tasks/android_java17_dependency_smoke_tests.dart

+import 'package:flutter_devicelab/framework/apk_utils.dart';
+import 'package:flutter_devicelab/framework/framework.dart';
+
+// Methodology:


Good comment

reidbaker · 2024-07-31T14:39:03Z

dev/devicelab/lib/framework/apk_utils.dart

 ];

+
+const String gradleSettingsFileContent = r'''


Please add dart doc.

Also added dart docs to the main test methods

reidbaker · 2024-07-31T14:41:00Z

dev/devicelab/lib/framework/apk_utils.dart

    ? null : 'Dependency file should have $expectedTarget as target. Instead found $contentSnapshot';
 }
+
+class VersionTuple {


Then it is especially important to document that this class is a duplicate and link to/from each implementation so that if improvements or fixes are made they can be applied to both.

This will be easier if the class is in its own file.

gmackall · 2024-07-31T19:14:23Z

Addressed feedback, going to land this now and verify the targets start running correctly and aren't flakey. Will still be marked bringup for a while before I unmark. Any reviewers feel free to provide feedback after landing

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

Manual roll Flutter from 85960d2 to 4ff9462 (45 revisions) Manual roll requested by [email protected] flutter/flutter@85960d2...4ff9462 2024-08-01 [email protected] Fix local testing, gradle XML errors, and enable on CI. (flutter/flutter#152383) 2024-08-01 [email protected] Fix formatting issues in `search_anchor.0_test.dart` (flutter/flutter#152669) 2024-08-01 [email protected] Add tests for search anchor examples (flutter/flutter#152659) 2024-08-01 [email protected] Roll Flutter Engine from 4dc94d6f88ba to 7c4a44611abe (1 revision) (flutter/flutter#152665) 2024-08-01 [email protected] Roll Flutter Engine from f546fef7d7cd to 4dc94d6f88ba (1 revision) (flutter/flutter#152663) 2024-08-01 [email protected] Roll Flutter Engine from 0fbff219c498 to f546fef7d7cd (2 revisions) (flutter/flutter#152661) 2024-08-01 [email protected] Roll Flutter Engine from 32f788823f43 to 0fbff219c498 (5 revisions) (flutter/flutter#152658) 2024-08-01 [email protected] Manual roll Flutter Engine from 32f788823f43 to ed95b491f260 (3 revisions) (flutter/flutter#152654) 2024-08-01 [email protected] Manual roll Flutter Engine from 16332725788c to 32f788823f43 (11 revisions) (flutter/flutter#152648) 2024-07-31 [email protected] [CupertinoActionSheet] Make `_ActionSheetButtonBackground` stateless (flutter/flutter#152283) 2024-07-31 [email protected] Implementing null-aware logic in `/packages/flutter/` (flutter/flutter#152294) 2024-07-31 [email protected] Reintroduce verbose logging for hot reload flake (flutter/flutter#152639) 2024-07-31 [email protected] [material/menu_anchor.dart] Remove unused early key event listener (flutter/flutter#150915) 2024-07-31 [email protected] Improve `CupertinoCheckbox` fidelity (flutter/flutter#151441) 2024-07-31 [email protected] Update docs to support new Android version (flutter/flutter#152503) 2024-07-31 [email protected] [Android] Update integration test AVD dependency to use Android 35 emulators (flutter/flutter#152498) 2024-07-31 [email protected] Shift + click gesture support for SelectionArea on desktop platforms (flutter/flutter#148574) 2024-07-31 [email protected] Add ability to clip `Stepper` step content (flutter/flutter#152370) 2024-07-31 [email protected] Calendar font factor (flutter/flutter#152341) 2024-07-31 [email protected] Remove redundant usages of zones in skia_client.dart (flutter/flutter#149366) 2024-07-31 [email protected] Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range (flutter/flutter#151568) 2024-07-31 [email protected] remove bringup from Windows tool_integration_tests_* (flutter/flutter#152599) 2024-07-31 [email protected] â�¨ : Animation controller now has ability to repeat animation 'n' no. of times. (flutter/flutter#150764) 2024-07-31 [email protected] Roll Flutter Engine from 3b31b21599d1 to 16332725788c (1 revision) (flutter/flutter#152631) 2024-07-31 [email protected] Roll Flutter Engine from b73367a30e9b to 3b31b21599d1 (8 revisions) (flutter/flutter#152625) 2024-07-31 [email protected] Roll Packages from 99e8606 to 46a712f (8 revisions) (flutter/flutter#152622) 2024-07-31 [email protected] Add tests for scaffold messenger examples (flutter/flutter#152536) 2024-07-31 [email protected] Add test for search_anchor.0.dart (flutter/flutter#152371) 2024-07-31 [email protected] Use decoration hint text as the default value for dropdown button hints (flutter/flutter#152474) 2024-07-31 [email protected] Deprecate invalid InputDecoration.collapsed parameters (flutter/flutter#152486) 2024-07-31 [email protected] increase sharding on Windows tool_integration_tests (flutter/flutter#152582) 2024-07-31 [email protected] Roll Flutter Engine from e2ece7e58480 to b73367a30e9b (4 revisions) (flutter/flutter#152592) 2024-07-31 [email protected] Roll Flutter Engine from 0b42657a184e to e2ece7e58480 (2 revisions) (flutter/flutter#152589) 2024-07-31 [email protected] Roll Flutter Engine from 08f9be3ab284 to 0b42657a184e (2 revisions) (flutter/flutter#152586) 2024-07-30 [email protected] Clarify and cleanup the test-exemption wording in tree-hygiene. (flutter/flutter#152402) 2024-07-30 [email protected] [web] Set COEP:credentialless on flutter run/drive. (flutter/flutter#152413) 2024-07-30 [email protected] Roll Flutter Engine from a4b88a37d511 to 08f9be3ab284 (5 revisions) (flutter/flutter#152583) 2024-07-30 [email protected] Marks Mac platform_channel_sample_test_macos to be flaky (flutter/flutter#151884) 2024-07-30 [email protected] Roll Flutter Engine from a6c5ff26c266 to a4b88a37d511 (2 revisions) (flutter/flutter#152575) 2024-07-30 [email protected] Reland #151599 (Add button semantics in list tile ) with a flag to control behavior. (flutter/flutter#152526) 2024-07-30 [email protected] Shift macOS/Android tests from Pixel 7 to mokey in staging (flutter/flutter#152571) 2024-07-30 [email protected] Roll Flutter Engine from 31bb9f98472a to a6c5ff26c266 (5 revisions) (flutter/flutter#152573) 2024-07-30 [email protected] Roll Packages from 247fb5f to 99e8606 (5 revisions) (flutter/flutter#152567) 2024-07-30 [email protected] Fix default avatar icon theme size for Material 2 (flutter/flutter#152307) ...

…Gradle/AGP/Kotlin support range (flutter#151568) Sets up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range. Post submit only, because the suite takes ~30 minutes to run, and I expect it to be _somewhat_ rare that we break only one of these versions (and therefore it doesn't get caught by existing presubmits).

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 10, 2024

Gray Mackall added 3 commits July 10, 2024 15:31

set up test suite for gradle/agp/kotlin

cc7bef2

fix tests, give proper toString to the tuple

39c1512

fix tests

22326f1

gmackall force-pushed the gradle_agp_test_suite branch from f02f8e1 to 22326f1 Compare July 10, 2024 22:37

Gray Mackall and others added 3 commits July 10, 2024 16:30

fix exisitng android_dependency_version_checking_test.dart

c41c321

remove comment that is a lie

66c0880

Merge branch 'master' into gradle_agp_test_suite

42c6da2

gmackall commented Jul 11, 2024

View reviewed changes

...lutter_tools/test/integration.shard/android_java_17_dependency_version_range_build_test.dart Show resolved Hide resolved

gmackall and others added 11 commits July 29, 2024 09:55

Merge branch 'master' into gradle_agp_test_suite

ce79723

Merge branch 'master' into gradle_agp_test_suite

9905601

move out of tools_tests

3a2181f

remove dependency on flutter_tools test code

e6d11ce

delete unused code

b36ed5e

new line

383cc94

move yet again, this time to devicelab tests

536171d

remove from tests.dart

005bb32

ci.yaml

357fd42

undo temp commenting

0107022

Merge branch 'master' into gradle_agp_test_suite

657320e

Gray Mackall added 2 commits July 30, 2024 14:54

TESTOWNERS

7313052

missing import

b88c77e

gmackall commented Jul 30, 2024

View reviewed changes

gmackall marked this pull request as ready for review July 30, 2024 22:01

Gray Mackall added 2 commits July 30, 2024 17:42

small fixes

7396893

...test.dart -> ...tests.dart

7d026f6

gmackall requested a review from a team July 31, 2024 01:38

reidbaker requested a review from bartekpacia July 31, 2024 14:35

reidbaker approved these changes Jul 31, 2024

View reviewed changes

Gray Mackall added 2 commits July 31, 2024 09:47

second review piece

cef874e

more review + missed file

49a7cb4

gmackall added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 31, 2024

auto-submit bot merged commit a1f0360 into flutter:master Jul 31, 2024

engine-flutter-autoroll mentioned this pull request Aug 1, 2024

Roll Flutter from f817e51a3a34 to 7f4f1a0a6237 (74 revisions) flutter/packages#7275

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

3e7b66b

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 1, 2024

Roll Flutter from f817e51a3a34 to 4ff9462be814 (75 revisions) flutter/packages#7277

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

5116f1b

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 1, 2024

Roll Flutter from f817e51a3a34 to 735958ef9a56 (76 revisions) flutter/packages#7279

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

99ac8a0

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 1, 2024

Roll Flutter from f817e51a3a34 to 5edec61f0e6d (77 revisions) flutter/packages#7281

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

8287987

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 1, 2024

Roll Flutter from f817e51a3a34 to 619961d96cb1 (78 revisions) flutter/packages#7283

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 1, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

ec74d21

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 2, 2024

Roll Flutter from e2e43987c4fb to 8818e60a653b (89 revisions) flutter/packages#7290

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

cfd3344

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 2, 2024

Roll Flutter from e2e43987c4fb to 9cc5d7f44638 (91 revisions) flutter/packages#7291

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

1192216

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 2, 2024

Roll Flutter from e2e43987c4fb to f10a497e4abd (92 revisions) flutter/packages#7292

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

60bbc07

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 2, 2024

Roll Flutter from e2e43987c4fb to 6206d8d73e35 (93 revisions) flutter/packages#7293

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 2, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

3a339a8

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll mentioned this pull request Aug 3, 2024

Manual roll Flutter from 85960d24b9d2 to 4ff9462be814 (45 revisions) flutter/packages#7296

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 3, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

3eac134

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

f0bd95d

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024

a1f0360 Set up tests that verify we can build a fresh counter app acr…

2e337c0

…oss our Gradle/AGP/Kotlin support range (flutter/flutter#151568)

Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range #151568

Set up tests that verify we can build a fresh counter app across our Gradle/AGP/Kotlin support range #151568

Uh oh!

Conversation

gmackall commented Jul 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Uh oh!

gmackall commented Jul 30, 2024

Uh oh!

gmackall Jul 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gmackall commented Jul 31, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gmackall commented Jul 10, 2024 •

edited

Loading

gmackall Jul 30, 2024 •

edited

Loading