Fix Material 3 `Dialog` default background color #151400

TahaTesser · 2024-07-08T11:33:32Z

fixes [Material 3] Wrong Dialog background color from ColorScheme

Code sample

expand to view the code sample

import 'package:flutter/material.dart';

/// Flutter code sample for [showDialog].

void main() => runApp(const ShowDialogExampleApp());

class ShowDialogExampleApp extends StatelessWidget {
  const ShowDialogExampleApp({super.key});

  @override
  Widget build(BuildContext context) {
    return MaterialApp(
      home: const DialogExample(),
      theme: ThemeData(
        colorScheme: ColorScheme.fromSeed(
          seedColor: Colors.green,
          surfaceContainerHigh: Colors.amber,
        ),
      ),
    );
  }
}

class DialogExample extends StatelessWidget {
  const DialogExample({super.key});

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(title: const Text('showDialog Sample')),
      body: Center(
        child: OutlinedButton(
          onPressed: () => _dialogBuilder(context),
          child: const Text('Open Dialog'),
        ),
      ),
    );
  }

  Future<void> _dialogBuilder(BuildContext context) {
    return showDialog<void>(
      context: context,
      builder: (BuildContext context) {
        return AlertDialog(
          title: const Text('Basic dialog title'),
          content: const Text(
            'A dialog is a type of modal window that\n'
            'appears in front of app content to\n'
            'provide critical information, or prompt\n'
            'for a decision to be made.',
          ),
          actions: <Widget>[
            TextButton(
              style: TextButton.styleFrom(
                textStyle: Theme.of(context).textTheme.labelLarge,
              ),
              child: const Text('Disable'),
              onPressed: () {
                Navigator.of(context).pop();
              },
            ),
            TextButton(
              style: TextButton.styleFrom(
                textStyle: Theme.of(context).textTheme.labelLarge,
              ),
              child: const Text('Enable'),
              onPressed: () {
                Navigator.of(context).pop();
              },
            ),
          ],
        );
      },
    );
  }
}

Before

After

Pre-launch Checklist

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I signed the CLA.
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is test-exempt.
I followed the breaking change policy and added Data Driven Fixes where supported.
All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

flutter-dashboard · 2024-07-08T12:09:12Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #151400 at sha de7bd8b

flutter-dashboard · 2024-07-08T19:22:13Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #151400 at sha 6f070c7

QuncCccccc

Thanks for the fix! LGTM:)

packages/flutter/test/material/dialog_test.dart

packages/flutter/lib/src/material/dialog.dart

flutter-dashboard · 2024-07-09T12:15:15Z

Golden file changes are available for triage from new commit, Click here to view.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #151400 at sha 9c42461

QuncCccccc · 2024-07-09T16:03:52Z

This breaks some tests in Google testing. I'm creating a g3fix:)

TahaTesser · 2024-07-09T16:10:14Z

This breaks some tests in Google testing. I'm creating a g3fix:)

You're the best!

QuncCccccc · 2024-07-09T19:55:34Z

Got approval from internal team, so I just marked this as expected:)

…tter#151400)

@tool

Roll Flutter from 5103d75 to 58068d8 (42 revisions) flutter/flutter@5103d75...58068d8 2024-07-12 [email protected] Reland: Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151654) 2024-07-12 [email protected] Update obsolete comment in InputDecorator test (flutter/flutter#151651) 2024-07-12 [email protected] Fix `TabBar` tab indicator stretch effect (flutter/flutter#150868) 2024-07-12 [email protected] Remove workaround for a bug in dart2wasm (flutter/flutter#151603) 2024-07-12 [email protected] [native_assets] Stop running link hooks in JIT mode (flutter/flutter#151534) 2024-07-12 [email protected] Roll `Switch.adaptive` changes into `CupertinoSwitch` (flutter/flutter#149465) 2024-07-11 [email protected] Unmark java11 tests as bringup:true (flutter/flutter#151612) 2024-07-11 [email protected] Add link to design document archive (flutter/flutter#151489) 2024-07-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move all Linux Moto G4 tests to mokey in staging (#151608)" (flutter/flutter#151620) 2024-07-11 [email protected] Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151608) 2024-07-11 [email protected] docimports for API samples (flutter/flutter#151606) 2024-07-11 [email protected] docimports for flutter_goldens, flutter_localizations, flutter_web_plugins, fuchsia_remote_debug_protocol, integration_test (flutter/flutter#151271) 2024-07-11 [email protected] Re-enable debug canvaskit e2e tests. (flutter/flutter#151565) 2024-07-11 [email protected] Fix: Submenu anchor misaligned with child panel in web (Resolved #151081) (flutter/flutter#151294) 2024-07-11 [email protected] Replaced {@tool snippet} with {@tool dartpad} in CupertinoTabController (flutter/flutter#151272) 2024-07-11 [email protected] feat: Support overriding native endorsed plugins (flutter/flutter#137040) 2024-07-11 [email protected] expose keyboardType in DropdownMenu #150894 (flutter/flutter#150896) 2024-07-11 [email protected] docimports for flutter_driver (flutter/flutter#151267) 2024-07-11 [email protected] Add `TimeOfDay` comparison methods (flutter/flutter#151233) 2024-07-11 [email protected] Roll Flutter Engine from 6534fbf3c2c1 to 36dccf7bb25c (2 revisions) (flutter/flutter#151577) 2024-07-11 [email protected] Roll Flutter Engine from 1c23c8f64076 to 6534fbf3c2c1 (3 revisions) (flutter/flutter#151572) 2024-07-11 [email protected] Use correct locale for `CupertinoDatePicker` weekday (flutter/flutter#151494) 2024-07-10 [email protected] doc imports for enum values (flutter/flutter#151548) 2024-07-10 [email protected] Reland "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests"... but no longer upgrade module AGP version (flutter/flutter#151433) 2024-07-10 [email protected] Roll Packages from 14341d1 to ea35fc6 (16 revisions) (flutter/flutter#151556) 2024-07-10 [email protected] [CupertinoActionSheet] Fix padding and font size of buttons (flutter/flutter#151199) 2024-07-10 [email protected] Roll Flutter Engine from db2b45bea2c0 to 1c23c8f64076 (2 revisions) (flutter/flutter#151550) 2024-07-10 [email protected] Add docImports for flutter_test references (flutter/flutter#151175) 2024-07-10 [email protected] Mention not @-mentioning people in commit messages in tree hygiene (flutter/flutter#151487) 2024-07-10 [email protected] Roll Flutter Engine from 371db85f33d7 to db2b45bea2c0 (8 revisions) (flutter/flutter#151522) 2024-07-10 [email protected] fix heading level absorption, diagnostics; add tests and an a11y use-case (flutter/flutter#151421) 2024-07-10 [email protected] Roll Flutter Engine from 9d943eb2b37a to 371db85f33d7 (3 revisions) (flutter/flutter#151505) 2024-07-10 [email protected] Roll Flutter Engine from d3269d5855a7 to 9d943eb2b37a (5 revisions) (flutter/flutter#151495) 2024-07-09 [email protected] Update doc of `SemanticsProperties.identifier` (flutter/flutter#149915) 2024-07-09 [email protected] Clean up leaky test. (flutter/flutter#151131) 2024-07-09 [email protected] Roll pub packages (flutter/flutter#151492) 2024-07-09 [email protected] testAdd tests for stepper.controls_builder.0.dart (flutter/flutter#150669) 2024-07-09 [email protected] Add Semantics Property `linkUrl` (flutter/flutter#150639) 2024-07-09 [email protected] Roll Flutter Engine from 4a2ac0e51a8f to d3269d5855a7 (1 revision) (flutter/flutter#151488) 2024-07-09 [email protected] Link engine docs on AS setup in flutter/flutter docs on engine contributor setup (flutter/flutter#151481) 2024-07-09 [email protected] Roll Flutter Engine from 69075e7e87d4 to 4a2ac0e51a8f (21 revisions) (flutter/flutter#151482) 2024-07-09 [email protected] Fix Material 3 `Dialog` default background color (flutter/flutter#151400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...

…tter#151400)

github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: material design flutter/packages/flutter/material repository. labels Jul 8, 2024

TahaTesser marked this pull request as ready for review July 8, 2024 11:43

flutter-dashboard bot added the will affect goldens Changes to golden files label Jul 8, 2024

TahaTesser requested a review from QuncCccccc July 8, 2024 13:06

TahaTesser force-pushed the fix_m3_dialog_background_color branch from de7bd8b to 5290ba9 Compare July 8, 2024 13:44

TahaTesser changed the title ~~Fix Material Dialog default background color~~ Fix Material 3 Dialog default background color Jul 8, 2024

QuncCccccc approved these changes Jul 8, 2024

View reviewed changes

packages/flutter/test/material/dialog_test.dart Show resolved Hide resolved

packages/flutter/lib/src/material/dialog.dart Show resolved Hide resolved

TahaTesser added 3 commits July 9, 2024 10:15

Fix Material 3 Dialog default background color

d475571

Kick tests

be6e000

Address feedback

5c270b7

TahaTesser force-pushed the fix_m3_dialog_background_color branch from 6f070c7 to 5c270b7 Compare July 9, 2024 08:07

Kick tests

9c42461

QuncCccccc added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 9, 2024

auto-submit bot merged commit 850d76d into flutter:master Jul 9, 2024

engine-flutter-autoroll mentioned this pull request Jul 10, 2024

Roll Flutter from 5103d7574361 to 515c52679b41 (13 revisions) flutter/packages#7092

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 10, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

94c24c9

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 10, 2024

Roll Flutter from 5103d7574361 to 32c0c39ea5d8 (14 revisions) flutter/packages#7093

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 10, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

1fa4541

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 10, 2024

Roll Flutter from 5103d7574361 to 32c0c39ea5d8 (14 revisions) flutter/packages#7095

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 10, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

0fede2a

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 10, 2024

Roll Flutter from 5103d7574361 to 43458fe8e570 (15 revisions) flutter/packages#7096

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 10, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

e79e444

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 10, 2024

Manual roll Flutter from 5103d7574361 to a1bd8434b555 (20 revisions) flutter/packages#7098

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 10, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

9748dbf

…tter#151400)

ditman mentioned this pull request Jul 10, 2024

Manual roll Flutter to 58068d8ea4ec (42 revisions) flutter/packages#7099

Merged

11 tasks

TahaTesser deleted the fix_m3_dialog_background_color branch July 11, 2024 12:31

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to ee0260b41aca (23 revisions) flutter/packages#7101

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

f477c2a

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to defdb958ff24 (24 revisions) flutter/packages#7102

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

3d4894d

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to 90025e29645b (26 revisions) flutter/packages#7103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

3c65f5e

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to d55a5f96c117 (27 revisions) flutter/packages#7104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

2ca18d5

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to bf6c455d4a7a (41 revisions) flutter/packages#7109

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

0c84bf0

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 58068d8ea4ec (42 revisions) flutter/packages#7110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

f7ccf06

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to e47c83729075 (43 revisions) flutter/packages#7111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

cd7a1f8

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 68f375fe3871 (44 revisions) flutter/packages#7112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

e65b643

…tter#151400)

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 607190448b1c (45 revisions) flutter/packages#7113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

850d76d Fix Material 3 Dialog default background color (flutter/flu…

1003719

…tter#151400)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix Material 3 `Dialog` default background color #151400

Fix Material 3 `Dialog` default background color #151400

Uh oh!

TahaTesser commented Jul 8, 2024

Uh oh!

flutter-dashboard bot commented Jul 8, 2024

Uh oh!

flutter-dashboard bot commented Jul 8, 2024

Uh oh!

QuncCccccc left a comment

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Jul 9, 2024

Uh oh!

QuncCccccc commented Jul 9, 2024

Uh oh!

TahaTesser commented Jul 9, 2024

Uh oh!

QuncCccccc commented Jul 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix Material 3 Dialog default background color #151400

Fix Material 3 Dialog default background color #151400

Uh oh!

Conversation

TahaTesser commented Jul 8, 2024

Code sample

Before

After

Pre-launch Checklist

Uh oh!

flutter-dashboard bot commented Jul 8, 2024

Uh oh!

flutter-dashboard bot commented Jul 8, 2024

Uh oh!

QuncCccccc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

flutter-dashboard bot commented Jul 9, 2024

Uh oh!

QuncCccccc commented Jul 9, 2024

Uh oh!

TahaTesser commented Jul 9, 2024

Uh oh!

QuncCccccc commented Jul 9, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Fix Material 3 `Dialog` default background color #151400

Fix Material 3 `Dialog` default background color #151400