docimports for flutter_driver #151267

goderbauer · 2024-07-03T21:05:43Z

gspencergoog

auto-submit · 2024-07-03T23:57:19Z

auto label is removed for flutter/flutter/151267, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label.

srawlins · 2024-07-04T00:49:34Z

packages/flutter_driver/lib/src/driver/frame_request_pending_latency_summarizer.dart

 const String kFrameRequestPendingEvent = 'Frame Request Pending';

-/// Summarizes [TimelineEvents]s corresponding to [kFrameRequestPendingEvent] events.
+/// Summarizes [TimelineEvent]s corresponding to [kFrameRequestPendingEvent] events.


Love all these finds

goderbauer · 2024-07-08T16:34:27Z

google testing is failing on:

Target of URI doesn't exist. #uri_does_not_exist

/// @docImport 'package:flutter/foundation.dart';

So, submitting this has to wait on getting that warning ignored in google3.

gspencergoog · 2024-07-08T16:38:23Z

google testing is failing on:
Target of URI doesn't exist. #uri_does_not_exist

/// @docImport 'package:flutter/foundation.dart';
So, submitting this has to wait on getting that warning ignored in google3.

I think we already rewrite regular imports there when we roll. Perhaps it should also rewrite @docImports?

goderbauer · 2024-07-10T18:37:20Z

@srawlins This is strange. Google testing was in the clear for #151175. But on this change it still complains about non-existing URIs:

Target of URI doesn't exist: 'package:flutter_test/flutter_test.dart'. #uri_does_not_exist_in_doc_import

/// @docImport 'package:flutter_test/flutter_test.dart';
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

It's not clear to me how the docimports added by this change are any different to the ones added in #151175.

srawlins · 2024-07-11T14:45:37Z

This will require cl/651406900.

@tool

Roll Flutter from 5103d75 to 58068d8 (42 revisions) flutter/flutter@5103d75...58068d8 2024-07-12 [email protected] Reland: Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151654) 2024-07-12 [email protected] Update obsolete comment in InputDecorator test (flutter/flutter#151651) 2024-07-12 [email protected] Fix `TabBar` tab indicator stretch effect (flutter/flutter#150868) 2024-07-12 [email protected] Remove workaround for a bug in dart2wasm (flutter/flutter#151603) 2024-07-12 [email protected] [native_assets] Stop running link hooks in JIT mode (flutter/flutter#151534) 2024-07-12 [email protected] Roll `Switch.adaptive` changes into `CupertinoSwitch` (flutter/flutter#149465) 2024-07-11 [email protected] Unmark java11 tests as bringup:true (flutter/flutter#151612) 2024-07-11 [email protected] Add link to design document archive (flutter/flutter#151489) 2024-07-11 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Move all Linux Moto G4 tests to mokey in staging (#151608)" (flutter/flutter#151620) 2024-07-11 [email protected] Move all Linux Moto G4 tests to mokey in staging (flutter/flutter#151608) 2024-07-11 [email protected] docimports for API samples (flutter/flutter#151606) 2024-07-11 [email protected] docimports for flutter_goldens, flutter_localizations, flutter_web_plugins, fuchsia_remote_debug_protocol, integration_test (flutter/flutter#151271) 2024-07-11 [email protected] Re-enable debug canvaskit e2e tests. (flutter/flutter#151565) 2024-07-11 [email protected] Fix: Submenu anchor misaligned with child panel in web (Resolved #151081) (flutter/flutter#151294) 2024-07-11 [email protected] Replaced {@tool snippet} with {@tool dartpad} in CupertinoTabController (flutter/flutter#151272) 2024-07-11 [email protected] feat: Support overriding native endorsed plugins (flutter/flutter#137040) 2024-07-11 [email protected] expose keyboardType in DropdownMenu #150894 (flutter/flutter#150896) 2024-07-11 [email protected] docimports for flutter_driver (flutter/flutter#151267) 2024-07-11 [email protected] Add `TimeOfDay` comparison methods (flutter/flutter#151233) 2024-07-11 [email protected] Roll Flutter Engine from 6534fbf3c2c1 to 36dccf7bb25c (2 revisions) (flutter/flutter#151577) 2024-07-11 [email protected] Roll Flutter Engine from 1c23c8f64076 to 6534fbf3c2c1 (3 revisions) (flutter/flutter#151572) 2024-07-11 [email protected] Use correct locale for `CupertinoDatePicker` weekday (flutter/flutter#151494) 2024-07-10 [email protected] doc imports for enum values (flutter/flutter#151548) 2024-07-10 [email protected] Reland "Upgrade template Gradle, App AGP, Module AGP, and Kotlin versions, and tests"... but no longer upgrade module AGP version (flutter/flutter#151433) 2024-07-10 [email protected] Roll Packages from 14341d1 to ea35fc6 (16 revisions) (flutter/flutter#151556) 2024-07-10 [email protected] [CupertinoActionSheet] Fix padding and font size of buttons (flutter/flutter#151199) 2024-07-10 [email protected] Roll Flutter Engine from db2b45bea2c0 to 1c23c8f64076 (2 revisions) (flutter/flutter#151550) 2024-07-10 [email protected] Add docImports for flutter_test references (flutter/flutter#151175) 2024-07-10 [email protected] Mention not @-mentioning people in commit messages in tree hygiene (flutter/flutter#151487) 2024-07-10 [email protected] Roll Flutter Engine from 371db85f33d7 to db2b45bea2c0 (8 revisions) (flutter/flutter#151522) 2024-07-10 [email protected] fix heading level absorption, diagnostics; add tests and an a11y use-case (flutter/flutter#151421) 2024-07-10 [email protected] Roll Flutter Engine from 9d943eb2b37a to 371db85f33d7 (3 revisions) (flutter/flutter#151505) 2024-07-10 [email protected] Roll Flutter Engine from d3269d5855a7 to 9d943eb2b37a (5 revisions) (flutter/flutter#151495) 2024-07-09 [email protected] Update doc of `SemanticsProperties.identifier` (flutter/flutter#149915) 2024-07-09 [email protected] Clean up leaky test. (flutter/flutter#151131) 2024-07-09 [email protected] Roll pub packages (flutter/flutter#151492) 2024-07-09 [email protected] testAdd tests for stepper.controls_builder.0.dart (flutter/flutter#150669) 2024-07-09 [email protected] Add Semantics Property `linkUrl` (flutter/flutter#150639) 2024-07-09 [email protected] Roll Flutter Engine from 4a2ac0e51a8f to d3269d5855a7 (1 revision) (flutter/flutter#151488) 2024-07-09 [email protected] Link engine docs on AS setup in flutter/flutter docs on engine contributor setup (flutter/flutter#151481) 2024-07-09 [email protected] Roll Flutter Engine from 69075e7e87d4 to 4a2ac0e51a8f (21 revisions) (flutter/flutter#151482) 2024-07-09 [email protected] Fix Material 3 `Dialog` default background color (flutter/flutter#151400) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages ...

github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jul 3, 2024

goderbauer requested a review from srawlins July 3, 2024 21:28

goderbauer force-pushed the docImports14 branch from 575afc7 to 26275bf Compare July 3, 2024 22:50

goderbauer requested a review from gspencergoog July 3, 2024 22:51

gspencergoog approved these changes Jul 3, 2024

View reviewed changes

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jul 3, 2024

srawlins approved these changes Jul 4, 2024

View reviewed changes

goderbauer force-pushed the docImports14 branch 2 times, most recently from d372bbf to 9a08645 Compare July 10, 2024 18:06

docimports for flutter_driver

7666787

goderbauer force-pushed the docImports14 branch from 9a08645 to 7666787 Compare July 11, 2024 17:07

goderbauer added the autosubmit Merge PR when tree becomes green via auto submit App label Jul 11, 2024

goderbauer merged commit b13f50a into flutter:master Jul 11, 2024

goderbauer deleted the docImports14 branch July 11, 2024 18:30

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to 90025e29645b (26 revisions) flutter/packages#7103

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

fdc2194

engine-flutter-autoroll mentioned this pull request Jul 11, 2024

Roll Flutter from 5103d7574361 to d55a5f96c117 (27 revisions) flutter/packages#7104

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 11, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

cba529c

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to bf6c455d4a7a (41 revisions) flutter/packages#7109

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

cd90b80

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 58068d8ea4ec (42 revisions) flutter/packages#7110

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

2b9ed42

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to e47c83729075 (43 revisions) flutter/packages#7111

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

4048912

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 68f375fe3871 (44 revisions) flutter/packages#7112

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

8b2fcef

engine-flutter-autoroll mentioned this pull request Jul 12, 2024

Roll Flutter from 5103d7574361 to 607190448b1c (45 revisions) flutter/packages#7113

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 12, 2024

b13f50a docimports for flutter_driver (flutter/flutter#151267)

96a3242

Piinks mentioned this pull request Jul 12, 2024

Flutter Framework Team: Notable Commits #121415

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

docimports for flutter_driver #151267

docimports for flutter_driver #151267

Uh oh!

goderbauer commented Jul 3, 2024

Uh oh!

gspencergoog left a comment

Uh oh!

auto-submit bot commented Jul 3, 2024

Uh oh!

srawlins Jul 4, 2024

Uh oh!

goderbauer commented Jul 8, 2024

Uh oh!

gspencergoog commented Jul 8, 2024

Uh oh!

goderbauer commented Jul 10, 2024

Uh oh!

srawlins commented Jul 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

docimports for flutter_driver #151267

docimports for flutter_driver #151267

Uh oh!

Conversation

goderbauer commented Jul 3, 2024

Uh oh!

gspencergoog left a comment

Choose a reason for hiding this comment

Uh oh!

auto-submit bot commented Jul 3, 2024

Uh oh!

srawlins Jul 4, 2024

Choose a reason for hiding this comment

Uh oh!

goderbauer commented Jul 8, 2024

Uh oh!

gspencergoog commented Jul 8, 2024

Uh oh!

goderbauer commented Jul 10, 2024

Uh oh!

srawlins commented Jul 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants