Roll Flutter Engine from 3456fee1a6b9 to ac5d60ed2eaa (6 revisions) #151139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engine-flutter-autoroll
added
the
autosubmit
fluttergithubbot
approved these changes
Jul 1, 2024
Contributor
|
auto label is removed for flutter/flutter/151139, due to - The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Jul 1, 2024
Reverts: #52023 Initiated by: eyebrowsoffire Reason for reverting: Causing issues in engine -> framework roll flutter/flutter#151139 Original PR Author: eyebrowsoffire Reviewed By: {ditman} This change reverts the following previous change: This changes CanvasKit and Skwasm to be compiled and loaded as ES6 modules instead of as vanilla script tags. Currently, the emscripten JS files try to register themselves with require.js or AMD module loading systems. We suspect this is causing issues (flutter/flutter#149565) with DDC's module loading system, which itself uses require.js. This is probably also the fix for flutter/flutter#147731
engine-flutter-autoroll
added
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/151139, due to - The status or check suite Mac plugin_test_ios has failed. Please fix the issues identified (or deflake) before re-applying this label.
|
auto-submit
bot
removed
the
autosubmit
Contributor
Author
|
Commit queue failed; closing this roll. |
engine-flutter-autoroll
deleted the
flutter-engine-flutter-autoroll-b69bffde-07e4-4fb7-9eee-46712224be23-1719870263
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/engine@3456fee...ac5d60e
2024-07-01 [email protected] Roll Skia from ae2b97d74812 to 8375bdc6e191 (3 revisions) (flutter/engine#53669)
2024-07-01 [email protected] Output .js files as ES6 modules. (flutter/engine#52023)
2024-07-01 [email protected] Roll Skia from a62bf018429c to ae2b97d74812 (3 revisions) (flutter/engine#53668)
2024-07-01 [email protected] [icu] Ignores the dir
flutter/third_party/icu/patches(flutter/engine#53667)2024-07-01 [email protected] [Impeller] track the sizes of all outstanding MTLTexture allocations and report per frame in MB, matching Vulkan implementation. (flutter/engine#53618)
2024-07-01 [email protected] Roll Dart SDK from 338c6d4fd9c5 to 21c08743ee4a (1 revision) (flutter/engine#53666)
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.
To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose
To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622
Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md