Skip to content

Conversation

@jason-simmons
Copy link
Member

With today's random test order (--test-randomize-ordering-seed=20240629) this test is failing due to stack overflows when run on Windows.

…rees

With today's random test order (--test-randomize-ordering-seed=20240629) this
test is failing due to stack overflows when run on Windows.
@jason-simmons jason-simmons requested a review from flar June 29, 2024 19:24
@jason-simmons jason-simmons marked this pull request as ready for review June 29, 2024 19:24
@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Jun 29, 2024
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jason-simmons jason-simmons added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 29, 2024
@auto-submit auto-submit bot merged commit 38af6be into flutter:master Jun 29, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 30, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jul 1, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jul 1, 2024
flutter/flutter@651a17d...99bb2ff

2024-07-01 [email protected] Roll Flutter Engine from 0d93da7e2fe1 to b57a044ed10f (1 revision) (flutter/flutter#151082)
2024-06-30 [email protected] Roll Flutter Engine from ad1343cfb99e to 0d93da7e2fe1 (9 revisions) (flutter/flutter#151062)
2024-06-29 [email protected] Reduce the depth used in a test that applies finders to deep widget trees (flutter/flutter#151049)
2024-06-29 [email protected] Roll Flutter Engine from f828363d03ff to ad1343cfb99e (3 revisions) (flutter/flutter#151016)
2024-06-29 [email protected] Add test for segmented_button.0.dart (flutter/flutter#150676)
2024-06-29 [email protected] Roll pub packages (flutter/flutter#151022)
2024-06-29 [email protected] Roll pub packages (flutter/flutter#150827)
2024-06-28 [email protected] Roll Flutter Engine from 2f7e9ab27493 to f828363d03ff (3 revisions) (flutter/flutter#151013)
2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.10 to 3.25.11 (flutter/flutter#151012)
2024-06-28 [email protected] [tool] when writing to openssl as a part of macOS/iOS code-signing, flush the stdin stream before closing it (flutter/flutter#150120)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024
…rees (flutter#151049)

With today's random test order (--test-randomize-ordering-seed=20240629) this test is failing due to stack overflows when run on Windows.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: tests "flutter test", flutter_test, or one of our tests autosubmit Merge PR when tree becomes green via auto submit App framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants