Skip to content

Load parent package config #150850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sigurdm merged 51 commits into from
Aug 20, 2024
Merged

Load parent package config #150850

sigurdm merged 51 commits into from
Aug 20, 2024

Conversation

@sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Jun 26, 2024 •
edited
Loading

Fixes #150196

@github-actions github-actions bot added a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems tool Affects the "flutter" command-line tool. See also t: labels. framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) a: internationalization Supporting other languages or locales. (aka i18n) f: scrolling Viewports, list views, slivers, etc. f: cupertino flutter/packages/flutter/cupertino repository d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos f: gestures flutter/packages/flutter/gestures repository. a: desktop Running on desktop f: integration_test The flutter/packages/integration_test plugin c: tech-debt Technical debt, code quality, testing, etc. labels Jun 26, 2024
@sigurdm sigurdm force-pushed the load_parent_package_config branch from 7c1e8ea to 7a95be2 Compare June 26, 2024 13:37
@github-actions github-actions bot removed a: tests "flutter test", flutter_test, or one of our tests a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. engine flutter/engine related. See also e: labels. a: animation Animation APIs labels Jun 26, 2024
@christopherfujino
Copy link
Contributor

christopherfujino commented Aug 13, 2024

Mostly nits, a few questions, but I think we can get this merged soon.

christopherfujino
christopherfujino approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM if you add the TODO to packages/flutter_tools/lib/src/commands/test.dart

andrewkolos
andrewkolos approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@andrewkolos andrewkolos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry for the silence.

@sigurdm sigurdm merged commit 1a2e25c into flutter:master Aug 20, 2024
sigurdm added a commit that referenced this pull request Aug 20, 2024
@sigurdm
Revert "Load parent package config (#150850)"
3c8fd92 
This reverts commit 1a2e25c.
@sigurdm sigurdm mentioned this pull request Aug 20, 2024
Merged
sigurdm added a commit that referenced this pull request Aug 20, 2024
@sigurdm
Revert "Load parent package config" (#153752)
276674e 
Reverts #150850

Seems we need a G3Fix
@sigurdm sigurdm mentioned this pull request Aug 20, 2024
Merged
sigurdm added a commit that referenced this pull request Aug 20, 2024
@sigurdm
Reland "Load parent package config" (#153754)
a9daf58 
Reverts #153752
Relands #150850

Now with attached g3fix
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
e5ac9ac
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
a4c42f5
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
6ae7b0d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
b8cfa19
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
b5769b6
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Aug 20, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
785252e
@andrewkolos andrewkolos mentioned this pull request Aug 20, 2024
Closed
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Aug 20, 2024
@engine-flutter-autoroll
Roll Flutter from 6a28048 to e7da16d (23 revisions) (#7459)
a655a3e 
flutter/flutter@6a28048...e7da16d

2024-08-20 [email protected] Fixes page.onPopInvoked type mismatches (flutter/flutter#153593)
2024-08-20 [email protected] When the app enters the detached state, clear the record of the last SystemChrome style sent to the host (flutter/flutter#153586)
2024-08-20 [email protected] Handle "Service connection disposed" error from VmService disconnecting while requests are outstanding (flutter/flutter#153714)
2024-08-20 [email protected] Roll Flutter Engine from ec775a3a645e to e10b07598091 (1 revision) (flutter/flutter#153764)
2024-08-20 [email protected] Roll Packages from 7c1a05c to 4d2d2e3 (6 revisions) (flutter/flutter#153763)
2024-08-20 [email protected] Roll Flutter Engine from 0ac9e97cc1c0 to ec775a3a645e (1 revision) (flutter/flutter#153761)
2024-08-20 [email protected] Reland "Load parent package config" (flutter/flutter#153754)
2024-08-20 [email protected] Roll Flutter Engine from 48d7b04674d9 to 0ac9e97cc1c0 (2 revisions) (flutter/flutter#153753)
2024-08-20 [email protected] Revert "Load parent package config" (flutter/flutter#153752)
2024-08-20 [email protected] Roll Flutter Engine from b0284aac7b4d to 48d7b04674d9 (1 revision) (flutter/flutter#153746)
2024-08-20 [email protected] Load parent package config (flutter/flutter#150850)
2024-08-20 [email protected] Roll Flutter Engine from 20b8a5c13742 to b0284aac7b4d (1 revision) (flutter/flutter#153743)
2024-08-20 [email protected] Roll Flutter Engine from 86f269bd5261 to 20b8a5c13742 (2 revisions) (flutter/flutter#153741)
2024-08-20 [email protected] Roll Flutter Engine from 5355c0b60e6e to 86f269bd5261 (4 revisions) (flutter/flutter#153739)
2024-08-20 [email protected] Roll Flutter Engine from 7dd71ff80d23 to 5355c0b60e6e (1 revision) (flutter/flutter#153734)
2024-08-20 [email protected] Roll Flutter Engine from 9d7e3a6b97d0 to 7dd71ff80d23 (4 revisions) (flutter/flutter#153733)
2024-08-19 [email protected] refactor material banner and fix focus issue (flutter/flutter#152646)
2024-08-19 [email protected] Roll Flutter Engine from 30ffbfaf6a06 to 9d7e3a6b97d0 (3 revisions) (flutter/flutter#153724)
2024-08-19 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.26.2 to 3.26.3 (flutter/flutter#153726)
2024-08-19 [email protected] Roll Flutter Engine from c5d23162bb9b to 30ffbfaf6a06 (1 revision) (flutter/flutter#153721)
2024-08-19 [email protected] Roll Flutter Engine from bf538a0a98b0 to c5d23162bb9b (1 revision) (flutter/flutter#153719)
2024-08-19 [email protected] Remove android stack_size_test (flutter/flutter#153695)
2024-08-19 [email protected] Roll Flutter Engine from e29b5529080d to bf538a0a98b0 (2 revisions) (flutter/flutter#153713)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@sigurdm @Buchimi
Load parent package config (flutter#150850)
fb95967 
Fixes flutter#150196
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@sigurdm @Buchimi
Revert "Load parent package config" (flutter#153752)
439097f 
Reverts flutter#150850

Seems we need a G3Fix
Buchimi pushed a commit to Buchimi/flutter that referenced this pull request Sep 2, 2024
@sigurdm @Buchimi
Reland "Load parent package config" (flutter#153754)
cfd0948 
Reverts flutter#153752
Relands flutter#150850

Now with attached g3fix
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 11, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
c16ad2d
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Dec 12, 2024
@engine-flutter-autoroll
1a2e25c Load parent package config (flutter/flutter#150850)
94a31a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkolos andrewkolos andrewkolos approved these changes

@jonasfj jonasfj Awaiting requested review from jonasfj

+1 more reviewer

@christopherfujino christopherfujino christopherfujino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: desktop Running on desktop tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adapt flutter tools to handle pub workspaces: