fix:: elevation and scrollUnderElevation depends on scrolling drawers on issue #120083 #150793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
Piinks
reviewed
Jun 27, 2024
Piinks
reviewed
Jul 2, 2024
Piinks
reviewed
Jul 11, 2024
Piinks
reviewed
Jul 11, 2024
Contributor
Piinks
left a comment
Piinks
left a comment
There was a problem hiding this comment.
Thank you for the update, I am still not sure this is the best way to resolve this issue. I think I recall @TahaTesser looking at this before. @TahaTesser do you have any thoughts on this? Or insight on your past investigation here?
Piinks
reviewed
Jul 11, 2024
Member
That's right, I attempted to this in https://github.com/flutter/flutter/pull/122600/files but we had to revert it| Calling |
Piinks
reviewed
Jul 17, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 31, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 1, 2024
… drawers on issue #120083 (flutter/flutter#150793)
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
… on issue flutter#120083 (flutter#150793) fixes flutter#120083 Description This PR addresses the following issues: - Resolves the unexpected scrolledUnderElevation trigger that occurs when scrolling within the Drawer and NavigationDrawer.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 3, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 4, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Sep 5, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 11, 2024
… drawers on issue #120083 (flutter/flutter#150793)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Dec 12, 2024
… drawers on issue #120083 (flutter/flutter#150793)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #120083
Description
This PR addresses the following issues:
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.