[tool] make ErrorHandlingFileSystem.deleteIfExists catch error code 3 (ERROR_PATH_NOT_FOUND on Windows)
#150741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkolos
added
the
tool
andrewkolos
commented
Jun 25, 2024
Comment on lines
+89
to
+90
| // This check will falsely match "3/ESRCH: No such process" on Linux/macOS, | ||
| // but this should be fine since this code should never come up here. |
Contributor
Author
There was a problem hiding this comment.
If this is a bit too smelly for your taste, please read #150736 (comment)
Contributor
There was a problem hiding this comment.
Why do you say "this code should never come up here"? Are you saying that we should never hit a "no such process" error on unix-like operating systems when calling deleteIfExists?
Contributor
Author
There was a problem hiding this comment.
(We talked about this in-person. I'm commenting here for posterity's sake). Yes, that's my hope. I'm assuming 3/ESRCH is never set by a file op. I'm assuming this code is used by Linux utilities that act on processes rather than files.
andrewkolos
changed the title
ErrorHandlingFileSystem.deleteIfExists catch error code 3 (ERROR_PATH_NOT_FOUND on Windows)ErrorHandlingFileSystem.deleteIfExists catch error code 3 (ERROR_PATH_NOT_FOUND on Windows)
andrewkolos
added
the
autosubmit
This comment was marked as outdated.
This comment was marked as outdated.
auto-submit
bot
removed
the
autosubmit
andrewkolos
added
the
autosubmit
andrewkolos
added
the
cp: stable
flutteractionsbot
pushed a commit
to flutteractionsbot/flutter
that referenced
this pull request
Jun 25, 2024
… 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter#150741) Resolves flutter#150736 FYI I plan to cherry-pick this
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 26, 2024
* master: (23 commits) Roll pub packages (flutter#150810) Remove reference to `MaterialApp` and `showCupertinoModalPopup` from `CupertinoAlertDialog` (flutter#150725) Read `AndroidManifest.xml` and emit `manifest-impeller-(enabled|disabled)` analytics (flutter#150791) [flutter_tools] Shut down Chromium cleanly using a command sent through the debug protocol (flutter#150645) Reland fix inputDecorator hint color on M3 (flutter#150278) Roll Flutter Engine from 62e0b5f9c340 to 94023d711db3 (7 revisions) (flutter#150797) Fix collapsed InputDecorator minimum height (flutter#150770) Add more warm up frame docs (flutter#150464) Roll pub packages (flutter#150739) Add `focusNode`, `focusColor`, `onFocusChange`, `autofocus` to `CupertinoButton` (flutter#150721) Document RenderObject._relayoutBoundary and its invariant; small refactors (flutter#150527) Roll Flutter Engine from 6313b1e5afd7 to 62e0b5f9c340 (1 revision) (flutter#150790) fix a typo (flutter#150682) Fix link in RenderObjectWidget doc comment (flutter#150600) Roll Flutter Engine from fbd92055f3a6 to 6313b1e5afd7 (1 revision) (flutter#150781) [tool] make `ErrorHandlingFileSystem.deleteIfExists` catch error code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter#150741) Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter#150779) Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter#150777) Reland Add tests for form_text_field.1.dart (flutter#150481) (flutter#150696) (flutter#150750) Add an example for CupertinoPopupSurface (flutter#150357) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 26, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 26, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 26, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 27, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 28, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
…ror code 3 (`ERROR_PATH_NOT_FOUND` on Windows) (flutter/flutter#150741)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #150736
FYI I plan to cherry-pick this
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.