Add test for segmented_button.0.dart #150676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
framework
bleroux
approved these changes
Jun 26, 2024
| await tester.pumpWidget( | ||
| const example.SegmentedButtonApp(), | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
Not sure it will be more readable, maybe use a helper to avoid repeating the verbose expect?
Suggested change
| void expectOneCalendarButton(example.Calendar period) { | |
| expect( | |
| find.byWidgetPredicate( | |
| (Widget widget) => widget is SegmentedButton<example.Calendar> && setEquals(widget.selected, <example.Calendar>{period}), | |
| ), | |
| findsOne, | |
| ); | |
| } | |
| expect(find.byWidgetPredicate( | ||
| (Widget widget) => widget is SegmentedButton<example.Calendar> && setEquals(widget.selected, const <example.Calendar>{example.Calendar.day}), | ||
| ), findsOne); | ||
|
|
|
|
||
| }); | ||
|
|
||
| testWidgets('Segmented button can be used for with a multiple selection', (WidgetTester tester) async { |
| import 'package:flutter_test/flutter_test.dart'; | ||
|
|
||
| void main() { | ||
| testWidgets('Segmented button can be used for with a single selection', (WidgetTester tester) async { |
Contributor
Author
|
Thank you for the review @bleroux, everything should be fixed in refactor: Use helper |
bleroux
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 29, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 30, 2024
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jul 1, 2024
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jul 1, 2024
flutter/flutter@651a17d...99bb2ff 2024-07-01 [email protected] Roll Flutter Engine from 0d93da7e2fe1 to b57a044ed10f (1 revision) (flutter/flutter#151082) 2024-06-30 [email protected] Roll Flutter Engine from ad1343cfb99e to 0d93da7e2fe1 (9 revisions) (flutter/flutter#151062) 2024-06-29 [email protected] Reduce the depth used in a test that applies finders to deep widget trees (flutter/flutter#151049) 2024-06-29 [email protected] Roll Flutter Engine from f828363d03ff to ad1343cfb99e (3 revisions) (flutter/flutter#151016) 2024-06-29 [email protected] Add test for segmented_button.0.dart (flutter/flutter#150676) 2024-06-29 [email protected] Roll pub packages (flutter/flutter#151022) 2024-06-29 [email protected] Roll pub packages (flutter/flutter#150827) 2024-06-28 [email protected] Roll Flutter Engine from 2f7e9ab27493 to f828363d03ff (3 revisions) (flutter/flutter#151013) 2024-06-28 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.10 to 3.25.11 (flutter/flutter#151012) 2024-06-28 [email protected] [tool] when writing to openssl as a part of macOS/iOS code-signing, flush the stdin stream before closing it (flutter/flutter#150120) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jul 8, 2024
Contributes to flutter#130459 It adds a test for - `examples/api/test/material/segmented_button/segmented_button.0_test.dart`
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #130459
It adds a test for
examples/api/test/material/segmented_button/segmented_button.0_test.dartPre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.