Skip to content

Conversation

@andrewkolos
Copy link
Contributor

Fixes #150575.

Also fixes #150665.
Also fixes #150663.

Pre-launch Checklist

@andrewkolos andrewkolos added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 23, 2024
@github-actions github-actions bot added a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically a: desktop Running on desktop labels Jun 23, 2024
@andrewkolos andrewkolos force-pushed the remove-usage-of-usage branch from ce672fb to ed3c7e1 Compare June 24, 2024 19:58
@andrewkolos andrewkolos force-pushed the remove-usage-of-usage branch from 7074df6 to 6bf9e6c Compare June 25, 2024 16:22
@andrewkolos
Copy link
Contributor Author

This will be succeeded by smaller PRs to make this change more reviewable.

@andrewkolos andrewkolos closed this Jul 1, 2024
auto-submit bot pushed a commit that referenced this pull request Jul 8, 2024
…unset) override by default (#151357)

While exploring #107607, I noticed that flutter_tools test results change based on whether `dart test` is run from a terminal or from a process (such as a Dart program). I also ran into this while writing tests for #150667.

This is due to tests that rely on the global `Stdio` instance, on which the `hasTerminal` property depends on whether the tool is being invoked from a terminal.

Ideally, `testUsingContext` would require any tests that depend on `globals.stdio` to define an override for `Stdio`, but this is not the case. Until a solution to this more general problem is figured out, I think we should have `testUsingContext` always provide a `Stdio` override by default.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: desktop Running on desktop a: text input Entering text in a text field or keyboard related problems platform-ios iOS applications specifically tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[tool] Stop using pkg:usage [tool] some tests test for sending GA3 analytics events but not GA4 [tool] TestBed doesn't include a stub for Analytics

1 participant