Remove discontinued device_info and connectivity plugins from flutter_gallery, roll pub packages
#150585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmackall
force-pushed
the
gallery_remove_discont_plugins
branch
from
34f0aaa to
f43891e
Compare
github-actions
bot
added
a: tests
gmackall
changed the title
device_info and connectivity plugins from flutter_gallerydevice_info and connectivity plugins from flutter_gallery, roll pub packages
gmackall
force-pushed
the
gallery_remove_discont_plugins
branch
from
e5e821a to
b52a574
Compare
Member
Author
|
Also rolls pub packages, because the I did as the line told me to and ran |
8 tasks
matanlurey
reviewed
Jun 21, 2024
Contributor
There was a problem hiding this comment.
Looks like this is causing an exception in tests:
The test description was:
Flutter Gallery app smoke test (variant: TargetPlatform.android)
════════════════════════════════════════════════════════════════════════════════════════════════════
02:34 +150 ~2 -2: /b/s/w/ir/x/w/flutter/dev/integration_tests/flutter_gallery/test/smoke_test.dart: Flutter Gallery app smoke test (variant: TargetPlatform.android) [E]
Test failed. See exception logs above.
The test description was: Flutter Gallery app smoke test (variant: TargetPlatform.android)
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following UnimplementedError was thrown running a test (but after the test had completed):
init() has not been implemented.
When the exception was thrown, this was the stack:
#0 VideoPlayerPlatform.init (package:video_player_platform_interface/video_player_platform_interface.dart:43:5)
Member
Author
There was a problem hiding this comment.
Interesting, the video demo works when I launch it. Perhaps this is intended?
https://docs.flutter.dev/testing/plugins-in-tests
Building and registering the host portion of a plugin is part of the Flutter application build process, so plugins only work when your code is running in your application, such as with flutter run or when running integration tests. When running Dart unit tests or widget tests, the host code isn't available.
and #131743
Need to see if so, and figure out why this was working before
Member
Author
There was a problem hiding this comment.
See the discussion starting at https://discord.com/channels/608014603317936148/608020293944082452/1253779719497842808.
Basically, the test would never get to video_player initialization before because it was blocked on loading the bee. Making the bee local fixed this, but in the process made the test now actually make it to video_player initialization and therefore fail.
So I've made the video demo only run in non-test Android and iOS environments.
added 2 commits
June 21, 2024 12:38
…ont_plugins' into gallery_remove_discont_plugins
matanlurey
approved these changes
Jun 21, 2024
gmackall
added
the
autosubmit
Member
Author
|
Lots of timeouts on mac bots recently |
Contributor
|
auto label is removed for flutter/flutter/150585, due to - The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 22, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 22, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 23, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 24, 2024
* master: (213 commits) Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves flutter#148291) (flutter#150661) [CupertinoActionSheet] Fix the layout (part 1) (flutter#149636) Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter#150585) [a11y] Update semantics in bottom_navigation_bar.dart (flutter#150576) Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter#150637) Reland 4: [CupertinoActionSheet] Match colors to native (flutter#150442) Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter#149295) made SelectionArea alignment consistent between web and other platform (flutter#150037) Fix link hook typo (flutter#150194) Stop looking for .packages when analyzing (flutter#150349) Update flutter.dev links from misc packages to more permanent destinations (flutter#150532) Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter#150582) Update Material token to the latest 4.1.0 (flutter#150382) Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter#150471) Make popup menu hardcoded padding configurable (flutter#150506) [flutter_tools] un-hide the --dds flag (flutter#150280) [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter#149586) Add test for inherited_notifier.0.dart (flutter#150344) [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter#150461) Test InputDecoration API examples (flutter#148560) ...
hello-coder-xu
added a commit
to hello-coder-xu/flutter
that referenced
this pull request
Jun 24, 2024
…ileTheme * master: (88 commits) Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves flutter#148291) (flutter#150661) [CupertinoActionSheet] Fix the layout (part 1) (flutter#149636) Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter#150585) [a11y] Update semantics in bottom_navigation_bar.dart (flutter#150576) Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter#150637) Reland 4: [CupertinoActionSheet] Match colors to native (flutter#150442) Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter#149295) made SelectionArea alignment consistent between web and other platform (flutter#150037) Fix link hook typo (flutter#150194) Stop looking for .packages when analyzing (flutter#150349) Update flutter.dev links from misc packages to more permanent destinations (flutter#150532) Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter#150582) Update Material token to the latest 4.1.0 (flutter#150382) Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter#150471) Make popup menu hardcoded padding configurable (flutter#150506) [flutter_tools] un-hide the --dds flag (flutter#150280) [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter#149586) Add test for inherited_notifier.0.dart (flutter#150344) [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter#150461) Test InputDecoration API examples (flutter#148560) ...
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 24, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 24, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
8 tasks
auto-submit bot
pushed a commit
to flutter/engine
that referenced
this pull request
Jun 24, 2024
Re-re-land #53001 (Reland attempt was at #53462) Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles. Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
8 tasks
auto-submit bot
added a commit
to flutter/engine
that referenced
this pull request
Jun 25, 2024
…t" (#53532)" (#53546) Reverts: #53532 Initiated by: gmackall Reason for reverting: This breaks apps that use plugins that use compileSdk 31, some of which we use in our postsubmit (so it blocks the tree). Original PR Author: gmackall Reviewed By: {reidbaker, matanlurey} This change reverts the following previous change: Re-re-land #53001 (Reland attempt was at #53462) Unblocked by flutter/flutter#150585, but will still need a manual roll because I will need to re-generate a bunch of lockfiles. Also, https://github.com/flutter/flutter/blob/master/docs/engine/Testing-presubmit-Engine-PRs-with-the-Flutter-framework.md doesn't work (it's blocked on flutter/flutter#149780) so I mostly just have to pray that no new issues occur in the roll. But I believe all issues that came up in the last attempt should be addressed by the above pr and by manual lockfile generation. [C++, Objective-C, Java style guides]: https://github.com/flutter/engine/blob/main/CONTRIBUTING.md#style
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 25, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 25, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 25, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 25, 2024
Roll Flutter from 6c06abb to e726eb4 (51 revisions) flutter/flutter@6c06abb...e726eb4 2024-06-25 [email protected] Roll Packages from 711b4ac to 03f5f6d (21 revisions) (flutter/flutter#150779) 2024-06-25 [email protected] Roll Flutter Engine from afa7ce19bca8 to fbd92055f3a6 (1 revision) (flutter/flutter#150777) 2024-06-25 [email protected] Reland Add tests for form_text_field.1.dart (#150481) (#150696) (flutter/flutter#150750) 2024-06-25 [email protected] Add an example for CupertinoPopupSurface (flutter/flutter#150357) 2024-06-25 [email protected] [flutter_tools/dap] Handle app.stop errors when launching/attaching (flutter/flutter#149734) 2024-06-25 [email protected] Roll Flutter Engine from be7db94196fe to afa7ce19bca8 (18 revisions) (flutter/flutter#150762) 2024-06-25 [email protected] Remove dubious comment (flutter/flutter#150608) 2024-06-25 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Manual engine roll to 6884e83 (#150733)" (flutter/flutter#150746) 2024-06-25 [email protected] Manual engine roll to 6884e83 (flutter/flutter#150733) 2024-06-24 [email protected] Linkify 'see also' sections (flutter/flutter#150734) 2024-06-24 [email protected] Roll pub packages (flutter/flutter#150712) 2024-06-24 [email protected] Update flutter.dev links from framework to more permanent destinations (flutter/flutter#150531) 2024-06-24 [email protected] Manual engine roll to be7db94196fe (flutter/flutter#150714) 2024-06-24 [email protected] allow adb to set canfail then use canFail=true for clearing logs (flutter/flutter#150517) 2024-06-24 [email protected] Update android_device.dart to have clearLogs not print to standard error (flutter/flutter#150197) 2024-06-24 [email protected] Update issue link in analysis_options.yaml (flutter/flutter#150395) 2024-06-24 [email protected] Fix a number of broken doc comment references (flutter/flutter#150540) 2024-06-24 [email protected] Fix flaky sliver tree test (flutter/flutter#150707) 2024-06-24 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Add tests for form_text_field.1.dart (#150481)" (flutter/flutter#150696) 2024-06-24 [email protected] Add tests for form_text_field.1.dart (flutter/flutter#150481) 2024-06-22 [email protected] Fix: Memory leak in UndoHistory widget because it never de-registered itself as global UndoManager client (Resolves #148291) (flutter/flutter#150661) 2024-06-22 [email protected] [CupertinoActionSheet] Fix the layout (part 1) (flutter/flutter#149636) 2024-06-21 [email protected] Remove discontinued `device_info` and `connectivity` plugins from `flutter_gallery`, roll pub packages (flutter/flutter#150585) 2024-06-21 [email protected] [a11y] Update semantics in bottom_navigation_bar.dart (flutter/flutter#150576) 2024-06-21 [email protected] Roll Flutter Engine from dda82d905f37 to 33415c6ee7c2 (7 revisions) (flutter/flutter#150637) 2024-06-21 [email protected] Reland 4: [CupertinoActionSheet] Match colors to native (flutter/flutter#150442) 2024-06-21 [email protected] Enable SelectionArea double tap/triple tap gesture support for mobile platforms (flutter/flutter#149295) 2024-06-21 [email protected] made SelectionArea alignment consistent between web and other platform (flutter/flutter#150037) 2024-06-21 [email protected] Fix link hook typo (flutter/flutter#150194) 2024-06-21 [email protected] Stop looking for .packages when analyzing (flutter/flutter#150349) 2024-06-20 [email protected] Update flutter.dev links from misc packages to more permanent destinations (flutter/flutter#150532) 2024-06-20 [email protected] Roll Flutter Engine from dd37cefd4a94 to dda82d905f37 (9 revisions) (flutter/flutter#150582) 2024-06-20 [email protected] Update Material token to the latest 4.1.0 (flutter/flutter#150382) 2024-06-20 [email protected] Let the lockfile script generate lockfiles for kotlin gradle files as well (flutter/flutter#150471) 2024-06-20 [email protected] Make popup menu hardcoded padding configurable (flutter/flutter#150506) 2024-06-20 [email protected] [flutter_tools] un-hide the --dds flag (flutter/flutter#150280) 2024-06-20 [email protected] [material/menu_anchor.dart] Remove _MenuAnchorState from parent when disposed. (flutter/flutter#149586) 2024-06-20 [email protected] Add test for inherited_notifier.0.dart (flutter/flutter#150344) 2024-06-20 [email protected] [CLI tool] in `flutter test`, consider `--flavor` when validating the cached asset bundle (flutter/flutter#150461) 2024-06-20 [email protected] Test InputDecoration API examples (flutter/flutter#148560) 2024-06-20 [email protected] Clean leaky tests. (flutter/flutter#150335) 2024-06-20 [email protected] Roll Flutter Engine from f9c497f178d3 to dd37cefd4a94 (2 revisions) (flutter/flutter#150537) 2024-06-20 [email protected] Roll Flutter Engine from a31279381b40 to f9c497f178d3 (9 revisions) (flutter/flutter#150528) 2024-06-19 [email protected] Add tests for about_list_tile.0.dart (flutter/flutter#150181) 2024-06-19 [email protected] Roll Flutter Engine from 0ad18fe4c0b5 to a31279381b40 (7 revisions) (flutter/flutter#150473) 2024-06-18 [email protected] Revert "[a11y] Add semantics: button to bottom navigation bar items and dropdown menu items" (flutter/flutter#150445) ...
sigurdm
pushed a commit
to sigurdm/flutter
that referenced
this pull request
Jun 26, 2024
…utter_gallery`, roll pub packages (flutter#150585) Removes these two discontinued plugins from `dev/integration_tests/flutter_gallery` [`device_info`](https://pub.dev/packages/device_info): Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README. [`connectivity`](https://pub.dev/packages/connectivity): This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin. Unblocks the re-land of flutter/engine#53462 (itself a reland ð���), because of flutter#150465 (comment).
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
…from `flutter_gallery`, roll pub packages (flutter/flutter#150585)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes these two discontinued plugins from
dev/integration_tests/flutter_gallerydevice_info:Apparently the video playback doesn't work on iOS simulators (I wasn't able to verify this, as I don't have an iOS simulator installed). I removed the guard against running on those simulators, and replaced with a note in the README.
connectivity:This plugin was used to play the bee video from the network. I changed the demo so that the bee video is instead also played from an asset (like its friend the butterfly), and then removed the use of the plugin.
Unblocks the re-land of flutter/engine#53462 (itself a reland 🙂), because of #150465 (comment).
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.