Fixes `flutter build ipa` failure: Command line name "app-store" is deprecated. Use "app-store-connect" #150407

LouiseHsu · 2024-06-18T05:25:53Z

Pre-launch Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I signed the [CLA].
I listed at least one issue that this PR fixes in the description above.
I updated/added relevant documentation (doc comments with ///).
I added new tests to check the change I am making, or this PR is [test-exempt].
I followed the [breaking change policy] and added [Data Driven Fixes] where supported.
All existing and new tests are passing.

jmagman · 2024-06-18T23:45:37Z

packages/flutter_tools/lib/src/commands/build_ios.dart

      help: 'Specify how the IPA will be distributed.',
      allowedHelp: <String, String>{
-        'app-store': 'Upload to the App Store.',
+        'app-store': 'Upload to the App Store. For XCode <= 15.3.',


XCode is cased "Xcode". Someday I'm going to make a linter for this...

Suggested change

'app-store': 'Upload to the App Store. For XCode <= 15.3.',

'app-store': 'Upload to the App Store. For Xcode <= 15.3.',

jmagman · 2024-06-18T23:46:42Z

packages/flutter_tools/lib/src/commands/build_ios.dart

      allowedHelp: <String, String>{
-        'app-store': 'Upload to the App Store.',
+        'app-store': 'Upload to the App Store. For XCode <= 15.3.',
+        'app-store-connect': 'Upload to the App Store. For XCode > 15.3',


Let's leave off the >15.3.

Suggested change

'app-store-connect': 'Upload to the App Store. For XCode > 15.3',

'app-store-connect': 'Upload to the App Store.',

removed the other options so i also removed the xcode part of the help, since not relevant anymore

jmagman · 2024-06-18T23:49:13Z

packages/flutter_tools/lib/src/commands/build_ios.dart

      'export-method',
      defaultsTo: 'app-store',
-      allowed: <String>['app-store', 'ad-hoc', 'development', 'enterprise'],
+      allowed: <String>['app-store', 'app-store-connect', 'ad-hoc', 'release-testing', 'development', 'debugging', 'enterprise'],


This pile is really confusing. Can we keep the old allowed list as-is, but pass the right thing into Xcode based on the version?

makes sense, done!

jmagman · 2024-06-21T16:53:31Z

packages/flutter_tools/lib/src/commands/build_ios.dart

+  String _getVersionAppropriateExportMethod(String method) {
+    final Version? currVersion = globals.xcode!.currentVersion;
+    if (currVersion != null) {
+      if (currVersion.major >= 16 || (currVersion.major == 15 && currVersion.minor > 3)) {


Version implements equality operators, this could be something like

Suggested change

if (currVersion.major >= 16 || (currVersion.major == 15 && currVersion.minor > 3)) {

if (currVersion >= Version(15, 4, 0)) {

ooh i missed that

jmagman · 2024-06-21T22:35:15Z

packages/flutter_tools/lib/src/commands/build_ios.dart

+          case 'app-store':
+            return 'app-store-connect';
+          case 'ad-hoc':
+            return 'release-testing';


Can you add tests for this?

flutter/packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart

Lines 618 to 619 in d4cffa2

<key>method</key>

<string>ad-hoc</string>

jmagman · 2024-06-21T22:43:56Z

packages/flutter_tools/test/commands.shard/hermetic/build_ipa_test.dart

    };
  }
+
+  Version _version = Version(14, 0, 0);


I think it would be cleaner to add to the constructor:

FakeXcodeProjectInterpreterWithBuildSettings({ this.overrides = const <String, String>{}, Version? version, }) : version = version ?? Version(14, 0, 0); ... @override final Version version;

saumon · 2024-06-26T08:04:37Z

🙏

flutter-dashboard · 2024-06-26T21:11:21Z

Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change).

If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review.

For more guidance, visit Writing a golden file test for package:flutter.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

Changes reported for pull request #150407 at sha d9fb228

jmagman · 2024-06-26T21:38:17Z

Took the liberty to rebase on main since there shouldn't be golden changes on this PR.

LouiseHsu · 2024-06-26T21:39:13Z

Took the liberty to rebase on main since there shouldn't be golden changes on this PR.

thank youuuuuuuu

auto-submit · 2024-06-26T21:52:08Z

auto label is removed for flutter/flutter/150407, due to - The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-06-26T22:37:40Z

auto label is removed for flutter/flutter/150407, due to - The status or check suite Linux build_tests_1_3 has failed. Please fix the issues identified (or deflake) before re-applying this label.

auto-submit · 2024-06-26T23:56:06Z

auto label is removed for flutter/flutter/150407, due to - The status or check suite Mac tool_integration_tests_1_4 has failed. Please fix the issues identified (or deflake) before re-applying this label.

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

Manual roll Flutter from e726eb4 to 15f95ce (48 revisions) Manual roll requested by [email protected] flutter/flutter@e726eb4...15f95ce 2024-06-28 [email protected] Roll Flutter Engine from ddd4814b9d40 to 94591ffb20df (5 revisions) (flutter/flutter#150968) 2024-06-27 [email protected] Manual engine roll to ddd4814 (flutter/flutter#150952) 2024-06-27 [email protected] local lint copy gradle task config (flutter/flutter#150957) 2024-06-27 [email protected] Roll Flutter Engine from b42c80460538 to d1506c12808e (3 revisions) (flutter/flutter#150951) 2024-06-27 [email protected] [tool] make the `systemTempDirectory` getter on `ErrorHandlingFileSystem` wrap the underlying filesystem's temp directory in a`ErrorHandlingDirectory` (flutter/flutter#150876) 2024-06-27 [email protected] Have flutter.js load local canvaskit instead of the CDN when appropriate (flutter/flutter#150806) 2024-06-27 [email protected] Roll Flutter Engine from a9194f0f01f4 to b42c80460538 (10 revisions) (flutter/flutter#150940) 2024-06-27 [email protected] [a11y] Reland [#149375 ] Update semantics in dropdown.dart (flutter/flutter#150578) 2024-06-27 [email protected] Bump dartdoc to 8.0.9+1 (flutter/flutter#150935) 2024-06-27 [email protected] add onFocus to text fields (flutter/flutter#150648) 2024-06-27 [email protected] Fixes `flutter build ipa` failure: Command line name "app-store" is deprecated. Use "app-store-connect" (flutter/flutter#150407) 2024-06-27 [email protected] Copy any previous `IconThemeData` instead of overwriting it in CupertinoButton (flutter/flutter#149777) 2024-06-27 [email protected] Improve the behavior of scrollbar drag-scrolls triggered by the trackpad (flutter/flutter#150275) 2024-06-27 [email protected] feat: Add autofocus for `MenuItemButton` (flutter/flutter#139396) 2024-06-27 [email protected] Roll Flutter Engine from 1d5e3cc55a75 to a9194f0f01f4 (7 revisions) (flutter/flutter#150888) 2024-06-26 [email protected] Reland "Remove dual_screen from new_gallery integration test" (flutter/flutter#150873) 2024-06-26 [email protected] Switch to more reliable flutter.dev link destinations in the tool (flutter/flutter#150587) 2024-06-26 [email protected] Adding `@docImport`s to the `animation` library (flutter/flutter#150798) 2024-06-26 [email protected] Remove CODEOWNERS trailing whitespace (flutter/flutter#150882) 2024-06-26 [email protected] Roll Flutter Engine from e03cf86c4170 to 1d5e3cc55a75 (3 revisions) (flutter/flutter#150875) 2024-06-26 [email protected] Remind folks we are moving. (flutter/flutter#150872) 2024-06-26 [email protected] Remove `bringup: true` from web test shard. (flutter/flutter#150785) 2024-06-26 [email protected] Roll Flutter Engine from c0017bed42c2 to e03cf86c4170 (1 revision) (flutter/flutter#150867) 2024-06-26 98614782+auto-submit[bot]@users.noreply.github.com Reverts "Remove `dual_screen` from `new_gallery` integration test (#150808)" (flutter/flutter#150871) 2024-06-26 [email protected] Remove `dual_screen` from `new_gallery` integration test (flutter/flutter#150808) 2024-06-26 [email protected] Roll Flutter Engine from d4624a36712b to c0017bed42c2 (4 revisions) (flutter/flutter#150865) 2024-06-26 [email protected] Fixes for Style Guide for Flutter Repo (flutter/flutter#150167) 2024-06-26 [email protected] Roll Flutter Engine from da62c629ed5c to d4624a36712b (3 revisions) (flutter/flutter#150852) 2024-06-26 [email protected] Use `Isolate.packageConfigSync! to locate the packageconfig of flutter tools (flutter/flutter#150340) 2024-06-26 [email protected] Roll Flutter Engine from 25af762ffbb3 to da62c629ed5c (2 revisions) (flutter/flutter#150829) 2024-06-26 [email protected] Fix leaky tests. (flutter/flutter#150817) 2024-06-26 [email protected] Roll Flutter Engine from 94023d711db3 to 25af762ffbb3 (4 revisions) (flutter/flutter#150818) 2024-06-26 [email protected] Roll pub packages (flutter/flutter#150810) 2024-06-25 [email protected] Remove reference to `MaterialApp` and `showCupertinoModalPopup` from `CupertinoAlertDialog` (flutter/flutter#150725) 2024-06-25 [email protected] Read `AndroidManifest.xml` and emit `manifest-impeller-(enabled|disabled)` analytics (flutter/flutter#150791) 2024-06-25 [email protected] [flutter_tools] Shut down Chromium cleanly using a command sent through the debug protocol (flutter/flutter#150645) 2024-06-25 [email protected] Reland fix inputDecorator hint color on M3 (flutter/flutter#150278) 2024-06-25 [email protected] Roll Flutter Engine from 62e0b5f9c340 to 94023d711db3 (7 revisions) (flutter/flutter#150797) 2024-06-25 [email protected] Fix collapsed InputDecorator minimum height (flutter/flutter#150770) 2024-06-25 [email protected] Add more warm up frame docs (flutter/flutter#150464) 2024-06-25 [email protected] Roll pub packages (flutter/flutter#150739) 2024-06-25 [email protected] Add `focusNode`, `focusColor`, `onFocusChange`, `autofocus` to `CupertinoButton` (flutter/flutter#150721) 2024-06-25 [email protected] Document RenderObject._relayoutBoundary and its invariant; small refactors (flutter/flutter#150527) 2024-06-25 [email protected] Roll Flutter Engine from 6313b1e5afd7 to 62e0b5f9c340 (1 revision) (flutter/flutter#150790) ...

…eprecated. Use "app-store-connect" (flutter#150407) Fixes flutter#149369

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

github-actions bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jun 18, 2024

LouiseHsu changed the title ~~build ipa~~ Fixes flutter build ipa failure: Command line name "app-store" is deprecated. Use "app-store-connect" Jun 18, 2024

LouiseHsu marked this pull request as ready for review June 18, 2024 18:03

LouiseHsu requested a review from jmagman June 18, 2024 18:03

jmagman reviewed Jun 18, 2024

View reviewed changes

LouiseHsu requested a review from jmagman June 21, 2024 16:07

jmagman reviewed Jun 21, 2024

View reviewed changes

This comment was marked as duplicate.

Sign in to view

LouiseHsu requested a review from jmagman June 26, 2024 21:10

flutter-dashboard bot added the will affect goldens Changes to golden files label Jun 26, 2024

jmagman approved these changes Jun 26, 2024

View reviewed changes

jmagman added autosubmit Merge PR when tree becomes green via auto submit App and removed will affect goldens Changes to golden files labels Jun 26, 2024

jmagman force-pushed the build-ipa branch from d9fb228 to 88e5e25 Compare June 26, 2024 21:37

jmagman mentioned this pull request Jun 26, 2024

flutter build ipa fails: Command line name "app-store" is deprecated. Use "app-store-connect" #149369

Closed

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024

LouiseHsu added 9 commits June 26, 2024 15:01

initial

26c94c9

oops wrong version

7c1abb5

some extra comments n stuff

7e10df0

typo

21fb1fc

pr comments

ddc72bb

.

426a387

spelling is hard

5ad1e43

pr comments!

ed443d8

whitespace

c6453c1

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024

jmagman added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024

auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jun 26, 2024

LouiseHsu added the autosubmit Merge PR when tree becomes green via auto submit App label Jun 27, 2024

auto-submit bot merged commit 9a67317 into flutter:master Jun 27, 2024

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ef34436402be (39 revisions) flutter/packages#6996

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

1e469fe

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ba03c59406c7 (40 revisions) flutter/packages#6999

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

1516c96

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 27, 2024

Roll Flutter from e726eb401c2c to ab4d42221349 (42 revisions) flutter/packages#7000

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 27, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

5e5352e

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Manual roll Flutter from e726eb401c2c to 15f95ce0c38e (48 revisions) flutter/packages#7002

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

07784df

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to eb58fe16b60f (50 revisions) flutter/packages#7005

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

553f3f0

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to 9e1efd8bcce7 (51 revisions) flutter/packages#7006

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

52f61ef

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to 47e65e806f75 (52 revisions) flutter/packages#7007

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

e230bd9

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to 3a97a38c41f1 (53 revisions) flutter/packages#7008

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

ffb9ff5

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

engine-flutter-autoroll mentioned this pull request Jun 28, 2024

Roll Flutter from e726eb401c2c to f5b671aac723 (54 revisions) flutter/packages#7009

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 28, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

6ff5648

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jul 8, 2024

Fixes flutter build ipa failure: Command line name "app-store" is d…

b7eee49

…eprecated. Use "app-store-connect" (flutter#150407) Fixes flutter#149369

engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024

9a67317 Fixes flutter build ipa failure: Command line name "app-sto…

4cf0df4

…re" is deprecated. Use "app-store-connect" (flutter/flutter#150407)

huycozy mentioned this pull request Aug 7, 2024

"Encountered invalid export-method input." when running flutter build ipa --export-method enterprise using Flutter 3.24 #153000

Closed

	'app-store': 'Upload to the App Store. For XCode <= 15.3.',
	'app-store': 'Upload to the App Store. For Xcode <= 15.3.',

	'app-store-connect': 'Upload to the App Store. For XCode > 15.3',
	'app-store-connect': 'Upload to the App Store.',

	if (currVersion.major >= 16 \|\| (currVersion.major == 15 && currVersion.minor > 3)) {
	if (currVersion >= Version(15, 4, 0)) {

Fixes flutter build ipa failure: Command line name "app-store" is deprecated. Use "app-store-connect" #150407

Fixes flutter build ipa failure: Command line name "app-store" is deprecated. Use "app-store-connect" #150407

Uh oh!

Conversation

LouiseHsu commented Jun 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-launch Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment was marked as duplicate.

saumon commented Jun 26, 2024

Uh oh!

flutter-dashboard bot commented Jun 26, 2024

Uh oh!

jmagman commented Jun 26, 2024

Uh oh!

LouiseHsu commented Jun 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

auto-submit bot commented Jun 26, 2024

Uh oh!

auto-submit bot commented Jun 26, 2024

Uh oh!

auto-submit bot commented Jun 26, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Fixes `flutter build ipa` failure: Command line name "app-store" is deprecated. Use "app-store-connect" #150407

Fixes `flutter build ipa` failure: Command line name "app-store" is deprecated. Use "app-store-connect" #150407

LouiseHsu commented Jun 18, 2024 •

edited

Loading

LouiseHsu commented Jun 26, 2024 •

edited

Loading