Revert "[CupertinoActionSheet] Add sliding tap gesture" #150147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 87f68a8.
github-actions
bot
added
framework
yaakovschectman
approved these changes
Jun 12, 2024
Contributor
yaakovschectman
left a comment
yaakovschectman
left a comment
There was a problem hiding this comment.
I honestly haven't the slightest understanding how these PRs and errors must be interplaying to produce the results we're seeing, but if we're reverting to get around some kind of infra problem, then so be it.
Contributor
Author
|
I don't know either. It's just impossible that after I triaging all the golden files provided and merging the PR with autosubmit, it still gives the post-submit error. Let me just give a try. |
dkwingsmt
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
Contributor
|
auto label is removed for flutter/flutter/150147, due to - The status or check suite Google testing has failed. Please fix the issues identified (or deflake) before re-applying this label. |
dkwingsmt
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Jun 13, 2024
dkwingsmt
added a commit
that referenced
this pull request
Jun 13, 2024
)" This reverts commit 317ad4a.
auto-submit bot
pushed a commit
to flutter/packages
that referenced
this pull request
Jun 13, 2024
flutter/flutter@b1f9d71...01db23b 2024-06-13 [email protected] Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (flutter/flutter#150199) 2024-06-13 [email protected] Revert "[CupertinoActionSheet] Add sliding tap gesture" (flutter/flutter#150147) 2024-06-13 [email protected] RawScrollbar: don't listen for drag gestures when scrolling is not possible (flutter/flutter#149925) 2024-06-13 [email protected] Update testowners (flutter/flutter#150141) 2024-06-12 [email protected] Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter/flutter#150142) 2024-06-12 [email protected] Reland 2: [CupertinoActionSheet] Match colors to native (flutter/flutter#150129) 2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/flutter#150132) 2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.8 to 3.25.9 (flutter/flutter#150133) 2024-06-12 [email protected] Improve build time when using SwiftPM (flutter/flutter#150052) 2024-06-12 [email protected] Reland: Request focus if accessibility focus is given to a Focus widget (#142942) (flutter/flutter#149840) 2024-06-12 [email protected] Update WidgetStatesController docs (flutter/flutter#150081) 2024-06-12 [email protected] [Reland] Fix `SegmentedButton` clipping when drawing segments (#149739) (flutter/flutter#150090) 2024-06-12 [email protected] Fix markdown hyperlinks in the style guide (flutter/flutter#150071) 2024-06-12 [email protected] Update packages desktop PR triage link lables (flutter/flutter#150124) 2024-06-12 [email protected] Add mouse cursor property to `CupertinoRadio` (flutter/flutter#149681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
dkwingsmt
added a commit
to dkwingsmt/flutter
that referenced
this pull request
Jun 13, 2024
) This reverts commit 317ad4a.
9 tasks
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
Reverts flutter#149471. I will reland it without changes in the future. There have been CI post-submit errors reported, such as flutter#150142, that the two golden files introduced in flutter#149471 were untriaged. The only explanation I can think of is that flutter#149471 being merged during the infra P0 left some inconsistency in the golden database.
victorsanni
pushed a commit
to victorsanni/flutter
that referenced
this pull request
Jun 14, 2024
Reverts flutter#149471. I will reland it without changes in the future. There have been CI post-submit errors reported, such as flutter#150142, that the two golden files introduced in flutter#149471 were untriaged. The only explanation I can think of is that flutter#149471 being merged during the infra P0 left some inconsistency in the golden database.
auto-submit bot
pushed a commit
that referenced
this pull request
Jun 17, 2024
Relands #149471. As explained in #150147, the original PR was reverted in an attempt to fix the strange golden file failure that occurred in other PRs. The following code is changed: * The two tests that contain golden tests are changed so that, they used to slide from button 1 to button 2, now they slide from button 2 to button 1. This is to ensure the golden file record are updated.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/packages
that referenced
this pull request
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #149471. I will reland it without changes in the future.
There have been CI post-submit errors reported, such as #150142, that the two golden files introduced in #149471 were untriaged. The only explanation I can think of is that #149471 being merged during the infra P0 left some inconsistency in the golden database.