Skip to content

Conversation

@yaakovschectman
Copy link
Contributor

Reverts #150129

Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit.

See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout

@yaakovschectman yaakovschectman added the revert Autorevert PR (with "Reason for revert:" comment) label Jun 12, 2024
@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. f: cupertino flutter/packages/flutter/cupertino repository labels Jun 12, 2024
@yaakovschectman
Copy link
Contributor Author

Reason for revert: Gold tests failing

Copy link
Contributor

@dkwingsmt dkwingsmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yaakovschectman yaakovschectman merged commit 7b6d667 into master Jun 12, 2024
@yaakovschectman yaakovschectman deleted the revert-150129-reland2-as-fix-color branch June 12, 2024 23:34
@dkwingsmt
Copy link
Contributor

The error golden file is not introduced by this PR, but an earlier PR

00:11 +265 ~1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/action_sheet_test.dart: Taps on a button can be slided to other buttons
══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞════════════════════════════════════════════════════
The following SkiaException was thrown while running async test code:
Skia Gold received an unapproved image in post-submit
testing. Golden file images in flutter/flutter are triaged
in pre-submit during code review for the given PR.

Visit https://flutter-gold.skia.org// to view and approve
the image(s), or revert the associated change. For more
information, visit the wiki:
https://github.com/flutter/flutter/wiki/Writing-a-golden-file-test-for-package:flutter

Debug information for Gold --------------------------------
stdout: Given image with hash 0490f1633c65bd4a023b993c242b7139 for test
cupertino.cupertinoActionSheet.press-drag
Expectation for test: 3bb57a8782f67836c6ad3ece7f00729a (positive)
Expectation for test: 3f8c592774caf3c760fbbd318a7dc5af (positive)
Expectation for test: 61863f38217aa3349c239eeb49b84930 (positive)
Expectation for test: 98af16e9b7eb3fb810b44c74bb18ffb9 (positive)
Expectation for test: ce8ef79c146857d162663b1161fd6d5c (positive)
Untriaged or negative image:
https://flutter-gold.skia.org/detail?grouping=name%3Dcupertino.cupertinoActionSheet.press-drag%26source_type%3Dflutter&digest=0490f1633c65bd4a023b993c242b7139


stderr: Test: cupertino.cupertinoActionSheet.press-drag FAIL


result-state.json: No result file found.

When the exception was thrown, this was the stack:
#0      SkiaGoldClient.imgtestAdd (package:flutter_goldens/skia_client.dart:248:7)
<asynchronous suspension>
#1      MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart:118:32)
<asynchronous suspension>
<asynchronous suspension>
#3      _expect.<anonymous closure> (package:matcher/src/expect/expect.dart:123:26)
<asynchronous suspension>
<asynchronous suspension>
#5      expectLater.<anonymous closure> (package:flutter_test/src/widget_tester.dart:512:24)
<asynchronous suspension>
#6      main.<anonymous closure> (file:///C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/action_sheet_test.dart:758:5)
<asynchronous suspension>
#7      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:183:15)
<asynchronous suspension>
#8      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1025:5)
<asynchronous suspension>
<asynchronous suspension>
(elided 3 frames from dart:async and package:stack_trace)

The exception was caught asynchronously.
════════════════════════════════════════════════════════════════════════════════════════════════════
00:11 +265 ~1 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/context_menu_test.dart: Conflicting gesture detectors
00:11 +265 ~1 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/action_sheet_test.dart: Taps on a button can be slided to other buttons [E]
  Test failed. See exception logs above.
  The test description was: Taps on a button can be slided to other buttons
  
00:11 +266 ~1 -1: C:/b/s/w/ir/x/w/flutter/packages/flutter/test/cupertino/context_menu_test.dart: Conflicting gesture detectors

@yaakovschectman
Copy link
Contributor Author

I am not quite following. What is it in that error log that indicates that this error file was introduced in an earlier PR?

@dkwingsmt
Copy link
Contributor

dkwingsmt commented Jun 12, 2024

stderr: Test: cupertino.cupertinoActionSheet.press-drag FAIL

Both golden files that failed were introdced, and were the only golden files introduced in #149471, which was also merged during the infra P0.

The problem is, there is no way #150129 was merged with untriaged golden, even if I wanted to, because I used autosubmit to merge. The only explanation I can think of is that #149471 caused some inconsistency in the golden file database.

hello-coder-xu added a commit to hello-coder-xu/flutter that referenced this pull request Jun 13, 2024
…Extent-add-assert

* master:
  Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter#150142)
  Reland 2: [CupertinoActionSheet] Match colors to native (flutter#150129)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2024
auto-submit bot pushed a commit that referenced this pull request Jun 13, 2024
Reverts #149471. I will reland it without changes in the future.

There have been CI post-submit errors reported, such as #150142, that the two golden files introduced in #149471 were untriaged. The only explanation I can think of is that #149471 being merged during the infra P0 left some inconsistency in the golden database.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 13, 2024
auto-submit bot pushed a commit to flutter/packages that referenced this pull request Jun 13, 2024
flutter/flutter@b1f9d71...01db23b

2024-06-13 [email protected] Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (flutter/flutter#150199)
2024-06-13 [email protected] Revert "[CupertinoActionSheet] Add sliding tap gesture" (flutter/flutter#150147)
2024-06-13 [email protected] RawScrollbar: don't listen for drag gestures when scrolling is not possible (flutter/flutter#149925)
2024-06-13 [email protected] Update testowners (flutter/flutter#150141)
2024-06-12 [email protected] Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter/flutter#150142)
2024-06-12 [email protected] Reland 2: [CupertinoActionSheet] Match colors to native (flutter/flutter#150129)
2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/flutter#150132)
2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.8 to 3.25.9 (flutter/flutter#150133)
2024-06-12 [email protected] Improve build time when using SwiftPM (flutter/flutter#150052)
2024-06-12 [email protected] Reland: Request focus if accessibility focus is given to a Focus widget (#142942) (flutter/flutter#149840)
2024-06-12 [email protected] Update WidgetStatesController docs (flutter/flutter#150081)
2024-06-12 [email protected] [Reland] Fix `SegmentedButton` clipping when drawing segments (#149739) (flutter/flutter#150090)
2024-06-12 [email protected] Fix markdown hyperlinks in the style guide (flutter/flutter#150071)
2024-06-12 [email protected] Update packages desktop PR triage link lables (flutter/flutter#150124)
2024-06-12 [email protected] Add mouse cursor property to `CupertinoRadio` (flutter/flutter#149681)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
Reverts flutter#149471. I will reland it without changes in the future.

There have been CI post-submit errors reported, such as flutter#150142, that the two golden files introduced in flutter#149471 were untriaged. The only explanation I can think of is that flutter#149471 being merged during the infra P0 left some inconsistency in the golden database.
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
Reverts flutter#149471. I will reland it without changes in the future.

There have been CI post-submit errors reported, such as flutter#150142, that the two golden files introduced in flutter#149471 were untriaged. The only explanation I can think of is that flutter#149471 being merged during the infra P0 left some inconsistency in the golden database.
dkwingsmt added a commit to dkwingsmt/flutter that referenced this pull request Jun 17, 2024
auto-submit bot pushed a commit that referenced this pull request Jun 17, 2024
Relands #149568 (first attempt) or #150129 (latest attempt), which was reverted in #150142 due to unverified golden tests post-commit from recent infra issues.

No code is changed from #150129.

The relevant golden files have been resubmitted in #150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
auto-submit bot added a commit that referenced this pull request Jun 18, 2024
…0386)" (#150413)

Reverts: #150386
Initiated by: andrewkolos
Reason for reverting: the Mac framework_tests_impeller check has been failing (due to golden test failures) since this PR (though it occasionally passes after retry). Taking a brief look at this PR, it looks like there's been some troubles with goldens in the past (though the recent failures appear very different to past ones). Regardless, I'm taking a shot at getting the tree green again by reverting this. Apologies i
Original PR Author: dkwingsmt

Reviewed By: {chunhtai}

This change reverts the following previous change:
Relands #149568 (first attempt) or #150129 (latest attempt), which was reverted in #150142 due to unverified golden tests post-commit from recent infra issues.

No code is changed from #150129.

The relevant golden files have been resubmitted in #150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. revert Autorevert PR (with "Reason for revert:" comment)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants