-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Reland 2: [CupertinoActionSheet] Match colors to native #150129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
flutter#149568) (flutter#150015)" (flutter#150021)" This reverts commit 5eaeaca.
|
Golden file changes have been found for this pull request. Click here to view and triage (e.g. because this is an intentional change). If you are still iterating on this change and are not ready to resolve the images on the Flutter Gold dashboard, consider marking this PR as a draft pull request above. You will still be able to view image results on the dashboard, commenting will be silenced, and the check will not try to resolve itself until marked ready for review. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
cc @b3nni97 |
e37c694 to
5ca5139
Compare
chunhtai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Golden file changes are available for triage from new commit, Click here to view. For more guidance, visit Writing a golden file test for Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
)" This reverts commit bb9daf5.
…0142) Reverts #150129 Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit. See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
…Extent-add-assert * master: Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter#150142) Reland 2: [CupertinoActionSheet] Match colors to native (flutter#150129)
flutter/flutter@b1f9d71...01db23b 2024-06-13 [email protected] Roll Flutter Engine from c7fcbfce608f to 4cb3025d3abf (28 revisions) (flutter/flutter#150199) 2024-06-13 [email protected] Revert "[CupertinoActionSheet] Add sliding tap gesture" (flutter/flutter#150147) 2024-06-13 [email protected] RawScrollbar: don't listen for drag gestures when scrolling is not possible (flutter/flutter#149925) 2024-06-13 [email protected] Update testowners (flutter/flutter#150141) 2024-06-12 [email protected] Revert "Reland 2: [CupertinoActionSheet] Match colors to native" (flutter/flutter#150142) 2024-06-12 [email protected] Reland 2: [CupertinoActionSheet] Match colors to native (flutter/flutter#150129) 2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.6 to 4.1.7 (flutter/flutter#150132) 2024-06-12 49699333+dependabot[bot]@users.noreply.github.com Bump github/codeql-action from 3.25.8 to 3.25.9 (flutter/flutter#150133) 2024-06-12 [email protected] Improve build time when using SwiftPM (flutter/flutter#150052) 2024-06-12 [email protected] Reland: Request focus if accessibility focus is given to a Focus widget (#142942) (flutter/flutter#149840) 2024-06-12 [email protected] Update WidgetStatesController docs (flutter/flutter#150081) 2024-06-12 [email protected] [Reland] Fix `SegmentedButton` clipping when drawing segments (#149739) (flutter/flutter#150090) 2024-06-12 [email protected] Fix markdown hyperlinks in the style guide (flutter/flutter#150071) 2024-06-12 [email protected] Update packages desktop PR triage link lables (flutter/flutter#150124) 2024-06-12 [email protected] Add mouse cursor property to `CupertinoRadio` (flutter/flutter#149681) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Relands flutter#149568, which was reverted in flutter#149998 due to unverified golden tests post-commit from recent infra issues. **New changes** (all contained in flutter@5ca5139 ): * Fixes a problem within the tests "Overall looks correctly under x theme" where the button press is not applied to the golden file. * Dark theme now uses colors different from the light theme. It was an issue reported in flutter#149568 (comment). I made the mistake because the XCode preview doesn't correctly apply dark theme, which made me think the dark theme uses the same colors. As shown in the following table, the dark theme colors also achieved deviation of <=1. <img width="1091" alt="image" src="https://github.com/flutter/flutter/assets/1596656/f4acda2b-1857-449c-8c1b-1f48afeb9095"> Screenshot comparison: (left to right: native, Flutter after PR, Flutter before PR) <img width="1286" alt="image" src="https://github.com/flutter/flutter/assets/1596656/580eef1f-a7f9-45d9-a7c8-fab0ca9606e3">
…tter#150142) Reverts flutter#150129 Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit. See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
Relands flutter#149568, which was reverted in flutter#149998 due to unverified golden tests post-commit from recent infra issues. **New changes** (all contained in flutter@5ca5139 ): * Fixes a problem within the tests "Overall looks correctly under x theme" where the button press is not applied to the golden file. * Dark theme now uses colors different from the light theme. It was an issue reported in flutter#149568 (comment). I made the mistake because the XCode preview doesn't correctly apply dark theme, which made me think the dark theme uses the same colors. As shown in the following table, the dark theme colors also achieved deviation of <=1. <img width="1091" alt="image" src="https://github.com/flutter/flutter/assets/1596656/f4acda2b-1857-449c-8c1b-1f48afeb9095"> Screenshot comparison: (left to right: native, Flutter after PR, Flutter before PR) <img width="1286" alt="image" src="https://github.com/flutter/flutter/assets/1596656/580eef1f-a7f9-45d9-a7c8-fab0ca9606e3">
…tter#150142) Reverts flutter#150129 Still introducing failure for flutter gold. The failure and error messages are specifically pointing to the test file modified by this commit. See https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8745296364911252625/+/u/run_test.dart_for_framework_tests_shard_and_subshard_libraries/stdout
Relands #149568 (first attempt) or #150129 (latest attempt), which was reverted in #150142 due to unverified golden tests post-commit from recent infra issues. No code is changed from #150129. The relevant golden files have been resubmitted in #150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
…0386)" (#150413) Reverts: #150386 Initiated by: andrewkolos Reason for reverting: the Mac framework_tests_impeller check has been failing (due to golden test failures) since this PR (though it occasionally passes after retry). Taking a brief look at this PR, it looks like there's been some troubles with goldens in the past (though the recent failures appear very different to past ones). Regardless, I'm taking a shot at getting the tree green again by reverting this. Apologies i Original PR Author: dkwingsmt Reviewed By: {chunhtai} This change reverts the following previous change: Relands #149568 (first attempt) or #150129 (latest attempt), which was reverted in #150142 due to unverified golden tests post-commit from recent infra issues. No code is changed from #150129. The relevant golden files have been resubmitted in #150219. I expect these files to appear in the golden file checker in this PR (which will hint that this PR is safe.) Fingers crossed.
Relands #149568, which was reverted in #149998 due to unverified golden tests post-commit from recent infra issues.
New changes (all contained in 5ca5139 ):
Screenshot comparison: (left to right: native, Flutter after PR, Flutter before PR)

Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.