Skip to content

Reland "Add tests for scaffold drawer and end drawer" (#150045) #150047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Jun 12, 2024
Merged

Reland "Add tests for scaffold drawer and end drawer" (#150045) #150047

auto-submit merged 1 commit into from
Jun 12, 2024

Conversation

@ValentinVignal
Copy link
Contributor

@ValentinVignal ValentinVignal commented Jun 11, 2024 •
edited by bleroux
Loading

This relands commit 14df7be.

Contributes to #130459

Needs #149851 to be fixed before getting merged

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos labels Jun 11, 2024
@ValentinVignal ValentinVignal mentioned this pull request Jun 11, 2024
Merged
9 tasks
@bleroux bleroux requested review from TahaTesser and bleroux June 11, 2024 19:00
bleroux
bleroux approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@bleroux bleroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bleroux bleroux added autosubmit Merge PR when tree becomes green via auto submit App labels Jun 12, 2024
@auto-submit auto-submit bot merged commit 9b3c936 into flutter:master Jun 12, 2024
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
fcbb5c5 
…5) (flutter/flutter#150047)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
d0b3514 
…5) (flutter/flutter#150047)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
2264191 
…5) (flutter/flutter#150047)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
61aad2e 
…5) (flutter/flutter#150047)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
818a89b 
…5) (flutter/flutter#150047)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 12, 2024
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Jun 12, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
c34e199 
…5) (flutter/flutter#150047)
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@ValentinVignal @victorsanni
Reland "Add tests for scaffold drawer and end drawer" (flutter#150045) (
28b68d2 
flutter#150047)

This relands commit 14df7be.

Contributes to flutter#130459

Needs flutter#149851 to be fixed before getting merged
victorsanni pushed a commit to victorsanni/flutter that referenced this pull request Jun 14, 2024
@ValentinVignal @victorsanni
Reland "Add tests for scaffold drawer and end drawer" (flutter#150045) (
b9345fe 
flutter#150047)

This relands commit 14df7be.

Contributes to flutter#130459

Needs flutter#149851 to be fixed before getting merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request Aug 6, 2024
@engine-flutter-autoroll
9b3c936 Reland "Add tests for scaffold drawer and end drawer" (#15004…
0c85526 
…5) (flutter/flutter#150047)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bleroux bleroux bleroux approved these changes

@TahaTesser TahaTesser TahaTesser approved these changes

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App d: api docs Issues with https://api.flutter.dev/ d: examples Sample code and demos framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ValentinVignal @bleroux @TahaTesser